From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FE60A04E7; Mon, 2 Nov 2020 16:48:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34F93C942; Mon, 2 Nov 2020 16:48:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 47B41C92A for ; Mon, 2 Nov 2020 16:48:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604332085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QIUQruaLp5lvrmXtRSrzyMldnfArlPOwxXnZxtWysfk=; b=FV033Atv9ZPEt7zigNFY+gZvM9I0UXS/ldzf9AntRDXAzoRa3vTsKBteN1+m78yPC/ZXRd TidSDcki9RTUFViEEWAUyma1JdNfmHYt+kFpIkeCVACZfCWCrSUXVWLSareG9sbuKHEhXY BiWmcaHS0RpXkJ6iPp5P7I+C77RmlEY= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-TK2X9VNnP6CCDTbqKDcTsg-1; Mon, 02 Nov 2020 10:48:01 -0500 X-MC-Unique: TK2X9VNnP6CCDTbqKDcTsg-1 Received: by mail-vk1-f199.google.com with SMTP id f185so307267vkc.5 for ; Mon, 02 Nov 2020 07:48:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QIUQruaLp5lvrmXtRSrzyMldnfArlPOwxXnZxtWysfk=; b=GuyJXgVzB0OVbUyuHx2KB3aDhD9AJKl46D302dzh7qsxYWX82x1RAsSg/69naTA3Sm Ho2Y98r5DEOTNzSidcV2ZhjQThuhNu52vHfZiVGX9j/Zdu/91eALAjRuOYPo5OKUTO/W a4c0ACRhu7zVLXofzBPlGt6BOYgRDA1Kw2SCuTRfw/fan50T+Fd6vj/PEu65KxK6cBjW cnZKMSfgVODM67JT5U+g1SajtfTOH60O65e/BqvJrToTiulryWyXpdUpu0E1y5pctcgs 065BPv+o9wPd/Td01mtyIr9TbD+XKZGe2uHVFjaGao/umQqnvT00D0g2PDYq3fN0B4dP lSwg== X-Gm-Message-State: AOAM531oYY0Gty3eB9a5ATKTEKPTH2Ox3Hxf7p5RLHnkTCQ1QZg6e6Vp 7zr9yv8FTGrH9YWHCp6Y/5mfBKF2LAG3tZj1iXT4I4wr8mTuKT59n5+TvXXpj6BAb5crXKTkHmt EslcDJJhzZuhuMA3vsyw= X-Received: by 2002:a67:f954:: with SMTP id u20mr15475045vsq.5.1604332081425; Mon, 02 Nov 2020 07:48:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2D/2zPlH0jargVvIxpCcu84tvQqdxVvFh2QqI74z/QiDu6N8JmQ1UVVQxB7LJMqHpNYa+MpBVFf73YrmWbTM= X-Received: by 2002:a67:f954:: with SMTP id u20mr15475027vsq.5.1604332081205; Mon, 02 Nov 2020 07:48:01 -0800 (PST) MIME-Version: 1.0 References: <20201029092751.3837177-1-thomas@monjalon.net> <20201101180626.2198868-1-thomas@monjalon.net> <20201101180626.2198868-15-thomas@monjalon.net> <20201102154146.GA1898@platinum> In-Reply-To: <20201102154146.GA1898@platinum> From: David Marchand Date: Mon, 2 Nov 2020 16:47:50 +0100 Message-ID: To: Thomas Monjalon , Olivier Matz Cc: dev , "Yigit, Ferruh" , Bruce Richardson , Andrew Rybchenko , Jerin Jacob Kollanukkaran , Slava Ovsiienko , Ajit Khaparde , Ray Kinsella , Neil Horman Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 14/14] mbuf: remove deprecated timestamp field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 2, 2020 at 4:41 PM Olivier Matz wrote: > > --- a/lib/librte_mbuf/rte_mbuf_core.h > > +++ b/lib/librte_mbuf/rte_mbuf_core.h > > @@ -149,11 +149,6 @@ extern "C" { > > */ > > #define PKT_RX_LRO (1ULL << 16) > > > > -/** > > - * Indicate that the timestamp field in the mbuf is valid. > > - */ > > -#define PKT_RX_TIMESTAMP (1ULL << 17) > > - > > /** > > * Indicate that security offload processing was applied on the RX packet. > > */ > > nit: can we keep a comment here to highlight the flag 17 is unused? What about marking it free in free_flags? -- David Marchand