From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C2D54612A; Fri, 24 Jan 2025 15:54:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2F6540E48; Fri, 24 Jan 2025 15:54:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 23E99402A3 for ; Fri, 24 Jan 2025 15:54:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737730453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kkfeNBzQox8Eo4f59eBfChMP7lyhJBOoage1ZT5HF5s=; b=FXzSGy0c3be8Wy3rwhGZ7bpgCuWbElNqmuAg8EVAuLDq8pyW7rGl3BBcHGXleY76PLkEy2 cjbUw8FcvbI7WC8ypLs3QLiCfNCtyqv7nlhsEKMBd4hlsd/S2z1v8WDt6vnFSA7dH8HClE ESOmfrydkPtSyubc0J11sJlREZfa3ng= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-493-WR4I7N9HPxiNEGvUkXxPAQ-1; Fri, 24 Jan 2025 09:54:12 -0500 X-MC-Unique: WR4I7N9HPxiNEGvUkXxPAQ-1 X-Mimecast-MFC-AGG-ID: WR4I7N9HPxiNEGvUkXxPAQ Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-3022a57a4fdso17068231fa.1 for ; Fri, 24 Jan 2025 06:54:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737730451; x=1738335251; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kkfeNBzQox8Eo4f59eBfChMP7lyhJBOoage1ZT5HF5s=; b=n75hCFgt44Ue+lvxF4VCJauDFfZFkhLZXqQNM1rtU8Z39eO+ofXE1uMc+oiMy/fWEP qQ9yOLYIJGCCLC/DNVPMBkSFEOgEb/473vzu0nTivlp/XAHJaJTXXq8MfpGodynqLqJf DPEqNUrIBD+5aVmsG6hoWy2LmR+D7MhZ9hPbgdaWdk/ZMFSTfTTtUqmZLMYdMr30qrh1 EUXTvUU1FeP+KQ1hPh/Kp9ZELzXbucJeo5BupGcESP14viNB3xZZ0mL38P8jMC0xTmro S86LPrLAaGlsSAwanv+PNwtFph/hkoW5L2kud8+YDU+Nle3xgzH3d7j/Qa0PdZy1XQXp Mjvg== X-Gm-Message-State: AOJu0Yx9jBL02RtcXJ5EOKo6Tyhr8WkjXt5BS5OFLm0+Aw3eA8oljNst fR4bAn/PrbyeTZhPpawI8Ry8BxF+sHd1Bw8GtSiH0kZzGj+kG5FkgBUNrIxm2ZUYEJ7HFtsPGOL BL7mN8Z3EEYuZLiESkn6EA1uNF1Ki5+XWu2ZAzd2jVU7TstkPvdMxtgrrNnPZ+w948CZomwxaUv nBpJlXCLnwosnwrWs= X-Gm-Gg: ASbGncu1Ks6twS8ZelJ5qWVoOAzW2EM5oxxFBVvE0mqCI4SsmiZjzPwRfNqccT3ed3W 4p12sBeHxRZPbTqwqQyI5WZ6WzB7LrrfXBn44egq7od6frOhAY9Hvag== X-Received: by 2002:a2e:a4c6:0:b0:302:25ef:813e with SMTP id 38308e7fff4ca-3072cb39782mr107377801fa.32.1737730450840; Fri, 24 Jan 2025 06:54:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IG2pPO5p0CYYQFuw8FonWR+CVUUUOFX+nipVmdjy2OI01nau6sCOOM2qg9R6oeyzxuakSkvmckE0swuN8EOA6w= X-Received: by 2002:a2e:a4c6:0:b0:302:25ef:813e with SMTP id 38308e7fff4ca-3072cb39782mr107377691fa.32.1737730450421; Fri, 24 Jan 2025 06:54:10 -0800 (PST) MIME-Version: 1.0 References: <1710969879-23701-1-git-send-email-roretzla@linux.microsoft.com> <1733430950-10412-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1733430950-10412-1-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Fri, 24 Jan 2025 15:53:58 +0100 X-Gm-Features: AWEUYZnv3tlBZH6S__kVxFN3R-uVKSkhcZ6e_2-45-8fK0P2n4QdEVNQWWp6olw Message-ID: Subject: Re: [PATCH v2 0/3] provide rte_ffs32, rte_ffs64 and __rte_x86_movdiri To: Andre Muezerie Cc: dev@dpdk.org, Jack Bond-Preston X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: X-ddTb5Nkf9HqiPrkOBLcpbMXLTmHZ1gkgQiYa-lUX4_1737730451 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 5, 2024 at 9:36=E2=80=AFPM Andre Muezerie wrote: > > MSVC does not support inline assembly so use movdiri intrinsic and > provide abstracted rte_ffs{32,64} inline functions instead of directly > using GCC built-ins. > > v2: > * Moved constants to the right side of the comparison > * Added tests for rte_ffs32 and rte_ffs64 functions > > Andre Muezerie (1): > app/test: add test for rte_ffs32 and rte_ffs64 functions. > > Tyler Retzlaff (2): > eal: provide movdiri for MSVC > eal: add rte ffs32 and rte ffs64 inline functions > > app/test/test_bitops.c | 38 ++++++++++++++++++++++++++++++++++++ > lib/eal/include/rte_bitops.h | 34 ++++++++++++++++++++++++++++++++ > lib/eal/x86/include/rte_io.h | 4 ++++ > 3 files changed, 76 insertions(+) > I see nothing wrong with adding those wrappers to ease MSVC support. Just, those two ffs helpers should be marked experimental. And the unit tests for counting/searching bits had been separated in a dedicated app/test/test_bitcount.c. --=20 David Marchand