From: David Marchand <david.marchand@redhat.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Stephen Hemminger <stephen@networkplumber.org>,
dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
Aaron Conole <aconole@redhat.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] eal/reciprocal: fix off by one when divisor is 32bit
Date: Tue, 15 Oct 2019 11:06:13 +0200 [thread overview]
Message-ID: <CAJFAV8yL9wuPM90FAOMU3RTw-MsMH7bUrm1CjmcvMotboXufxA@mail.gmail.com> (raw)
In-Reply-To: <CY4PR1801MB1863EF61BB20C395E882E76EDE930@CY4PR1801MB1863.namprd18.prod.outlook.com>
On Tue, Oct 15, 2019 at 10:56 AM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> >-----Original Message-----
> >From: David Marchand <david.marchand@redhat.com>
> >Sent: Tuesday, October 15, 2019 2:16 PM
> >To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Stephen
> >Hemminger <stephen@networkplumber.org>
> >Cc: dev <dev@dpdk.org>; Pavan Nikhilesh Bhagavatula
> ><pbhagavatula@marvell.com>; dpdk stable <stable@dpdk.org>; Aaron
> >Conole <aconole@redhat.com>
> >Subject: Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one
> >when divisor is 32bit
> >On Tue, Sep 3, 2019 at 9:17 PM <pbhagavatula@marvell.com> wrote:
> >>
> >> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>
> >> Fix off by one error in 64bit reciprocal division when divisor is 32bit.
> >>
> >> Fixes: 6d45659eacb8 ("eal: add u64-bit variant for reciprocal divide")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> >Any review?
> >
> >Are we missing an update in the unit test to catch this issue?
> >Thanks.
>
> We actually caught it in a unit test
> >test_reciprocal_division
We had this problem since the very start then.
Both reciprocal_division and reciprocal_division_perf are in the "perf" list.
Can they be promoted to the standard list?
--
David Marchand
next prev parent reply other threads:[~2019-10-15 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 19:16 [dpdk-dev] " pbhagavatula
2019-10-15 8:45 ` David Marchand
2019-10-15 8:56 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-10-15 9:06 ` David Marchand [this message]
2019-10-26 14:33 ` [dpdk-dev] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yL9wuPM90FAOMU3RTw-MsMH7bUrm1CjmcvMotboXufxA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).