From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2FAEA0544; Mon, 10 Oct 2022 21:33:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7165B40143; Mon, 10 Oct 2022 21:33:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 96DD040041 for ; Mon, 10 Oct 2022 21:33:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665430392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YNxhb7sBph+X2K4D12FSpZxBonWGv4VtwACd2r4IZgs=; b=LWK3nY5nWglJ925jyfiOh+2vx6XEmjuLNwJZyU1gUZQn3feJuw35PcphIx2ROeHYMNkTb9 /w6nnNT3GCV+uU5q3qwfk0q975LA/1ztYvHPEF9E1Tw0rRM4zPprtz6VzzgmxUeWuolvNl DWS+Xm+CkWj5KHnTePHjcUgxAuIhLB4= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-228-yO1EZVqYMcajX4ThoFHeNQ-1; Mon, 10 Oct 2022 15:33:10 -0400 X-MC-Unique: yO1EZVqYMcajX4ThoFHeNQ-1 Received: by mail-pl1-f197.google.com with SMTP id u5-20020a170902e80500b00178944c46aaso8403870plg.4 for ; Mon, 10 Oct 2022 12:33:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YNxhb7sBph+X2K4D12FSpZxBonWGv4VtwACd2r4IZgs=; b=APe/56ZjLNgopUqGD6u/nNGSdGXlx0q4UkMmdCLKbgE/7g63RCuAz27AY4cM/QmHe0 eBMSggWJNEvicH6+tMdTnBlGBL/HpFzzRJLLDy8sN3WiUxXuOQExfccEOuTUFjxV246r TfZ5Ht5iUATqa6nmNTy49+lE89ROBxu1rAmEbrAgdlw19HKVWY0Kzlfjc6zjZSYS7acc LM3IHAJWXX21co79YUbNTVa0ZqHsDfZoizMhhsJ1S7QulwtFGBWzskGMDPOsdDJ/49mj M6+8faSgukgN8Aj4icb9G4rPRg+3RHUz8jHc4SCYElUx6e6zEj0zXOvYFv+7Oivl+h+W RATA== X-Gm-Message-State: ACrzQf1xriMnTDIwd319Svu13Hy9aD08ysufn8/oaBPlZLXsPJm1SFap SHsgMNu+rGpymoo/t2ULEsDaSvisgDEWvsE/4Va3MgVYy7J3NmCBntY2z8AF1VafpoWbnmoysg2 Fr8KMd3aemVUOmXp1YRQ= X-Received: by 2002:a05:6a00:1f10:b0:562:b9e1:55e9 with SMTP id be16-20020a056a001f1000b00562b9e155e9mr19477214pfb.60.1665430388704; Mon, 10 Oct 2022 12:33:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4yZS7R8jI2LSV5okArAtXUHftEMqOrP9FJObU/JRDNLXy5I2bGdLgga7BNNx6mx9i0SInW5zakwaSsDtlF2OA= X-Received: by 2002:a05:6a00:1f10:b0:562:b9e1:55e9 with SMTP id be16-20020a056a001f1000b00562b9e155e9mr19477204pfb.60.1665430388449; Mon, 10 Oct 2022 12:33:08 -0700 (PDT) MIME-Version: 1.0 References: <20221010175109.44282-1-kumaraparmesh92@gmail.com> In-Reply-To: <20221010175109.44282-1-kumaraparmesh92@gmail.com> From: David Marchand Date: Mon, 10 Oct 2022 21:32:56 +0200 Message-ID: Subject: Re: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame To: Kumara Parameshwaran Cc: jiayu.hu@intel.com, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 10, 2022 at 7:51 PM Kumara Parameshwaran wrote: > > From: Kumara Parameshwaran > > When GRO packets are merged the packet length is used while > merging the adjacent packets. If the padded bytes are accounted > we would end up acking unsent TCP segments. > > Signed-off-by: Kumara Parameshwaran > v1: > If there is padding to the ethernet frame cases where timestamp is disabled > the packet length should be validated with the total ip length as packet length > is used in the GRO merging logic Please, can you test with current main branch? We recently merged a fix: https://git.dpdk.org/dpdk/commit/?id=b8a55871d5af6f5b8694b1cb5eacbc629734e403 -- David Marchand