From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] eal/ppc: add missing header inclusion
Date: Fri, 17 Apr 2020 17:46:22 +0200 [thread overview]
Message-ID: <CAJFAV8yLesfwFTbG+=DJRHgJpH++ccTpec2mRhu+ogF_-8f19w@mail.gmail.com> (raw)
In-Reply-To: <22594704.5W6oEpyPa8@thomas>
On Fri, Apr 17, 2020 at 5:41 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 17/04/2020 17:25, David Marchand:
> > Compilation is broken on ppc:
> >
> > CC otx2_rx.o
> > In file included from .../drivers/net/octeontx2/otx2_rx.c:5:0:
> > .../builds/ppc_64-power8-linux-gcc/include/rte_vect.h:29:17:
> > error: expected declaration specifiers or ‘...’ before numeric constant
> > } __rte_aligned(16) rte_xmm_t;
> > ^~
> > compilation terminated due to -Wfatal-errors.
> >
> > Fixes: f35e5b3e07b2 ("replace alignment attributes")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Sorry for not having tested PPC.
>
> About the title:
> eal/ppc: fix missing include
> or
> eal/ppc: fix build
> ?
>
> Tested-by: Thomas Monjalon <thomas@monjalon.net>
Applied.
--
David Marchand
next prev parent reply other threads:[~2020-04-17 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 15:25 David Marchand
2020-04-17 15:41 ` Thomas Monjalon
2020-04-17 15:46 ` David Marchand [this message]
2020-04-18 22:20 ` David Christensen
2020-04-19 6:57 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yLesfwFTbG+=DJRHgJpH++ccTpec2mRhu+ogF_-8f19w@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).