From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C49F5A0544; Fri, 23 Sep 2022 10:30:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B91FF42836; Fri, 23 Sep 2022 10:30:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 905774282F for ; Fri, 23 Sep 2022 10:30:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663921823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cqTMWqU/bp2KhxgelXQOqNv4P+n0w0RHKAzVTLVx02Y=; b=DebqAGkDZPH+uc3Z/oInXUoyvlxgAI5tk3NzBHQ9iqcRYutn+IYswQdC/8n3uJyIdYUIsH O/w6EqJfkYBFfU5iTdYrh/KbdeHlUCyyoIV1o9zhjF/0vVLl9j4uafLWcKeasCOjMnxeYf Y+wgjerTZ3ngBMxA2GtVlPqiVVuuBfI= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-189-A15tnRADM7-eLpQx4DMjnA-1; Fri, 23 Sep 2022 04:29:39 -0400 X-MC-Unique: A15tnRADM7-eLpQx4DMjnA-1 Received: by mail-lf1-f69.google.com with SMTP id f18-20020a19dc52000000b0049f6087124fso3921783lfj.15 for ; Fri, 23 Sep 2022 01:29:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=cqTMWqU/bp2KhxgelXQOqNv4P+n0w0RHKAzVTLVx02Y=; b=CMW/rwsPQDrupOn7f6QHFG6E0v9BPupN5yv6dFaX4BjEt/IY649VybN/qXnJYjZ29c 8LmO50+BIXV5X5YxmLMc9rMhBtbBHXihxXxXwUwKQJQ6ErrTB19/OUMq+H7AtwS3jq92 PRSQ/IQxWgoEV4PMP23PwE4XmfePHsEOaI5CKo1StUQ/L5tv31cRlKFXDQuWa+tIV6kO j8u4V5prQtEqGQjfRK4sC73JT1TFc+rl7txCZLeSZqyssIjAts9SjjnrBHClcRgU2dma S4atiVn/1bOq0oW5UWeYVOfioNQOpnenFAHyGQYDfST6zOcabyYLSUPvUckEodHGQLU4 4vvQ== X-Gm-Message-State: ACrzQf238YlxjuHs30Y1UYrRPyvdKbA6iGEXgD7RhjryQVgIyPY7JKNk aauy8p95S1g4KEsFkbIg0kmtMAC12uzCyYr7V/exVXy0WxGOqy2v/Dnq+bGeJJg0YcKKOmLHZxP NcrSfc5JGM9zvUJtmm8U= X-Received: by 2002:a2e:9a88:0:b0:26a:c4d2:3418 with SMTP id p8-20020a2e9a88000000b0026ac4d23418mr2571404lji.81.1663921778334; Fri, 23 Sep 2022 01:29:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7xLEE484hJvoNDdMG3/ERknIxnPDAwzUaIhYhbs7fUra6CHOE0hSypKApnpivdS/Xp1l+UgiMdJkaNq532jPc= X-Received: by 2002:a2e:9a88:0:b0:26a:c4d2:3418 with SMTP id p8-20020a2e9a88000000b0026ac4d23418mr2571397lji.81.1663921778109; Fri, 23 Sep 2022 01:29:38 -0700 (PDT) MIME-Version: 1.0 References: <20220923082554.3832169-1-thomas@monjalon.net> In-Reply-To: <20220923082554.3832169-1-thomas@monjalon.net> From: David Marchand Date: Fri, 23 Sep 2022 10:29:27 +0200 Message-ID: Subject: Re: [PATCH] gpu/cuda: fix build To: Thomas Monjalon Cc: dev@dpdk.org, Elena Agostini , Bruce Richardson , Dmitry Kozlyuk X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 23, 2022 at 10:26 AM Thomas Monjalon wrot= e: > > A recent commit removed errno.h from rte_common.h. > It has to be added in various places where it is used, > and wad implicitly included via rte_common.h, was* > but was forgotten in gpu/cuda. > > As a result, the compilation is broken: > drivers/gpu/cuda/gdrcopy.c:116:17: error: =E2=80=98ENOTSUP=E2=80= =99 undeclared > > Note that rte_errno.h does not include errno.h. > The include of errno.h is added. > > Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public header"= ) > > Signed-off-by: Thomas Monjalon I installed the cuda library headers and can confirm the build issue is fix= ed. Tested-by: David Marchand --=20 David Marchand