From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBBEBA04C7; Tue, 15 Sep 2020 17:22:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B435E1C138; Tue, 15 Sep 2020 17:21:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 29AF81C0CE for ; Tue, 15 Sep 2020 17:21:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600183282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SJ5bq3uYjIgWaEHAtKVOMHDK5veLOsR3urfl/ohIr68=; b=bUyJCCO7CiBsw1XAmvPIfsAXYIEBPGf/M2H63J1Bwiw9HbjKzKqa2J4mCaU69J185D9Ibs 47LKTwmIOKgINP6ZhaTXleDxcbqC9bujuNoYQFs7zwLbY9gULnlXE+Qwd/tATs6xPViyA2 UuKNLmV8QM0CIMBJ1+HLWDz1xo890Lc= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-510-5j7qi_BHMbC7ygSaWQAJkA-1; Tue, 15 Sep 2020 10:41:25 -0400 X-MC-Unique: 5j7qi_BHMbC7ygSaWQAJkA-1 Received: by mail-vs1-f72.google.com with SMTP id a11so1290461vsd.10 for ; Tue, 15 Sep 2020 07:41:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SJ5bq3uYjIgWaEHAtKVOMHDK5veLOsR3urfl/ohIr68=; b=FlsenrCiD4i+9izQoN7pXzXtOQJH9+k4yXKM4yz2j55y857NkAjYahv48MmTJTlu+p w2+IU9uc66U91Tdy1EyfEbqSd1kcWPv37EUokjhP/tfSZlj7o36Uf08fpYf/ODHZW3HB GZ0uixRhzyKrhgkR7SeV6/xJP0Dho0JwAcBHljn5JAvgXoztIdSfq02S1bYehog/3c32 /gbrqrQfgpvDcZ/N2AjUNQMPEVYPikpUp+5yEgAMSQZBzzvFscVd16A8WVOTEZgNMnTM tfnIu8uM/U63cx4/e2qNJyMrIRTuB5EV4zdihpkfbM7hAZBPO8Q5OhQZ8LkhVeRl3tdo 50aA== X-Gm-Message-State: AOAM5309vMnQ5DAefBe4GkJlmg4eFDN2GvkVnOnZPXEEdjbk2y5/APL8 Fo7XRUv7Igjf+FCI2idEIxW9swP5T/zsPTAZYq8deN0+78VuMNCLDFCLws/0Vam7mglFCbIZU6w N8MuO3s5owkpEGF3RXmY= X-Received: by 2002:ab0:269:: with SMTP id 96mr10055926uas.41.1600180884103; Tue, 15 Sep 2020 07:41:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5BloIK/zCXx77SP4OG6jx7JRxOSiP8DJXljggOlM1TQxlFb6iZdxaN9ZN/7iV895/PwIgYLuSIlZ+1R+wZgM= X-Received: by 2002:ab0:269:: with SMTP id 96mr10055902uas.41.1600180883779; Tue, 15 Sep 2020 07:41:23 -0700 (PDT) MIME-Version: 1.0 References: <20200907081518.46350-1-ruifeng.wang@arm.com> In-Reply-To: <20200907081518.46350-1-ruifeng.wang@arm.com> From: David Marchand Date: Tue, 15 Sep 2020 16:41:12 +0200 Message-ID: To: Bruce Richardson , Vladimir Medvedkin Cc: dev , Honnappa Nagarahalli , nd , Ruifeng Wang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 0/2] LPM changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 7, 2020 at 10:15 AM Ruifeng Wang wrote: > > The rte_lpm structure is exported because lookup API is inlined. > But most of the structure can be hidden. > Discussion at: http://patches.dpdk.org/patch/72403/ > This patch set aimed to hide the rte_lpm structure as much as possible. > > A data free issue was identified and fixed. > > Ruifeng Wang (2): > lpm: fix free of data structure > lpm: hide internal data > > lib/librte_lpm/rte_lpm.c | 154 +++++++++++++++++++++++---------------- > lib/librte_lpm/rte_lpm.h | 7 -- > 2 files changed, 92 insertions(+), 69 deletions(-) Cc: maintainers. Those changes look good to me. Opinions? Thanks. -- David Marchand