From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68E64A0547; Tue, 19 Oct 2021 21:28:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FD1440142; Tue, 19 Oct 2021 21:28:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A2FA34003E for ; Tue, 19 Oct 2021 21:28:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634671707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JdiQ/Sa5wSKPOjVQrzqjpfFyaeZD4CG/esoPLzGrES8=; b=cTNNGGagga/NiYYzothRkjfjHIVTcaPjNL1fQmI2HLy3vzGJy31tHHIQjyG7Mvy59TYOsb UTwaRm3G753RB9TP6Ly0HTRwT+VfVRRrjCrnBJIfUnP5/c+8pPYtbyquDC5isldmLThRHS KxCJHnL4tN07EJ6IwNUvtq5+36HzWY0= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-66-fEBVmMNbMke5ytA1eU5j0g-1; Tue, 19 Oct 2021 15:28:16 -0400 X-MC-Unique: fEBVmMNbMke5ytA1eU5j0g-1 Received: by mail-lj1-f199.google.com with SMTP id j12-20020a2e800c000000b00210c475e1aaso1194707ljg.15 for ; Tue, 19 Oct 2021 12:28:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JdiQ/Sa5wSKPOjVQrzqjpfFyaeZD4CG/esoPLzGrES8=; b=TVlGZmhFTpiLuiZ0WamBdyzxko10iMGFz7NoAW2R7KX0G0VCe8ua47Ykxp+fRxqjFm xzQKszIKNVmYPpgxT35fyZN+wiSp4X4W/jhDCl3t1sohH1cnfQdpeWEUnv0RXGxNpKCY f0kOF6YbjZQe5NqLyXxlXEkUQ1werpGHZqPdREkfw7sNa45J9aCMtyYaLX3H7wVNaT0f su40CTgJ/ZvdCxpkE8dTz3J8UObQSmyQ/lzfhNzp/TN9pUgChVqhRSgJ8FSK5EwLLJTu XT5dkCDcBS59uOrl8j9LExUGjEJUSfoEPoK9DVUNftTcUN+5v/bR/JfK+Q2aAcKbOZAH 2WWA== X-Gm-Message-State: AOAM531G6UbzcmhM3j0iUE6ph3gujrDYOzojHIExQijEV49c0wlW48A9 tIv48oJsYZlRqBO+fDl5qvtY0XPMLzo/BPfugi1c3grlMLP5/wH7JuQESQC831lMF4LFIhdbE5z NpY0ROKB31VKSIiQG1Ys= X-Received: by 2002:a2e:8e34:: with SMTP id r20mr8917245ljk.333.1634671694783; Tue, 19 Oct 2021 12:28:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzg37BCXcpyOuhlWcFnO95IgK8omlU9I0W6TlXyQzfNi0DaRgRs0YZ5y0xDoM7tnLGf7UUOKPpvY/E/0gRJ/xA= X-Received: by 2002:a2e:8e34:: with SMTP id r20mr8917220ljk.333.1634671694559; Tue, 19 Oct 2021 12:28:14 -0700 (PDT) MIME-Version: 1.0 References: <20211018170136.5189-1-david.marchand@redhat.com> <20211019112602.17782-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 19 Oct 2021 21:28:03 +0200 Message-ID: To: Aaron Conole , Brandon Lo , Lincoln Lavoie Cc: dev , Bruce Richardson , Honnappa Nagarahalli , nd , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] test: rely on EAL detection for core list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 19, 2021 at 9:09 PM Aaron Conole wrote: > > David Marchand writes: > > > Cores count has a direct impact on the time needed to complete unit > > tests. > > > > Currently, the core list used for unit test is enforced to "all cores on > > the system" with no way for (CI) users to adapt it. > > On the other hand, EAL default behavior (when no -c/-l option gets passed) > > is to start threads on as many cores available in the process cpu > > affinity. > > > > Remove logic from meson: users can then select where to run the tests by > > either running meson with a custom cpu affinity (using taskset/cpuset > > depending on OS) or by passing a --test-args option to meson. > > > > Example: > > $ sudo meson test -C build --suite fast-tests -t 3 --test-args "-l 0-3" > > > > Signed-off-by: David Marchand > > --- > > LGTM - the spelling issue flagged seems to be a false positive. The first spelling issue is fixed in main: https://git.dpdk.org/dpdk/commit/?id=d0db11a82609 The other three warnings (all of them about "test-args") are introduced by this patch, and this is a problem: once merged, I understand any following patch will get flagged as failing this check. There may be something better to do for the mid/long term, but the quicker is to add test-args to UNH dictionnary. Once done, I can merge this patch. Lincoln, Brandon? > > Acked-by: Aaron Conole > Thanks for the review. -- David Marchand