From: David Marchand <david.marchand@redhat.com>
To: Timothy Redaelli <tredaelli@redhat.com>
Cc: dev <dev@dpdk.org>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] app/test-pipeline: fix building with GCC 10
Date: Wed, 5 Feb 2020 14:26:35 +0100 [thread overview]
Message-ID: <CAJFAV8yN2ymdLQL5W1aL2mKHHWfFcoiobGYZYPU5FcXaEsLpHQ@mail.gmail.com> (raw)
In-Reply-To: <f1efc1effdca7f37ba21bdccbe5d711987a64635.1580906522.git.tredaelli@redhat.com>
On Wed, Feb 5, 2020 at 1:51 PM Timothy Redaelli <tredaelli@redhat.com> wrote:
>
> GCC 10 defaults to -fno-common, this means a linker error will now be
> reported if the same global variable is defined in more than one
> compilation unit.
>
> Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark")
> Cc: cristian.dumitrescu@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> app/test-pipeline/config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c
> index 28ac9fcc0..42c6ed9b2 100644
> --- a/app/test-pipeline/config.c
> +++ b/app/test-pipeline/config.c
> @@ -42,7 +42,7 @@
>
> #include "main.h"
>
> -struct app_params app;
> +extern struct app_params app;
app is already declared as extern in main.h.
--
David Marchand
next prev parent reply other threads:[~2020-02-05 13:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 12:50 [dpdk-dev] [PATCH 0/3] " Timothy Redaelli
2020-02-05 12:50 ` [dpdk-dev] [PATCH 1/3] crypto/octeontx2: " Timothy Redaelli
2020-02-05 12:59 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-02-05 12:50 ` [dpdk-dev] [PATCH 2/3] app/test: " Timothy Redaelli
2020-02-05 13:41 ` Medvedkin, Vladimir
2020-02-05 12:50 ` [dpdk-dev] [PATCH 3/3] app/test-pipeline: " Timothy Redaelli
2020-02-05 13:26 ` David Marchand [this message]
2020-03-04 10:09 ` [dpdk-dev] [PATCH 0/3] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yN2ymdLQL5W1aL2mKHHWfFcoiobGYZYPU5FcXaEsLpHQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).