From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B33A6A04FA; Wed, 5 Feb 2020 14:26:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B108B1C1AF; Wed, 5 Feb 2020 14:26:52 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id ABB031C199 for ; Wed, 5 Feb 2020 14:26:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580909209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dgz5R5AJURl7F6O1Sfh0FaGHFeXQcvTs0MftVNWVzg0=; b=TVbOg/6xDnYblIlzTMG352chXTrehKDpAm1z4bIk76DJgVcOhK7Y4aI3lr35jTIJoaxyQF 5i7RZ30KcuSPpTfUc1N614+PH6qcPmQgqLd+qixHeZjHWFK8WrZVDc4OPwGW4Z3Yq6uMq1 iyyHJl9rKQycffP6Qn61snmkFq/mrs4= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-265-BNw4AFbHMhC36yyJ4vKCig-1; Wed, 05 Feb 2020 08:26:48 -0500 Received: by mail-vk1-f198.google.com with SMTP id t126so617366vkg.6 for ; Wed, 05 Feb 2020 05:26:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gkKSHUf9bTwzcjw+eSRcSyqtVQj+C8HUvhNbLYeRm48=; b=QNi13M3DstO1aFzZLnL0Kr3SU2hzHu9SzgpyW9M+AdGTgkhpQG4okd/qlr+BmjvjiQ /xdw8U2kmNcWjCaon67tgtuxW4kI5cBeU7UXgjE1mVrw8NS0avg3drQI6U4G3+UiifXH sxhk5Yi9UZH+3QX/TLTZKOwpN9z1kjs6BOLNUoDE/B2gyb0UPFR5PXDFeg8wPqrFe6xs MJQ/jBYJ6fgNK2iBHJrJqct8IIw/Sy5sEXKd8eNrW1FkOuaWaggnBO0b2WP2lFeHxzvs wUAbsotzxda+kMADF+q4y8262EQvJ4ZQMU6QeRO20saCMFzG7lRGlOC9z9m5hGEs5sUr hNjQ== X-Gm-Message-State: APjAAAX3eVxWLaAx0vUwfE9dwdQWMVSY8DHxzo32RLiNYMmm+a7ZoqCp R+E/OMqL3Gj/tMltsDS44Vf0b0sJNOVYcvGB7JoMCWdJEURqyvuUI9y87LwuZF0QbMc5gMij5G8 Ez9J7Ha+jr6dPPuzW4N8= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr21618934vsm.180.1580909207531; Wed, 05 Feb 2020 05:26:47 -0800 (PST) X-Google-Smtp-Source: APXvYqzX6JbCJG1MSatGa0YOlaTq3wJ6aMW2pKEtcM9vI5SiA56HYNfRCl1VbaJjwWJRR0pnSzUbTKP9/JEX2/PsrDU= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr21618925vsm.180.1580909207273; Wed, 05 Feb 2020 05:26:47 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 5 Feb 2020 14:26:35 +0100 Message-ID: To: Timothy Redaelli Cc: dev , Cristian Dumitrescu , dpdk stable X-MC-Unique: BNw4AFbHMhC36yyJ4vKCig-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] app/test-pipeline: fix building with GCC 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 5, 2020 at 1:51 PM Timothy Redaelli wrot= e: > > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. > > Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") > Cc: cristian.dumitrescu@intel.com > Cc: stable@dpdk.org > Signed-off-by: Timothy Redaelli > --- > app/test-pipeline/config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c > index 28ac9fcc0..42c6ed9b2 100644 > --- a/app/test-pipeline/config.c > +++ b/app/test-pipeline/config.c > @@ -42,7 +42,7 @@ > > #include "main.h" > > -struct app_params app; > +extern struct app_params app; app is already declared as extern in main.h. -- David Marchand