DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] build: fix windows build failure for 19.11
@ 2019-11-23  2:59 Pallavi Kadam
  2019-11-25  9:59 ` Bruce Richardson
  2019-11-25 13:05 ` Burakov, Anatoly
  0 siblings, 2 replies; 5+ messages in thread
From: Pallavi Kadam @ 2019-11-23  2:59 UTC (permalink / raw)
  To: dev, thomas; +Cc: bruce.richardson, ranjit.menon, pallavi.kadam

This patch fixes Windows build failure caused due to
'config: change ABI versioning to global' patch.
This patch can be merged in 19.11 release.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
---
 config/meson.build | 2 +-
 meson.build        | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/config/meson.build b/config/meson.build
index 3ffb73ab9..364a8d739 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -19,7 +19,7 @@ endforeach
 pver = meson.project_version().split('.')
 major_version = '@0@.@1@'.format(pver.get(0), pver.get(1))
 abi_version = run_command(find_program('cat', 'more'),
-	files('../ABI_VERSION')).stdout().strip()
+	abi_version_file).stdout().strip()
 # experimental libraries are versioned as 0.majorminor versions, e.g. 0.201
 ever = abi_version.split('.')
 experimental_abi_version = '0.@0@@1@'.format(ever.get(0), ever.get(1))
diff --git a/meson.build b/meson.build
index c5a3dda26..b7ae9c8d9 100644
--- a/meson.build
+++ b/meson.build
@@ -22,6 +22,7 @@ dpdk_extra_ldflags = []
 dpdk_app_link_libraries = []
 dpdk_libs_disabled = []
 dpdk_drvs_disabled = []
+abi_version_file = files('ABI_VERSION')
 
 # configure the build, and make sure configs here and in config folder are
 # able to be included in any file. We also store a global array of include dirs
-- 
2.18.0.windows.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] build: fix windows build failure for 19.11
  2019-11-23  2:59 [dpdk-dev] [PATCH] build: fix windows build failure for 19.11 Pallavi Kadam
@ 2019-11-25  9:59 ` Bruce Richardson
  2019-11-25 13:05 ` Burakov, Anatoly
  1 sibling, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2019-11-25  9:59 UTC (permalink / raw)
  To: Pallavi Kadam; +Cc: dev, thomas, ranjit.menon

On Fri, Nov 22, 2019 at 06:59:59PM -0800, Pallavi Kadam wrote:
> This patch fixes Windows build failure caused due to
> 'config: change ABI versioning to global' patch.

Underlying reason is:
"While most windows apps can handle both "\" and "/" as path separators,
"more" is treating the "/" as the start of a command-line flag in this
case, causing errors.

> This patch can be merged in 19.11 release.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
> ---



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] build: fix windows build failure for 19.11
  2019-11-23  2:59 [dpdk-dev] [PATCH] build: fix windows build failure for 19.11 Pallavi Kadam
  2019-11-25  9:59 ` Bruce Richardson
@ 2019-11-25 13:05 ` Burakov, Anatoly
  2019-11-25 13:58   ` David Marchand
  1 sibling, 1 reply; 5+ messages in thread
From: Burakov, Anatoly @ 2019-11-25 13:05 UTC (permalink / raw)
  To: Pallavi Kadam, dev, thomas; +Cc: bruce.richardson, ranjit.menon

On 23-Nov-19 2:59 AM, Pallavi Kadam wrote:
> This patch fixes Windows build failure caused due to
> 'config: change ABI versioning to global' patch.
> This patch can be merged in 19.11 release.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
> ---

Missing Fixes: tag

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] build: fix windows build failure for 19.11
  2019-11-25 13:05 ` Burakov, Anatoly
@ 2019-11-25 13:58   ` David Marchand
  2019-11-25 14:16     ` David Marchand
  0 siblings, 1 reply; 5+ messages in thread
From: David Marchand @ 2019-11-25 13:58 UTC (permalink / raw)
  To: Burakov, Anatoly, Bruce Richardson, Pallavi Kadam
  Cc: dev, Thomas Monjalon, ranjit.menon

On Mon, Nov 25, 2019 at 2:06 PM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
>
> On 23-Nov-19 2:59 AM, Pallavi Kadam wrote:
> > This patch fixes Windows build failure caused due to
> > 'config: change ABI versioning to global' patch.
> > This patch can be merged in 19.11 release.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> > Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
> > ---
>
> Missing Fixes: tag
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Who is the author of this patch?
If Pallavi authored it, we are missing a sob.

Can you just clarify this?
Then I can fix the commitlog and apply this patch.



-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] build: fix windows build failure for 19.11
  2019-11-25 13:58   ` David Marchand
@ 2019-11-25 14:16     ` David Marchand
  0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2019-11-25 14:16 UTC (permalink / raw)
  To: Pallavi Kadam
  Cc: dev, Thomas Monjalon, ranjit.menon, Bruce Richardson, Burakov, Anatoly

Confirmed author with Bruce offlist.

Applied with commitlog proposed by Bruce:

While most windows apps can handle both "\" and "/" as path separators,
"more" is treating the "/" as the start of a command-line flag in this
case, causing errors.

Fixes: cba806e07d6f ("build: change ABI versioning to global")

> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> > > Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
> > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Thanks.


--
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-23  2:59 [dpdk-dev] [PATCH] build: fix windows build failure for 19.11 Pallavi Kadam
2019-11-25  9:59 ` Bruce Richardson
2019-11-25 13:05 ` Burakov, Anatoly
2019-11-25 13:58   ` David Marchand
2019-11-25 14:16     ` David Marchand

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox