From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC02BA0527; Mon, 9 Nov 2020 13:40:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B2195AB2; Mon, 9 Nov 2020 13:40:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 6DE5D5953 for ; Mon, 9 Nov 2020 13:40:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604925634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EmHzXBVlqqH9JToSXpYndNU4q1VpcLUE4PyReYWSgsg=; b=g01RKxwp0XEjIPLHv7XUJ4QEt0z1Qa/DgOcxInqw2UU518+GjszVNAJ9gOZiOM3KPZ6jQ7 l0cUc4M97//jyt9MfVa2aJwnB289sPvlyFu3Tuihd9It6/oqktSpLI8YcVQnYxPrsto47N wCmK82cqNFAH+xJLUCuPnYFYB57G+sY= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-kb3kiT6tPzCdl-FCRHoFfw-1; Mon, 09 Nov 2020 07:40:31 -0500 X-MC-Unique: kb3kiT6tPzCdl-FCRHoFfw-1 Received: by mail-vk1-f199.google.com with SMTP id y16so1150776vke.0 for ; Mon, 09 Nov 2020 04:40:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EmHzXBVlqqH9JToSXpYndNU4q1VpcLUE4PyReYWSgsg=; b=PYswH+AntlQLAO8hNIm5fM8wZReo7mWJrPVe3A0nNSKmfiVbajKAuf1b3QSBlWyvkI k+bn2tJFHkW+SOPc92pGsbfebCsRnGc8elBJJXjxKv+/Su0PkWBUZS1dRKniNqw7ZAZI Tgno12J662wleJwLwwgRthC/VJjXWSSvaG4OG//jk6UaQ+eNWKPjeQY5SBhrWqmt9Jn7 +nepGVH2/EauME/b03Au5YEvg89kbJfs2YqrTNrSPjtZodayu8cgzFI4BN/4i/jisRE6 aqsm/fjyPTnK0XIU9/wTGdk8bxvpKDnB9wKo3Snuz8bp4Gs8mLBWSlfL7t0T+WALyHWU 2SBA== X-Gm-Message-State: AOAM533j3WuLT2OEh6jdfHHoOtAoFY0aCHJQ4cgoIu3t0hCGQFEnDwf+ /yfMYV1kyfdjOJrarO8WmTQ/MevdFUyI2lw+BIV0zEihXF5JcijngMKd8jiQFY0ZJwJOjBoxCsr Q6HFQkDs01l1Cu9F1sGg= X-Received: by 2002:a9f:21f4:: with SMTP id 107mr6329464uac.53.1604925630839; Mon, 09 Nov 2020 04:40:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJyPGhJ/43isLR5PG3F7XOG+9LAp6L7qV81SOizJGe6HQIRBnyZGTHhrx62QxblZIEm0cZsb+YerEPnRFcDFE2U= X-Received: by 2002:a9f:21f4:: with SMTP id 107mr6329448uac.53.1604925630574; Mon, 09 Nov 2020 04:40:30 -0800 (PST) MIME-Version: 1.0 References: <20200910064351.35513-1-Cheng1.jiang@intel.com> <20201022085909.112403-1-Cheng1.jiang@intel.com> <893690b2-0605-1445-fc31-3186a2ab21d7@redhat.com> In-Reply-To: <893690b2-0605-1445-fc31-3186a2ab21d7@redhat.com> From: David Marchand Date: Mon, 9 Nov 2020 13:40:19 +0100 Message-ID: To: Maxime Coquelin , Cheng Jiang Cc: "Xia, Chenbo" , dev , patrick.fu@intel.com, YvonneX.Yang@intel.com, Thomas Monjalon , "Yigit, Ferruh" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 23, 2020 at 1:23 PM Maxime Coquelin wrote: > On 10/22/20 10:59 AM, Cheng Jiang wrote: > > This patch set makes vhost-vswitch be able to use vhost async APIs > > for enqueue operations. Demonstrated how the application > > leverage IOAT DMA channel with vhost async APIs. > > > > We introduce two parameters to enable DMA acceleration for Tx > > operations of queues: > > -dma_type This parameter is used to specify DMA type for async > > vhost-user net driver. > > -dmas This parameter is used to specify the assigned DMA device of a > > vhost device and enable async vhost data path. > > > > > > Cheng Jiang (4): > > example/vhost: add async vhost args parsing function > > example/vhost: add support for vhost async data path - This series breaks external compilation, as the external Makefile was not updated. /usr/bin/ld: /tmp/cce4w26j.o: in function `new_device': main.c:(.text+0x173): undefined reference to `ioat_transfer_data_cb' /usr/bin/ld: main.c:(.text+0x178): undefined reference to `ioat_check_completed_copies_cb' /usr/bin/ld: /tmp/cce4w26j.o: in function `main': main.c:(.text.startup+0x25e): undefined reference to `open_ioat' collect2: error: ld returned 1 exit status - This series imposes a dependency on the raw/ioat driver for no reason. $ meson configure build -Ddisable_drivers=raw/ioat $ ninja-build -C build -j4 ... examples/meson.build:91:4: ERROR: Problem encountered: Missing dependency "raw_ioat" for example "vhost" The check for the architecture == x86 is wrong. The example must check for RTE_RAW_IOAT presence. Please provide fixes before rc4 or I will revert this series. Thanks. -- David Marchand