* [PATCH] cryptodev: convert to dynamic logtype
@ 2023-12-11 20:17 Stephen Hemminger
2023-12-12 7:50 ` David Marchand
2023-12-12 13:01 ` David Marchand
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2023-12-11 20:17 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Akhil Goyal, Fan Zhang
The cryptodev logs are all referenced via rte_crytpodev.h
so make it dynamic there.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/cryptodev/rte_cryptodev.c | 2 ++
lib/cryptodev/rte_cryptodev.h | 2 ++
lib/cryptodev/version.map | 1 +
lib/log/log.c | 1 -
lib/log/rte_log.h | 2 +-
5 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index b25882773421..25e3ec12d1df 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -49,6 +49,8 @@ struct rte_crypto_fp_ops rte_crypto_fp_ops[RTE_CRYPTO_MAX_DEVS];
/* spinlock for crypto device callbacks */
static rte_spinlock_t rte_cryptodev_cb_lock = RTE_SPINLOCK_INITIALIZER;
+RTE_LOG_REGISTER_DEFAULT(rte_cryptodev_logtype, INFO);
+
/**
* The user application callback description.
*
diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h
index aaeaf294e6bb..82b711395a5b 100644
--- a/lib/cryptodev/rte_cryptodev.h
+++ b/lib/cryptodev/rte_cryptodev.h
@@ -29,6 +29,8 @@ extern "C" {
extern const char **rte_cyptodev_names;
/* Logging Macros */
+extern int rte_cryptodev_logtype;
+#define RTE_LOGTYPE_CRYPTODEV rte_cryptodev_logtype
#define CDEV_LOG_ERR(...) \
RTE_LOG(ERR, CRYPTODEV, \
diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map
index c39199be54f5..54360a5da538 100644
--- a/lib/cryptodev/version.map
+++ b/lib/cryptodev/version.map
@@ -44,6 +44,7 @@ DPDK_24 {
rte_cryptodev_get_sec_ctx;
rte_cryptodev_info_get;
rte_cryptodev_is_valid_dev;
+ rte_cryptodev_logtype;
rte_cryptodev_name_get;
rte_cryptodev_queue_pair_count;
rte_cryptodev_queue_pair_setup;
diff --git a/lib/log/log.c b/lib/log/log.c
index e3cd4cff0fbc..ab06132a98a1 100644
--- a/lib/log/log.c
+++ b/lib/log/log.c
@@ -356,7 +356,6 @@ static const struct logtype logtype_strings[] = {
{RTE_LOGTYPE_PORT, "lib.port"},
{RTE_LOGTYPE_TABLE, "lib.table"},
{RTE_LOGTYPE_PIPELINE, "lib.pipeline"},
- {RTE_LOGTYPE_CRYPTODEV, "lib.cryptodev"},
{RTE_LOGTYPE_EVENTDEV, "lib.eventdev"},
{RTE_LOGTYPE_USER1, "user1"},
{RTE_LOGTYPE_USER2, "user2"},
diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h
index 27fb6129a7aa..2d5eb23eeedf 100644
--- a/lib/log/rte_log.h
+++ b/lib/log/rte_log.h
@@ -43,7 +43,7 @@ extern "C" {
#define RTE_LOGTYPE_TABLE 14 /**< Log related to table. */
#define RTE_LOGTYPE_PIPELINE 15 /**< Log related to pipeline. */
/* was RTE_LOGTYPE_MBUF */
-#define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
+ /* was RTE_LOGTYPE_CRYPTODEV */
/* was RTE_LOGTYPE_EFD */
#define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */
/* was RTE_LOGTYPE_GSO */
--
2.42.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cryptodev: convert to dynamic logtype
2023-12-11 20:17 [PATCH] cryptodev: convert to dynamic logtype Stephen Hemminger
@ 2023-12-12 7:50 ` David Marchand
2023-12-12 8:14 ` [EXT] " Akhil Goyal
2023-12-12 13:01 ` David Marchand
1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2023-12-12 7:50 UTC (permalink / raw)
To: Stephen Hemminger, Akhil Goyal; +Cc: dev, Fan Zhang
On Mon, Dec 11, 2023 at 9:18 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The cryptodev logs are all referenced via rte_crytpodev.h
crypto*
> so make it dynamic there.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
I would add a comment in the header that this exported logtype
variable is for internal use.
Otherwise it lgtm.
Akhil, do you mind if I take this directly in main?
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: [PATCH] cryptodev: convert to dynamic logtype
2023-12-12 7:50 ` David Marchand
@ 2023-12-12 8:14 ` Akhil Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2023-12-12 8:14 UTC (permalink / raw)
To: David Marchand, Stephen Hemminger; +Cc: dev, Fan Zhang
> On Mon, Dec 11, 2023 at 9:18 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The cryptodev logs are all referenced via rte_crytpodev.h
>
> crypto*
>
> > so make it dynamic there.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> I would add a comment in the header that this exported logtype
> variable is for internal use.
> Otherwise it lgtm.
>
> Akhil, do you mind if I take this directly in main?
No issues, you can take it directly in main.
Acked-by: Akhil Goyal <gakhil@marvell.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cryptodev: convert to dynamic logtype
2023-12-11 20:17 [PATCH] cryptodev: convert to dynamic logtype Stephen Hemminger
2023-12-12 7:50 ` David Marchand
@ 2023-12-12 13:01 ` David Marchand
1 sibling, 0 replies; 4+ messages in thread
From: David Marchand @ 2023-12-12 13:01 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Akhil Goyal, Fan Zhang
On Mon, Dec 11, 2023 at 9:18 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The cryptodev logs are all referenced via rte_crytpodev.h
> so make it dynamic there.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-12 13:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-11 20:17 [PATCH] cryptodev: convert to dynamic logtype Stephen Hemminger
2023-12-12 7:50 ` David Marchand
2023-12-12 8:14 ` [EXT] " Akhil Goyal
2023-12-12 13:01 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).