From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D41C8A0524; Fri, 27 Nov 2020 10:45:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 447A4C92A; Fri, 27 Nov 2020 10:45:37 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id BDC9EC90E for ; Fri, 27 Nov 2020 10:45:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606470334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y3L3SHXqmcRz1JclkFVtzvsyEtuR6FGENnYCE/x2/TI=; b=GaOOfPj3bFxr+ieR+dPZDvSXlFHITw43Toh/zN0IQauOygQQxv5J7ZvHEOD7XFdsj4XQoL XTcdrdDGC+rHqI8KkMGfHRJtvTcPAWn2PHZwuYyPsrXaKKIilHLMrW2bpYirg3/EqTTOkF SBEeGck6gWr9+miREXJdgwLlJ/bxMXw= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-WM2jf1g6PCGZaonyMH149Q-1; Fri, 27 Nov 2020 04:45:31 -0500 X-MC-Unique: WM2jf1g6PCGZaonyMH149Q-1 Received: by mail-vk1-f199.google.com with SMTP id e202so1542818vke.7 for ; Fri, 27 Nov 2020 01:45:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Y3L3SHXqmcRz1JclkFVtzvsyEtuR6FGENnYCE/x2/TI=; b=U0/l+ZFp1hpsZh6zdFxvCfPSP5/IXN8OcyHx+JuvOYqLUF/st4QE5SMS8cceo7TyE3 xB7TijCngK9N2DSBDraJwJe+kxgA55JL5xPX4d3dTsF5M8RwaNt8MfuM6PXp25S5kNU5 DKz8aslCUei0R34ehmIXmhsbstrXx1j0M773hZt2h5zQzJw0QiWGICsSV7PcR8CYRc38 MwZqH3/EBziqauf9Zx949CQzVNpxsXMyw6lgo1rHE6jR8I9YNSmIHbhA3QGcCPlLS6F4 VNj171e7WvxuprcYQti4ol4c1qR9O03CLsDiJ4NRAS0PjOP1wkWn5SaKTOiIggKMPvky ImGQ== X-Gm-Message-State: AOAM531YM9nxUs1PSZJB0LSHIqKQV4cWwuxkXbqdCF+RnUSrb0dzO612 CBP5B20BYS/xDq5oOjtHYP5iK0iPuoz3KpGggys1himSWmOcFK4bNFwl3RsqC96YDslRDRKsegB Uu044hejnNgU6XEzvt7k= X-Received: by 2002:a1f:4e81:: with SMTP id c123mr4431140vkb.20.1606470331001; Fri, 27 Nov 2020 01:45:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxuBy2pjkdc4Yf79vV0UxLN82jLgMv8HbjYi8sI3vUJ7XfZDUDieL8Xwxxdc8ObfAkcbdWtekTSsUymJuTLHwo= X-Received: by 2002:a1f:4e81:: with SMTP id c123mr4431130vkb.20.1606470330744; Fri, 27 Nov 2020 01:45:30 -0800 (PST) MIME-Version: 1.0 References: <20201127080903.26817-1-ruifeng.wang@arm.com> <20201127080903.26817-2-ruifeng.wang@arm.com> In-Reply-To: From: David Marchand Date: Fri, 27 Nov 2020 10:45:19 +0100 Message-ID: To: Jerin Jacob Cc: Ruifeng Wang , Andrew Rybchenko , Jerin Jacob , Honnappa Nagarahalli , dev , nd , Feifei Wang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 27, 2020 at 10:34 AM Jerin Jacob wrote: > > On Fri, Nov 27, 2020 at 2:56 PM David Marchand > wrote: > > > > On Fri, Nov 27, 2020 at 9:51 AM Jerin Jacob wro= te: > > > > > > On Fri, Nov 27, 2020 at 2:09 PM David Marchand > > > wrote: > > > > > > > > On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang = wrote: > > > > > > > > > > Gcc build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS se= t > > > > > failed for: > > > > > ../lib/librte_efd/rte_efd.c > > > > > Assembler messages: > > > > > 3866: Error: selected processor does not support `crc32cb w0,w0,w= 1' > > > > > 3890: Error: selected processor does not support `crc32ch w0,w0,w= 1' > > > > > 3914: Error: selected processor does not support `crc32cw w0,w0,w= 1' > > > > > 3938: Error: selected processor does not support `crc32cx w0,w0,x= 1' > > > > > > > > > > This was caused by an architecture specifier added for Clang. > > > > > Unlike Clang, Gcc considers each inline assembly block to be depe= ndent > > > > > and therefor, the architecture specifier impacts assemble of some > > > > > blocks require certain extension support. > > > > > > > > I reproduced this error with -O0 for config/arm/arm64_octeontx2_lin= ux_gcc. > > > > The patch looks simple enough and it only affects ARM builds. > > > > > > > > Jerin, > > > > Are you okay with this change for 20.11? > > > > Or should we wait 21.02? > > > > > > I could reproduce the issue with meson build -Dbuildtype=3Ddebug > > > --cross-file config/arm/arm64_octeontx2_linux_gcc > > > > > > This fix is OK. Request to merge for 20.11 > > > > > > Acked-by: Jerin Jacob > > > > Ruifeng, Andrew, > > > > I get a compilation error with this patch on sfc using gcc and > > config/arm/arm64_octeontx2_linux_gcc config + --buildtype=3Ddebug and/o= r > > -Dc_args=3D-O0 . > > > > aarch64-linux-gnu-gcc (GNU Toolchain for the A-profile Architecture > > 8.2-2019.01 (arm-rel-8.28)) 8.2.1 20180802 > > > > FAILED: drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o > > aarch64-linux-gnu-gcc > > -Idrivers/common/sfc_efx/base/932d09a@@sfc_base@sta > > -Idrivers/common/sfc_efx/base -I../../dpdk/drivers/common/sfc_efx/base > > -Idrivers/common/sfc_efx -I../../dpdk/drivers/common/sfc_efx -I. > > -I../../dpdk/ -Iconfig -I../../dpdk/config -Ilib/librte_eal/include > > -I../../dpdk/lib/librte_eal/include -Ilib/librte_eal/linux/include > > -I../../dpdk/lib/librte_eal/linux/include -Ilib/librte_eal/arm/include > > -I../../dpdk/lib/librte_eal/arm/include -Ilib/librte_eal/common > > -I../../dpdk/lib/librte_eal/common -Ilib/librte_eal > > -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs > > -I../../dpdk/lib/librte_kvargs > > -Ilib/librte_telemetry/../librte_metrics > > -I../../dpdk/lib/librte_telemetry/../librte_metrics > > -Ilib/librte_telemetry -I../../dpdk/lib/librte_telemetry > > -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall > > -Winvalid-pch -Werror -g -include rte_config.h -Wextra -Wcast-qual > > -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security > > -Wmissing-declarations -Wmissing-prototypes -Wnested-externs > > -Wold-style-definition -Wpointer-arith -Wsign-compare > > -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned > > -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC > > -march=3Darmv8.2-a+crc+crypto+lse -DALLOW_EXPERIMENTAL_API > > -DALLOW_INTERNAL_API -Wno-format-truncation -Wdisabled-optimization > > -Waggregate-return -Wbad-function-cast -Wno-sign-compare > > -Wno-unused-parameter -Wno-unused-variable -Wno-empty-body > > -Wno-unused-but-set-variable -MD -MQ > > 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o' -MF > > 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o.d' -o > > 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o' -c > > ../../dpdk/drivers/common/sfc_efx/base/efx_crc32.c > > In file included from ../../dpdk/lib/librte_eal/arm/include/rte_atomic.= h:9, > > from ../../dpdk/lib/librte_eal/include/generic/rte_pau= se.h:19, > > from ../../dpdk/lib/librte_eal/arm/include/rte_pause_6= 4.h:19, > > from ../../dpdk/lib/librte_eal/arm/include/rte_pause.h= :13, > > from > > ../../dpdk/lib/librte_eal/include/generic/rte_spinlock.h:25, > > from ../../dpdk/lib/librte_eal/arm/include/rte_spinloc= k.h:17, > > from ../../dpdk/drivers/common/sfc_efx/efsys.h:15, > > from ../../dpdk/drivers/common/sfc_efx/base/efx.h:11, > > from ../../dpdk/drivers/common/sfc_efx/base/efx_crc32.= c:7: > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function > > =E2=80=98__cas_128_relaxed=E2=80=99: > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:81:20: error: > > function returns an aggregate [-Werror=3Daggregate-return] > > __ATOMIC128_CAS_OP(__cas_128_relaxed, "casp") > > ^~~~~~~~~~~~~~~~~ > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in > > definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 > > cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated)= \ > > ^~~~~~~~~~~ > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function > > =E2=80=98__cas_128_acquire=E2=80=99: > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:82:20: error: > > function returns an aggregate [-Werror=3Daggregate-return] > > __ATOMIC128_CAS_OP(__cas_128_acquire, "caspa") > > ^~~~~~~~~~~~~~~~~ > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in > > definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 > > cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated)= \ > > ^~~~~~~~~~~ > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function > > =E2=80=98__cas_128_release=E2=80=99: > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:83:20: error: > > function returns an aggregate [-Werror=3Daggregate-return] > > __ATOMIC128_CAS_OP(__cas_128_release, "caspl") > > ^~~~~~~~~~~~~~~~~ > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in > > definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 > > cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated)= \ > > ^~~~~~~~~~~ > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function > > =E2=80=98__cas_128_acq_rel=E2=80=99: > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:84:20: error: > > function returns an aggregate [-Werror=3Daggregate-return] > > __ATOMIC128_CAS_OP(__cas_128_acq_rel, "caspal") > > ^~~~~~~~~~~~~~~~~ > > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in > > definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 > > cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated)= \ > > ^~~~~~~~~~~ > > cc1: all warnings being treated as errors > > > > > > If I waive those warnings: > > - next to fail is net/igc (fixed by next patch so ok) > > - and then next to fail is net/sfc. > > Regarding the net/sfc build, Could try clean build.(I got the warning fir= st, > after the clean build, it is OK) That's what I first thought too, then I noticed that test-meson-builds.sh had switched back my build dir to debugoptimized. >From scratch: The Meson build system Version: 0.52.0 Source dir: /home/dmarchan/dpdk Build dir: /home/dmarchan/builds/build-arm64-octeontx2 Build type: cross build Program cat found: YES (/usr/bin/cat) Project name: DPDK Project version: 20.11.0-rc5 Appending CFLAGS from environment: '-Werror' C compiler for the build machine: ccache gcc (gcc 9.3.1 "gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2)") C linker for the build machine: GNU ld.bfd 2.32-33 C compiler for the host machine: aarch64-linux-gnu-gcc (gcc 8.2.1 "aarch64-linux-gnu-gcc (GNU Toolchain for the A-profile Architecture 8.2-2019.01 (arm-rel-8.28)) 8.2.1 20180802") C linker for the host machine: GNU ld.bfd 8.2-2019 Build machine cpu family: x86_64 Build machine cpu: x86_64 Host machine cpu family: aarch64 Host machine cpu: armv8-a Target machine cpu family: aarch64 Target machine cpu: armv8-a ... Option buildtype is: debug [default: release] Option default_library is: shared [default: static] Found ninja-1.9.0 at /usr/bin/ninja ninja: Entering directory `/home/dmarchan/builds/build-arm64-octeontx2' [479/2558] Compiling C object 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_bootcfg.c.o'. FAILED: drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_bootcfg.c.o aarch64-linux-gnu-gcc -Idrivers/common/sfc_efx/base/932d09a@@sfc_base@sta -Idrivers/common/sfc_efx/base -I../../dpdk/drivers/common/sfc_efx/base -Idrivers/common/sfc_efx -I../../dpdk/drivers/common/sfc_efx -I. -I../../dpdk/ -Iconfig -I../../dpdk/config -Ilib/librte_eal/include -I../../dpdk/lib/librte_eal/include -Ilib/librte_eal/linux/include -I../../dpdk/lib/librte_eal/linux/include -Ilib/librte_eal/arm/include -I../../dpdk/lib/librte_eal/arm/include -Ilib/librte_eal/common -I../../dpdk/lib/librte_eal/common -Ilib/librte_eal -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs -I../../dpdk/lib/librte_kvargs -Ilib/librte_telemetry/../librte_metrics -I../../dpdk/lib/librte_telemetry/../librte_metrics -Ilib/librte_telemetry -I../../dpdk/lib/librte_telemetry -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Darmv8.2-a+crc+crypto+lse -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -Wdisabled-optimization -Waggregate-return -Wbad-function-cast -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-empty-body -Wno-unused-but-set-variable -MD -MQ 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_bootcfg.c.o' -MF 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_bootcfg.c.o.d' -o 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_bootcfg.c.o' -c ../../dpdk/drivers/common/sfc_efx/base/efx_bootcfg.c In file included from ../../dpdk/lib/librte_eal/arm/include/rte_atomic.h:9, from ../../dpdk/lib/librte_eal/include/generic/rte_pause.h= :19, from ../../dpdk/lib/librte_eal/arm/include/rte_pause_64.h:= 19, from ../../dpdk/lib/librte_eal/arm/include/rte_pause.h:13, from ../../dpdk/lib/librte_eal/include/generic/rte_spinlock.h:25, from ../../dpdk/lib/librte_eal/arm/include/rte_spinlock.h:= 17, from ../../dpdk/drivers/common/sfc_efx/efsys.h:15, from ../../dpdk/drivers/common/sfc_efx/base/efx.h:11, from ../../dpdk/drivers/common/sfc_efx/base/efx_bootcfg.c:= 7: ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function =E2=80=98__cas_128_relaxed=E2=80=99: ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:81:20: error: function returns an aggregate [-Werror=3Daggregate-return] __ATOMIC128_CAS_OP(__cas_128_relaxed, "casp") ... --=20 David Marchand