Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable

[David Marchand <david.marchand@redhat.com>]

On Wed, Sep 1, 2021 at 9:35 AM Mattias Rönnblom
<mattias.ronnblom@ericsson.com> wrote:
>
> On 2021-09-01 09:29, Mattias Rönnblom wrote:
> > Remove experimental tag from rte_rand_max().
> >
> > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> > ---
> >   lib/eal/include/rte_random.h | 1 -
> >   lib/eal/version.map          | 2 +-
> >   2 files changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/lib/eal/include/rte_random.h b/lib/eal/include/rte_random.h
> > index 2b30ec85c1..29f5f1325a 100644
> > --- a/lib/eal/include/rte_random.h
> > +++ b/lib/eal/include/rte_random.h
> > @@ -62,7 +62,6 @@ rte_rand(void);
> >    * @return
> >    *   A pseudo-random value between 0 and (upper_bound-1).
> >    */
> > -__rte_experimental
> >   uint64_t
> >   rte_rand_max(uint64_t upper_bound);
> >
> > diff --git a/lib/eal/version.map b/lib/eal/version.map
> > index beeb986adc..92caaa2bd5 100644
> > --- a/lib/eal/version.map
> > +++ b/lib/eal/version.map
> > @@ -148,6 +148,7 @@ DPDK_22 {
> >       rte_memzone_walk;
> >       rte_openlog_stream;
> >       rte_rand;
> > +     rte_rand_max;
> >       rte_realloc;
> >       rte_reciprocal_value;
> >       rte_reciprocal_value_u64;
> > @@ -326,7 +327,6 @@ EXPERIMENTAL {
> >       rte_lcore_to_cpu_id;
> >       rte_mcfg_timer_lock;
> >       rte_mcfg_timer_unlock;
> > -     rte_rand_max; # WINDOWS_NO_EXPORT
>
>
> Should I have kept the WINDOWS_NO_EXPORT tag?

Strictly speaking, you should keep it: this patch is about API promotion.

The windows exports are fixed in another patch in any case:
https://patchwork.dpdk.org/project/dpdk/patch/20210829021602.290466-3-dmitry.kozliuk@gmail.com/


-- 
David Marchand