From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1472FA0C53; Wed, 1 Sep 2021 09:42:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92DB64013F; Wed, 1 Sep 2021 09:42:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 3C73240041 for ; Wed, 1 Sep 2021 09:42:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630482143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z/AxdY1WSFZ9WB8G3uRrbU5LWinmcwhd9LPQXOw3zDI=; b=E13qdI9ewZ04zWbb0Ad8N1fb2hERS4xvWSB96lnrktgBlPu1SYPeVZOJp8EZ1FB+U8GYkl dFUmDuuxIW3rghT/PhaCkWbfu6Xqgq25t8/40jv/H7iaxrOpyllwN5HEMlJL88pVc+fC67 V5BkKDNV05UoPju4KtRpj/Iv3OUOsMU= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-vFOxs8AAN_m2k7xTysKMdQ-1; Wed, 01 Sep 2021 03:42:19 -0400 X-MC-Unique: vFOxs8AAN_m2k7xTysKMdQ-1 Received: by mail-lj1-f198.google.com with SMTP id y6-20020a05651c154600b001c30dac7e87so750089ljp.8 for ; Wed, 01 Sep 2021 00:42:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=z/AxdY1WSFZ9WB8G3uRrbU5LWinmcwhd9LPQXOw3zDI=; b=rtuCWaAisSzuCXX/HkUzTaqkMFISKfASl94BVTvi1MJqD319aIn94fNdlkrOphfAop j18aBIIks+tW2Nn+yeoECvT1T258y49H/pdV2sRW57kwFMa5dJx4mcbniOn9Ka3e+dQE V6ln6N1s0sWdx/yGo5UotcFSlQruOB/apu0q7OA6bhxmrpX7tSfqdRek+1CJbYId5+mL rPtHbiv0zR8UM7EC5SV2Hke1ySea98K2h4tTC41W/9ibPH0IP5N9hrXr7VCcIvH2DD6o OnS9Otw84O9SnkuTqizsa8MQgNauH+tiepj8gw1Sukrb02/YQbeaGcHmCCNLT/lTbQ00 jF9Q== X-Gm-Message-State: AOAM531fZJnfJBuhMEzNNvR5g6z/9tNrJaDMeAsjztnvKp9nY27ib4BH 0IivqT7Ul+4G85Evc10T2SZHPwMywkbgpGA4vv298B6pbm6aVIN/7MCLaq1JggGwmocoENhQNU+ iGl4+5Fgpw7fE1FdeoSk= X-Received: by 2002:a05:6512:a84:: with SMTP id m4mr19691150lfu.574.1630482138456; Wed, 01 Sep 2021 00:42:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxADN4RkjtnLKpUprQdAHaV4GuZllSqHkuoxgCdJpVFDTtyQJvNP2bORaxuZevm0gSYnhedtD/8Q3PUptJFRsM= X-Received: by 2002:a05:6512:a84:: with SMTP id m4mr19691131lfu.574.1630482138195; Wed, 01 Sep 2021 00:42:18 -0700 (PDT) MIME-Version: 1.0 References: <20210901072912.73279-1-mattias.ronnblom@ericsson.com> <3b1e843f-f6f6-8c96-5853-855e818f5607@ericsson.com> In-Reply-To: <3b1e843f-f6f6-8c96-5853-855e818f5607@ericsson.com> From: David Marchand Date: Wed, 1 Sep 2021 09:42:07 +0200 Message-ID: To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: Ray Kinsella , "dev@dpdk.org" , Dmitry Kozlyuk Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 1, 2021 at 9:35 AM Mattias R=C3=B6nnblom wrote: > > On 2021-09-01 09:29, Mattias R=C3=B6nnblom wrote: > > Remove experimental tag from rte_rand_max(). > > > > Signed-off-by: Mattias R=C3=B6nnblom > > --- > > lib/eal/include/rte_random.h | 1 - > > lib/eal/version.map | 2 +- > > 2 files changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/lib/eal/include/rte_random.h b/lib/eal/include/rte_random.= h > > index 2b30ec85c1..29f5f1325a 100644 > > --- a/lib/eal/include/rte_random.h > > +++ b/lib/eal/include/rte_random.h > > @@ -62,7 +62,6 @@ rte_rand(void); > > * @return > > * A pseudo-random value between 0 and (upper_bound-1). > > */ > > -__rte_experimental > > uint64_t > > rte_rand_max(uint64_t upper_bound); > > > > diff --git a/lib/eal/version.map b/lib/eal/version.map > > index beeb986adc..92caaa2bd5 100644 > > --- a/lib/eal/version.map > > +++ b/lib/eal/version.map > > @@ -148,6 +148,7 @@ DPDK_22 { > > rte_memzone_walk; > > rte_openlog_stream; > > rte_rand; > > + rte_rand_max; > > rte_realloc; > > rte_reciprocal_value; > > rte_reciprocal_value_u64; > > @@ -326,7 +327,6 @@ EXPERIMENTAL { > > rte_lcore_to_cpu_id; > > rte_mcfg_timer_lock; > > rte_mcfg_timer_unlock; > > - rte_rand_max; # WINDOWS_NO_EXPORT > > > Should I have kept the WINDOWS_NO_EXPORT tag? Strictly speaking, you should keep it: this patch is about API promotion. The windows exports are fixed in another patch in any case: https://patchwork.dpdk.org/project/dpdk/patch/20210829021602.290466-3-dmitr= y.kozliuk@gmail.com/ --=20 David Marchand