From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8F6EA04AB; Fri, 8 Nov 2019 09:14:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2CD901BF8B; Fri, 8 Nov 2019 09:14:13 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 4091C1BF49 for ; Fri, 8 Nov 2019 09:14:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573200850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KA3ZknLLHfWlEopsmIH2rLY7YvvzhEsdEPI+l8LQsjg=; b=Jeza51AMXBSzrYZv/OXJGDOxbTP+c1DHK+B/kSD3Cy8S7USA3TyYcxcSG39QsRq5r7rW3U 1vsE/CrqCh/kt+x4cxOdZvt4ctwc46nqQcFqszieHHCf2JluVDdHmvLTqV9D+Bi3Umqvzv 4UNyeQ2sf9zePQJregD6R7vx6TCL7QM= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-qotRDjMVML6nmyustoGtzA-1; Fri, 08 Nov 2019 03:14:09 -0500 Received: by mail-vs1-f72.google.com with SMTP id d75so1402600vsc.11 for ; Fri, 08 Nov 2019 00:14:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=KA3ZknLLHfWlEopsmIH2rLY7YvvzhEsdEPI+l8LQsjg=; b=KKS/BXRIRvXoenPm5qy71i9BK0WK2lqdPYgyeB9tOJE5V7kKr1EqYozuwFGRiTXcd8 /w4+z929vpSFcHvSWidjvXZqYZpruUoKiPb8YgN902cq3jIFEnkor8ntdtmD5T6ssgeR v5EVOdsOdHUQSlIcIpZWv4R8PBFppeD8PEEvq4jGz4DNMtkjcB4h2WfeqFquyO+/Z8qP yrXde4Q390j0dMI/niwmzibokHkPAUmdtjxCZtHSikH0tNKzcASR6TE1d6kPEtIYO1iE i9Z4DpbmORr+TFcVc2fwbjpB9nVPqClZOfUPMpvgv6QvTua8Jck14xksVoDi36b+7A9x w6sg== X-Gm-Message-State: APjAAAXFCBxl26hZagsZWNxwjY0BE1+UXIbdGAk38TXTrmN7iPHSqUMG JG5qoAeG7uYGiGAPy2sEX/yoqEfdSiiAqdiJo9Fse2od0B4ilhrsD3+VZypbNX2OWlvTo6Jvoj8 5ukzFskvefmeFz0/x4S8= X-Received: by 2002:a05:6102:75c:: with SMTP id v28mr6843617vsg.105.1573200848554; Fri, 08 Nov 2019 00:14:08 -0800 (PST) X-Google-Smtp-Source: APXvYqy2uFXW8FcrKlcS/+pmHfsF+BmqLlkeOd9DjVy0e/Lv7wiQAU+tzn1XPZHGozLOnr9r+aO4lK826EUw/ZH4h7A= X-Received: by 2002:a05:6102:75c:: with SMTP id v28mr6843582vsg.105.1573200848117; Fri, 08 Nov 2019 00:14:08 -0800 (PST) MIME-Version: 1.0 References: <20191108043818.27610-1-stephen@networkplumber.org> <20191108043818.27610-3-stephen@networkplumber.org> In-Reply-To: <20191108043818.27610-3-stephen@networkplumber.org> From: David Marchand Date: Fri, 8 Nov 2019 09:13:56 +0100 Message-ID: To: Stephen Hemminger Cc: dev X-MC-Unique: qotRDjMVML6nmyustoGtzA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 2/2] pdump: use dynamic logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 8, 2019 at 5:39 AM Stephen Hemminger wrote: > > The logtype USER1 should not be overloaded for library function. > Instead use a dynamic log type. > > Signed-off-by: Stephen Hemminger This patch is incomplete. $ git grep -w RTE_LOG lib/librte_pdump/ lib/librte_pdump/rte_pdump.c:/* Macro for printing using RTE_LOG */ lib/librte_pdump/rte_pdump.c: RTE_LOG(ERR, PDUMP, =3D=3D Build lib/librte_pdump CC rte_pdump.o In file included from /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/x86_64-native-linuxapp-gcc/include/rte_bus.h:24:0, from /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/x86_64-native-linuxapp-gcc/include/rte_eal.h:21, from /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/x86_64-native-linuxapp-gcc/include/rte_lcore.h:16, from /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/x86_64-native-linuxapp-gcc/include/generic/rte_spinlock.h:21, from /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:12, from /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/x86_64-native-linuxapp-gcc/include/rte_mempool.h:44, from /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:38, from /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/lib/librte_pdump/rte_pdump.c:6: /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/lib/librte_pdump/rte_pdump.c: In function =E2=80=98set_pdump_rxtx_cbs=E2=80=99: /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/x86_64-native-linuxapp-gcc/include/rte_log.h:337:4: error: =E2=80=98RTE_LOGTYPE_PDUMP=E2=80=99 undeclared (first use in this fu= nction); did you mean =E2=80=98RTE_LOGTYPE_PMD=E2=80=99? RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__) ^ /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/lib/librte_pdump/rte_pdump.c:275:4: note: in expansion of macro =E2=80=98RTE_LOG=E2=80=99 RTE_LOG(ERR, PDUMP, ^~~~~~~ /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/x86_64-native-linuxapp-gcc/include/rte_log.h:337:4: note: each undeclared identifier is reported only once for each function it appears in RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__) ^ /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/lib/librte_pdump/rte_pdump.c:275:4: note: in expansion of macro =E2=80=98RTE_LOG=E2=80=99 RTE_LOG(ERR, PDUMP, ^~~~~~~ /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dp= dk/lib/librte_pdump/rte_pdump.c: At top level: --=20 David Marchand