From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4086C43081; Wed, 16 Aug 2023 16:40:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 263BC40693; Wed, 16 Aug 2023 16:40:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AA5984003C for ; Wed, 16 Aug 2023 16:40:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692196839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tpx5PwpnUuEBLK/Bsv7Z+1/JNHo2O7p2xkQoJ+XxET8=; b=Y3zZ71UrhHbOdM2tVFfvJt7kp7zE1zCqC6wsqVEs2qFdy0L8ONdi7+qvBReo0ekzyuuT+j udbCdgkLHt9j95X3cq6hkzAr6Vj7EQtxK4SArphYbid8fV+lrDCTc1DgD83a586/a3kZbj 14Vr4v0SfNosvubOhrChpuVD9hW8UZA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-wJw7UToFN1aDmZAqTIpY9g-1; Wed, 16 Aug 2023 10:40:35 -0400 X-MC-Unique: wJw7UToFN1aDmZAqTIpY9g-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4ff908143acso815870e87.0 for ; Wed, 16 Aug 2023 07:40:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692196834; x=1692801634; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tpx5PwpnUuEBLK/Bsv7Z+1/JNHo2O7p2xkQoJ+XxET8=; b=g3X3n40MYaQGaqZB0VeWMJLu67lj/P2YjFvD8JCvLV4qaCz6z6EkP9Mk1a5ZxAaoTH dK5uhNJ5hGLmzowguW4sd63Mq33pa93Zmd+5ztYNIKRD/m/uP4N4wlz79sZ8W/OPYok9 dXj+DI6x2ccWU3i9urJRku0r+JpPmyhbZu3QYAl+uVvolTKvvSWMvG+try4En9UODTb+ KEFqvuGwfPxTKVF4sJSA09jhjrqDBokJqucwtHmmPifnb8Jc4gyHjfHEcmJdGN3yr3PG bwYhrYr8x7ktEe0yOA7AOtPpdXPuE3E5HDhUIUS48U2vbFJM5vYjRpG7xwtEZCoFb1Ib ULig== X-Gm-Message-State: AOJu0Yw3YQfeZ1+N+gOmKRQNXbmLD1Fye7OCPCMCB4fIbDduSFLUeF5u 3Awgou4kS71q2DKwZ5scvPpd2NnT1QYbnHpmusd2oiAAlhJj2SjS3wQa2S9m33TVTyldk5XlBFL jV8RCetSh21l6hHMHi1I= X-Received: by 2002:ac2:5b05:0:b0:4fd:c715:5667 with SMTP id v5-20020ac25b05000000b004fdc7155667mr1484661lfn.20.1692196833827; Wed, 16 Aug 2023 07:40:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8fPmuaR6Wd+6DeXTkAZ6XNW8fqY3d4DkiHOWlKy/HGfGnL3dN/ODw+xwax3V2dHfjUZNfTR9ekZwpbcD6D0k= X-Received: by 2002:ac2:5b05:0:b0:4fd:c715:5667 with SMTP id v5-20020ac25b05000000b004fdc7155667mr1484642lfn.20.1692196833499; Wed, 16 Aug 2023 07:40:33 -0700 (PDT) MIME-Version: 1.0 References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-5-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Wed, 16 Aug 2023 16:40:21 +0200 Message-ID: Subject: Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix To: Bruce Richardson , Patrick Robb Cc: dev@dpdk.org, ci@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , Thomas Monjalon , Aaron Conole X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Patrick, Bruce, On Wed, Aug 16, 2023 at 2:57=E2=80=AFPM Bruce Richardson wrote: > > On Tue, Aug 15, 2023 at 03:05:08PM -0400, Patrick Robb wrote: > > Adam from our team just raised something important about this patch = and > > UNH CI which I missed during the RFC discussion. > > Presently, eal_flags_file_prefix_autotest fails on arm tx2 systems (= arm > > people are aware of this, they think it might be a memory leak from That's sad to read. > > mlx5 driver), so at their request we are disabling this unit test (o= n > > arm only) for them for the time being. If it was reported, I either missed it or forgot about it, sorry. Can you (re)share the context? There was a couple of mem leak fixes for mlx5 in v23.07. It may be worth running this test again and providing fresh traces. > > Does the test suite pass if the mlx5 driver is disabled in the build? Tha= t > could confirm or refute the suspicion of where the issue is, and also > provide a temporary workaround while this set is merged (possibly includi= ng > support for disabling specific tests, as I suggested in my other email). Or disabling the driver as Bruce proposes. > > /Bruce > > PS: Are there any other workarounds inside the test/DTS/CI systems that > involve patching sources? If so, it would be good to get a list that we c= an > work through removing by putting place proper fixes or workarounds, as > changing sources for testing like this blocks future patch acceptance. Patching sources from the test tool is a poor solution. In general, developers won't be aware of source patching and will waste time trying to understand why they can't reproduce what the CI reports (it happened to me with DTS on the interrupt stuff with vhost, at least). For this specific case of skipping a test, if nobody can fix the issue, I prefer if the CI can skip some "known broken in my lab" tests via some meson configuration. And, such configuration should be easy to catch in the test report. --=20 David Marchand