From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC2F443BD1; Fri, 1 Mar 2024 13:43:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98F2843444; Fri, 1 Mar 2024 13:43:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DFA0F43443 for ; Fri, 1 Mar 2024 13:43:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709297004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ln2nExaBe5EeG+7ymq70OB+Ih+T+2/IykKcSs4jeT78=; b=c7c2sFkqtU9JUzN2AlgMCFhfKOHpOIU3/4I5QT7YaT6k/RpBkfzG978U2+wrGgf8knEIhO +28XLI1QlWoqCBsMUMBhf6PB1s3ujS94oZVY8xVviLvnPzbMRmTdWqH2oSiPVoIhTOgh6P f/gcPiIyeT0GgL/nMiVz2zhvOD2wqX0= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-244-mPub0exJNcOjQjCD5eTCGQ-1; Fri, 01 Mar 2024 07:43:23 -0500 X-MC-Unique: mPub0exJNcOjQjCD5eTCGQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d34f08b5d3so1459161fa.2 for ; Fri, 01 Mar 2024 04:43:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709297001; x=1709901801; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ln2nExaBe5EeG+7ymq70OB+Ih+T+2/IykKcSs4jeT78=; b=pY2xv3vKFspDg0XGRVLVG2so8qIK9MIxng7ePgNYeFzq+wBj0YB7y5gU5eu7B+99P7 RMisccBmDys7xVFl153ywogL+NHJ2jXAwwiJZjUrqnUYvGntWnZcJjVooCoa68j5Hkb1 4qaXgXVpOLzbyFY1RneJTOKzXLLtXmZGYbPV3uxKxscnjvPxPvYH9oDObQHoDiI+F8VG Y/sHYqZFy4WdUjHKO0jA7x7HtegpshZ0pjF60gxF5chPsUVUMSd4UvkspeqDM65vZh2B 7FqMLS63Y1h4ycd8qZSI3G+/tGNHRLbeKrdtE7ixCSUNzgQ/kcajAOkWxh+XDiwP0C00 eNwA== X-Gm-Message-State: AOJu0Yy+TaelDcNNtzso6+8tfU3PkKrfChfoC4WKbrvNvJTi1KWWll0O EDSBIDdJnCtdaA7fUTWi/k3yk/jl7XxuM7ZLpLvba1pLlmG+/w68gdeR2RYoOJUhf36I+zmxZoM F+db0+Nz8TNk2WvTILwsMd98lQC0KyZmZjHxsTE5P/gTV+TbjsIK652do9/sSyDUxXIp4LdWYoH AHbie3tXP/lC15YxI= X-Received: by 2002:a2e:9dca:0:b0:2d2:b99a:352 with SMTP id x10-20020a2e9dca000000b002d2b99a0352mr1109071ljj.44.1709297001721; Fri, 01 Mar 2024 04:43:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IEb+2Z5hYzP36kFCzI2hH0VZCvYzUHuEREDj6+iwEB1UuYVFottHUAI+T3AlsB3prPA9/6ypWJ3QtFKnBsiMGA= X-Received: by 2002:a2e:9dca:0:b0:2d2:b99a:352 with SMTP id x10-20020a2e9dca000000b002d2b99a0352mr1109046ljj.44.1709297001334; Fri, 01 Mar 2024 04:43:21 -0800 (PST) MIME-Version: 1.0 References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> <1709242325-17218-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1709242325-17218-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Fri, 1 Mar 2024 13:43:09 +0100 Message-ID: Subject: Re: [PATCH v5 00/22] stop using variadic argument pack extension To: Tyler Retzlaff Cc: dev@dpdk.org, Anatoly Burakov , Ashish Gupta , Chenbo Xia , Cristian Dumitrescu , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Konstantin Ananyev , Maxime Coquelin , Reshma Pattan , Sachin Saxena , Sivaprasad Tummala , Srikanth Yalavarthi , Stephen Hemminger , Sunil Kumar Kori , bruce.richardson@intel.com, mb@smartsharesystems.com, thomas@monjalon.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 29, 2024 at 10:32=E2=80=AFPM Tyler Retzlaff wrote: > > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > without the user of RTE_LOG_LINE using the args... and ## args compiler > extension to conditionally remove trailing comma when the macro receives > only a single argument. > > Provide a new/similar macro RTE_LOG_LINE_PREFIX that accepts the prefix > format and arguments as separate parameters allowing them to be expanded > at the correct locations inside of RTE_FMT() allowing the rest of the > non-prefix format string and arguments to be collapsed to the argument > pack which can be directly forwarded with __VA_ARGS__ avoiding the need > for conditional comma removal. > > I've done my best to manually check expansions (preprocessed) and compile= d > printf of the logs to validate correct output. > > v5: > * add missing newline escape and comma in rte_windows.h > macro. LGTM. Series applied, thanks. --=20 David Marchand