From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99CDAA046B for ; Thu, 25 Jul 2019 21:04:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 929EC1C390; Thu, 25 Jul 2019 21:04:16 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id D7C3D1C38C for ; Thu, 25 Jul 2019 21:04:14 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id m23so34438150vso.1 for ; Thu, 25 Jul 2019 12:04:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kxjYh1oaSM5w5XBx00EJZqqUQ4d2WXdPs3lZkAzCR2Q=; b=mcERjimaVj4wrR/md8K9jem23lj7UjqBLV8/MBIUvj/InGQDrx33JBv5asz6xbFqrP SjUKurfNfaI5NdIUG1KM4mtWHSjZWTTsgigUItUISY+hv4ZBmolswT9uWp2YCUNMlMyU t5Pe4rnB7MokFQehsWJYAgHAcLXZ5rEIPbKzcgXs5uyCfU63ZRrmqmuuPaPQwY4kJvCc DO/0e0BzMnVy2G58xw0q8wfei6l6GTDea4plZKdhVR4YS/OPr3PASst+v3fu7eV138aC HFnIfGp5kmtjP9kHcY5WfjdYJf8MXnRvXtz4QTks5lsv00v2KpwX5szcfio9MKNoB4b5 +D/Q== X-Gm-Message-State: APjAAAUTVeXAn8pjT+yiSoUSb4I+DabmINaABxkzTEuOAWpqVvCFmC68 799lrcgqlcGj7BcQz+TovJdwHcAI7Qp/CgakcSBZlA== X-Google-Smtp-Source: APXvYqwzR04xsLqPzSUzs5LG26U8R4bCszMoWvMH8qAQoLzF+GSdVSl8sguCgNkhAjD4Q7zMQkNtDUFeh/omIUaNDxA= X-Received: by 2002:a67:d81b:: with SMTP id e27mr53624914vsj.198.1564081454321; Thu, 25 Jul 2019 12:04:14 -0700 (PDT) MIME-Version: 1.0 References: <1564046068-21905-1-git-send-email-david.marchand@redhat.com> <1564046068-21905-3-git-send-email-david.marchand@redhat.com> <20190725154915.GA29561@intel.com> In-Reply-To: <20190725154915.GA29561@intel.com> From: David Marchand Date: Thu, 25 Jul 2019 21:04:03 +0200 Message-ID: To: Ye Xiaolong Cc: dev , "Yigit, Ferruh" , Qi Zhang Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/8] net/af_xdp: remove unused Tx counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 25, 2019 at 5:49 PM Ye Xiaolong wrote: > > On 07/25, David Marchand wrote: > >This Tx counter is now unused. > > > >Fixes: 10edf857fde4 ("net/af_xdp: make reserve/submit peek/release consistent") > > err_pkts seems not introduced by this commit? This commit removed the only place where it was used. > > > > >Signed-off-by: David Marchand > >--- > > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 -- > > 1 file changed, 2 deletions(-) > > > >diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c > >index 33352e1..41ed5b2 100644 > >--- a/drivers/net/af_xdp/rte_eth_af_xdp.c > >+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > >@@ -97,7 +97,6 @@ struct pkt_rx_queue { > > > > struct tx_stats { > > uint64_t tx_pkts; > >- uint64_t err_pkts; > > uint64_t tx_bytes; > > }; > > > >@@ -456,7 +455,6 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > > stats->imissed += xdp_stats.rx_dropped; > > > > stats->opackets += stats->q_opackets[i]; > >- stats->oerrors += txq->stats.err_pkts; > > stats->obytes += stats->q_obytes[i]; > > } > > > >-- > >1.8.3.1 > > > > Reviewed-by: Xiaolong Ye Thanks. -- David Marchand