From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 484CAA04A5; Wed, 9 Feb 2022 15:04:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C2D441157; Wed, 9 Feb 2022 15:04:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9921541143 for ; Wed, 9 Feb 2022 15:04:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644415472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SY9ICdlksfCFbWwyl/HiWzGi5F4LJ6hc28uma7xvCGQ=; b=OueBm5R3jtEIzgQ/GX/7Xlp3zMUIJqZSCOGvRNnGq+VrifchK1ZHvBlBU5xQEyiY0plvK4 YUpNagAthdjjJVfzZ2XDofls2rY8ABHlhqmN5QqlDENAg/hbM4VaXKcGLMyXqHGIrnJteG fWKPJP0E9c3rv7cmEnI/qimQHycQX1o= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-99-nqVbPFJKOqaH1NVIQvxZAA-1; Wed, 09 Feb 2022 09:04:30 -0500 X-MC-Unique: nqVbPFJKOqaH1NVIQvxZAA-1 Received: by mail-lj1-f200.google.com with SMTP id v1-20020a2e9601000000b002446a7310a1so1132064ljh.3 for ; Wed, 09 Feb 2022 06:04:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SY9ICdlksfCFbWwyl/HiWzGi5F4LJ6hc28uma7xvCGQ=; b=cSxEQW7fCu6Qf1XSDUBpXmHTlyvukh5MQPUMoUj+KJpYBPg0dFzfVBTXRwVFuzg+c0 /49OQoSmYesLYmdkeSRenstG9rbMsRSyjihtrRYAm6UodmPsSFNePVkoYiCSUHMxq5TW CONJVnrl0u3jx66SIvbF7ws9Fpp0bi09AiXR+ZULKoNgsDbcp7fhqKdkuRCi2VS5MOSa KrRPufRWfGHZMiBLOXSR0Z6rl5igZSGU1FIclQKuSMAHUBjhpndZecETLXM9KlXlEPoX 5C1YQkTwffh6433Lm/+nd8gf31URF0EWbXIizKrNiR/v78yUt8qqZG9benBym2OewoV3 nWqg== X-Gm-Message-State: AOAM531kjqg+myqtEkJRcUibITUPftfJJKSUXECCI5pd4hPsYZnDVPD5 iCFPMhxioixRmOEQOjRKu1gy2BgmKCwwtV5xz26nDWtJaRq7BwcYRHJ51vIyspFocWXiLzrd5WZ SXIWTs29X6d3R/irVN+Q= X-Received: by 2002:a2e:834c:: with SMTP id l12mr1634642ljh.81.1644415469063; Wed, 09 Feb 2022 06:04:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJww5cT3pbrKDn1XAaPh7nmgaZU03HJovWJP0GIadN4DyLJee2yWqE2VP5vY3nzFKpC8lmQdEl33jLFja6DZlQo= X-Received: by 2002:a2e:834c:: with SMTP id l12mr1634629ljh.81.1644415468813; Wed, 09 Feb 2022 06:04:28 -0800 (PST) MIME-Version: 1.0 References: <20220208134715.796609-1-thomas@monjalon.net> <2022216.KlZ2vcFHjT@thomas> In-Reply-To: <2022216.KlZ2vcFHjT@thomas> From: David Marchand Date: Wed, 9 Feb 2022 15:04:16 +0100 Message-ID: Subject: Re: [PATCH] ci: remove outdated default reference tag for ABI To: Thomas Monjalon Cc: dev , Michael Santana , Lincoln Lavoie , Owen Hilyard , Aaron Conole Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 9, 2022 at 2:38 PM Thomas Monjalon wrote: > > 08/02/2022 16:08, Aaron Conole: > > Thomas Monjalon writes: > > > > > The variable REF_GIT_TAG is set in the CI configuration > > > like .travis.yml or .github/workflows/build.yml. > > > The default value is outdated and probably unused. > > > It is removed completely to avoid forgetting an update in future. > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > > I think the default was there for labs that run the build script > > manually. Maybe there are no such users, though. I believe the lab has > > its own script for doing such ABI checks (but can't remember off the top > > of my head). > > > > CC'd Lincoln and Owen just to confirm. > > > > Assuming the UNH/other lab doesn't use this feature of the linux build > > script, > > > > Acked-by: Aaron Conole > > I could also remove this variable: > LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6} > > It is confusing to see an old version here, > while we use the version 1.8. > > If no objection, I'll send a v2. +1. -- David Marchand