[PATCH] common/mlx5: replace use of PMD logtype

[PATCH] common/mlx5: replace use of PMD logtype

[Stephen Hemminger]

The goal to eliminate the generic PMD logtype.
One place it is used unnecessarily is in the mlx5 common code.
Change the one RTE_LOG() call here to use the same macro
as other log messages in same file.

Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
Cc: viacheslavo@nvidia.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index fb670950ef64..710649f86533 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -543,7 +543,7 @@ mlx5_devx_cmd_query_hca_vdpa_attr(void *ctx,
 			MLX5_GET_HCA_CAP_OP_MOD_VDPA_EMULATION |
 			MLX5_HCA_CAP_OPMOD_GET_CUR);
 	if (!hcattr) {
-		RTE_LOG(DEBUG, PMD, "Failed to query devx VDPA capabilities");
+		DRV_LOG(DEBUG, "Failed to query devx VDPA capabilities");
 		vdpa_attr->valid = 0;
 	} else {
 		vdpa_attr->valid = 1;
-- 
2.39.1

RE: [PATCH] common/mlx5: replace use of PMD logtype

[Slava Ovsiienko]

Hi, Stephen

We have another place of using RTE_LOG in mlx5_glue_path().
Should we update this one as well ?

With best regards,
Slava


> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: четверг, 23 февраля 2023 г. 19:41
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Gregory
> Etelson <getelson@nvidia.com>
> Subject: [PATCH] common/mlx5: replace use of PMD logtype
> 
> The goal to eliminate the generic PMD logtype.
> One place it is used unnecessarily is in the mlx5 common code.
> Change the one RTE_LOG() call here to use the same macro as other log
> messages in same file.
> 
> Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
> Cc: viacheslavo@nvidia.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c
> b/drivers/common/mlx5/mlx5_devx_cmds.c
> index fb670950ef64..710649f86533 100644
> --- a/drivers/common/mlx5/mlx5_devx_cmds.c
> +++ b/drivers/common/mlx5/mlx5_devx_cmds.c
> @@ -543,7 +543,7 @@ mlx5_devx_cmd_query_hca_vdpa_attr(void *ctx,
>  			MLX5_GET_HCA_CAP_OP_MOD_VDPA_EMULATION
> |
>  			MLX5_HCA_CAP_OPMOD_GET_CUR);
>  	if (!hcattr) {
> -		RTE_LOG(DEBUG, PMD, "Failed to query devx VDPA
> capabilities");
> +		DRV_LOG(DEBUG, "Failed to query devx VDPA capabilities");
>  		vdpa_attr->valid = 0;
>  	} else {
>  		vdpa_attr->valid = 1;
> --
> 2.39.1

Re: [PATCH] common/mlx5: replace use of PMD logtype

[David Marchand]

On Mon, Mar 6, 2023 at 2:19 PM Slava Ovsiienko <viacheslavo@nvidia.com> wrote:
>
> Hi, Stephen
>
> We have another place of using RTE_LOG in mlx5_glue_path().
> Should we update this one as well ?

I think we should.
Stephen can you send a new revision?


-- 
David Marchand

[PATCH v2] common/mlx5: replace use of PMD logtype

[Stephen Hemminger]

The goal to eliminate the generic PMD logtype.
One place it is used unnecessarily is in the mlx5 common code.
Change the one RTE_LOG() call here to use the same macro
as other log messages in same file.

Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
Cc: viacheslavo@nvidia.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index 66a77159a031..9db0b2ac8983 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -543,7 +543,7 @@ mlx5_devx_cmd_query_hca_vdpa_attr(void *ctx,
 			MLX5_GET_HCA_CAP_OP_MOD_VDPA_EMULATION |
 			MLX5_HCA_CAP_OPMOD_GET_CUR);
 	if (!hcattr) {
-		RTE_LOG(DEBUG, PMD, "Failed to query devx VDPA capabilities");
+		DRV_LOG(DEBUG, "Failed to query devx VDPA capabilities");
 		vdpa_attr->valid = 0;
 	} else {
 		vdpa_attr->valid = 1;
-- 
2.39.2

[PATCH v3] common/mlx5: replace use of PMD logtype

[Stephen Hemminger]

The goal to eliminate the generic PMD logtype.
One place it is used unnecessarily is in the mlx5 common code.
Change the one RTE_LOG() call here to use the same macro
as other log messages in same file.

Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
Cc: viacheslavo@nvidia.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v3 - also address use in glue code

 drivers/common/mlx5/linux/mlx5_common_os.c | 2 +-
 drivers/common/mlx5/mlx5_devx_cmds.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c
index 2ebb8ac8b6e5..7260c1a19fd3 100644
--- a/drivers/common/mlx5/linux/mlx5_common_os.c
+++ b/drivers/common/mlx5/linux/mlx5_common_os.c
@@ -266,7 +266,7 @@ mlx5_glue_path(char *buf, size_t size)
 		goto error;
 	return buf;
 error:
-	RTE_LOG(ERR, PMD, "unable to append \"-glue\" to last component of"
+	DRV_LOG(ERR, "unable to append \"-glue\" to last component of"
 		" RTE_EAL_PMD_PATH (\"" RTE_EAL_PMD_PATH "\"), please"
 		" re-configure DPDK");
 	return NULL;
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index 66a77159a031..9db0b2ac8983 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -543,7 +543,7 @@ mlx5_devx_cmd_query_hca_vdpa_attr(void *ctx,
 			MLX5_GET_HCA_CAP_OP_MOD_VDPA_EMULATION |
 			MLX5_HCA_CAP_OPMOD_GET_CUR);
 	if (!hcattr) {
-		RTE_LOG(DEBUG, PMD, "Failed to query devx VDPA capabilities");
+		DRV_LOG(DEBUG, "Failed to query devx VDPA capabilities");
 		vdpa_attr->valid = 0;
 	} else {
 		vdpa_attr->valid = 1;
-- 
2.39.2

Re: [PATCH v3] common/mlx5: replace use of PMD logtype

[Tyler Retzlaff]

On Mon, Aug 21, 2023 at 09:16:25AM -0700, Stephen Hemminger wrote:
> The goal to eliminate the generic PMD logtype.
> One place it is used unnecessarily is in the mlx5 common code.
> Change the one RTE_LOG() call here to use the same macro
> as other log messages in same file.
> 
> Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
> Cc: viacheslavo@nvidia.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

RE: [PATCH v3] common/mlx5: replace use of PMD logtype

[Raslan Darawsheh]

Hi,

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, August 21, 2023 7:16 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Gregory
> Etelson <getelson@nvidia.com>
> Subject: [PATCH v3] common/mlx5: replace use of PMD logtype
> 
> The goal to eliminate the generic PMD logtype.
> One place it is used unnecessarily is in the mlx5 common code.
> Change the one RTE_LOG() call here to use the same macro as other log
> messages in same file.
> 
> Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
> Cc: viacheslavo@nvidia.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v3 - also address use in glue code

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh