From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C322A04B8; Mon, 11 Nov 2019 13:27:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98393DE3; Mon, 11 Nov 2019 13:27:38 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 10CA3CF3 for ; Mon, 11 Nov 2019 13:27:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573475256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ykOdEb5NVq66FkUO/PVuUj4zcDcIN6Zy/iwJ/41qbVg=; b=YM9g0+qa4tjcgTE6zon0EU1OyAwMCnot/n6tQsqtUUtTkuL24zk3/atWH3/MTG7bqi9+HF d/1UFwxs6guKrmQI64O1sNqtzgBTPYENnOK/lVpDS3n3fxmqRfHH01uSsMNBS0tuHayGeV VRpUNmROhKQJVZtyAu6rJRpqmv70s10= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-A9UUuzoJO6OGI9RtWG6GJQ-1; Mon, 11 Nov 2019 07:27:35 -0500 Received: by mail-vk1-f197.google.com with SMTP id i5so7891973vkg.21 for ; Mon, 11 Nov 2019 04:27:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ykOdEb5NVq66FkUO/PVuUj4zcDcIN6Zy/iwJ/41qbVg=; b=XZaqJ77ECEQrUfpQ2Qei9VEeh/K8SPka0u2wmhdlSxMG2J3tYYiI2Zd2/eOB5VLO/w pvyDuYj+wHbcU7Q2E3H55WzCRuDJ+ETl6cEnh5hAFqSzSSgj2fKqbibbhKugQJKCXkJn zuSfbyNiiVDPtYEJC9gnbPSH2riP54C6ZETtEt6G5RDZzQjmnNlTdbUqk8a0VdHjMGZx cxRcxNNN5dqYbaOh7nC6MnH9bMMgtwjofbVGKNGVGUoY7a+pxwyhqI7mp/AyUhbeZmJu YMUfysAMfoVcZkCQGlZ/uxC+K9su/HMJOdY0aVYux61iz2j4z13ROQv5TyqmKOjGkRwT X/CQ== X-Gm-Message-State: APjAAAWUTHxHQlU0+1jlCIVdiwCcl9fqm3wY+huUmDaP9HkgO3Hn9Bas +5Zr+wxmfgxn9kr36CsHDiYdNCzH0Gw7WuY/0Qtio8wWtZrOOtal0Y/SPQ4cmt8eHR4tdnOiz+x ocIzY/cYzLVDyt5GNdjE= X-Received: by 2002:a67:7d95:: with SMTP id y143mr19890427vsc.39.1573475254917; Mon, 11 Nov 2019 04:27:34 -0800 (PST) X-Google-Smtp-Source: APXvYqyxBlp3FnFkUWo0fOKDeCBALiWZ1UOrEUi8EE2kV43tQIw3F3FatiGgYetFOLHjTuOLUY2qZfemHbfu19TQk4Y= X-Received: by 2002:a67:7d95:: with SMTP id y143mr19890410vsc.39.1573475254546; Mon, 11 Nov 2019 04:27:34 -0800 (PST) MIME-Version: 1.0 References: <1573241531-16484-1-git-send-email-david.marchand@redhat.com> <21851495.KjiF73E6hx@xps> <20191111113149.GC1444@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20191111113149.GC1444@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Mon, 11 Nov 2019 13:27:23 +0100 Message-ID: To: Bruce Richardson Cc: Thomas Monjalon , dev , aostruszka@marvell.com, Aaron Conole , Michael Santana X-MC-Unique: A9UUuzoJO6OGI9RtWG6GJQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] ci: remove LTO job X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 11, 2019 at 12:32 PM Bruce Richardson wrote: > > On Fri, Nov 08, 2019 at 08:55:52PM +0100, Thomas Monjalon wrote: > > 08/11/2019 20:32, David Marchand: > > > The LTO job using gcc-7 has two issues at the moment: > > > - warnings about implicit fallthroughs trigger build errors: > > > > > > In file included from ...common/include/rte_memory.h:22:0, > > > from ...linux/eal/eal_hugepage_info.c:24: > > > ...common/include/rte_common.h: In function =E2=80=98rte_str_to_size= =E2=80=99: > > > ...common/include/rte_common.h:744:27: error: this statement may > > > fall through [-Werror=3Dimplicit-fallthrough=3D] > > > case 'G': case 'g': size *=3D 1024; /* fall-through */ > > > ~~~~~^~~~~~~ > > > > > > - if we disable this warning, linking the binaries takes too much tim= e > > > and the job is terminated by Travis because it reaches the maximum > > > time limit > > > > > > Fixes: 098cc0fea3be ("build: add option to enable LTO") > > > > > > Signed-off-by: David Marchand > > > > Acked-by: Thomas Monjalon > > > > Thank you, I should have tested it in Travis before merging. > > > I'm also interested in whether someone can give steps to reproduce this > issue outside of the Travis environment. I've tested with gcc-7 on both > Ubuntu 16.04 (as used by Travis) and Ubuntu 18.04, and the builds I teste= d > all worked fine, without any warnings being seen. I am therefore wonderin= g > what is special about the travis setup that causes it to fail. Did you try with the custom apt repository that the LTO job was using ? - apt: - sources: - - ubuntu-toolchain-r-test --=20 David Marchand