From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79484A0588; Tue, 7 Apr 2020 13:40:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CA192B96; Tue, 7 Apr 2020 13:40:36 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 115382B83 for ; Tue, 7 Apr 2020 13:40:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586259634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=txidh95sMhiGRO4IpOCKM+5MkzjJecMI4xuOk+VVclU=; b=jLVKiWuj9pLsrQIRZn3OFopg3J2Hdk8ktHrX7L3QSAKY1Hvbot14kuaz+XKMYLWO+Nepgw eAQeJJEZrBUX7vzKrLXyAg+fJkcohmNvx5qC7i5cBhP/Rzbv8T7CuewrdUvzELXLeF6Svo ZIUqq7lCWhrzPume4u5wkYq9G2gWvQQ= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-71-5QAjQktoMtyV_15FlvzTOQ-1; Tue, 07 Apr 2020 07:40:29 -0400 X-MC-Unique: 5QAjQktoMtyV_15FlvzTOQ-1 Received: by mail-ua1-f71.google.com with SMTP id c3so219969uae.4 for ; Tue, 07 Apr 2020 04:40:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dtOezr4puYhPIIskiN24827ISgNmYnp8/GvBsQuGp8M=; b=H9/rApFt3m783c01n1jCG3BAIz3wnmLo5zkV+GL3f+XXjUcP6Z93gMb1gf0yKIwjND 4u+OM73fSMsl5P/OYCYKzIevKTFqAi3Q9uewKKySSs7HYdid6SUtp9LG54CMsXpEDNQW f3f1Is68DEceINmhHGQY455rCLpSVyBoRCWfbaHqcX/dadEvxNgPuFclV2KOkjexx6JL fAuwSs2jovaSchCkveMX4EXVV/t9IT0oCejjE0WNn7I4DvCY72/X/IOWtR/gS9T3/3ml do85HXxessrZdUfcun+nlk1FIRhQ8nBiLP04zCUTGHf6geQDeZ8PEkgAtpuaD12cR7/o 3ukA== X-Gm-Message-State: AGi0Puaavtdd4OufYsuKAzrWNXdqPRl2MYl8tg5hRRG1tWohBgd1bi7p Ga4JbSSycwiUbADAVovpAi3UqQPvGgdfdh9xsgM6Dw4RbFMB/EbPPNJEDj8nt61tbmA1zREK9rc w5deJq2FOzALgsNbN5FY= X-Received: by 2002:a9f:2204:: with SMTP id 4mr1293719uad.87.1586259628632; Tue, 07 Apr 2020 04:40:28 -0700 (PDT) X-Google-Smtp-Source: APiQypLCySa1gQooBMTaysZo8E38uGmBrgQgpU5Vk770TaTIecC5QvAzgdxeShmYXC74TNTvLMI7Ga3MV98ckuVM9RQ= X-Received: by 2002:a9f:2204:: with SMTP id 4mr1293684uad.87.1586259628229; Tue, 07 Apr 2020 04:40:28 -0700 (PDT) MIME-Version: 1.0 References: <20200406193430.81268-1-nhorman@tuxdriver.com> <20200407113311.GB128325@hmswarspite.think-freely.org> In-Reply-To: <20200407113311.GB128325@hmswarspite.think-freely.org> From: David Marchand Date: Tue, 7 Apr 2020 13:40:16 +0200 Message-ID: To: Neil Horman Cc: dev , Thomas Monjalon , Kevin Laatz , "Kinsella, Ray" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 7, 2020 at 1:33 PM Neil Horman wrote: > > On Tue, Apr 07, 2020 at 09:36:17AM +0200, David Marchand wrote: > > On Mon, Apr 6, 2020 at 9:34 PM Neil Horman wrot= e: > > > > > > Since we've moved away from our initial abi_versioning.sh script, in > > > > abi_versioning.sh does not exist (idem with the patch title). > > I suppose you meant validate-abi.sh. > > > Crud, you're right, I was convoluting terms, sorry. Shall I repost with = a > corrected changelog? Yes, and with the other comment I did earlier, addressed too. > > > favor of check_abi.sh, which uses libabigail, remove the old script f= rom > > > > check-abi.sh > > > > > the tree, and update the docs accordingly > > > > > > > [snip] > > > > > diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/= contributing/abi_versioning.rst > > > index a21f4e7a4..1c4a3f927 100644 > > > --- a/doc/guides/contributing/abi_versioning.rst > > > +++ b/doc/guides/contributing/abi_versioning.rst > > > @@ -482,9 +482,9 @@ Running the ABI Validator > > > ------------------------- > > > > > > The ``devtools`` directory in the DPDK source tree contains a utilit= y program, > > > -``validate-abi.sh``, for validating the DPDK ABI based on the Linux = `ABI > > > -Compliance Checker > > > -`_. > > > +``check-abi.sh``, for validating the DPDK ABI based on the libabigai= l abidiff > > > +utility: > > > +https://sourceware.org/libabigail/manual/abidiff.html > > > > > > This has a dependency on the ``abi-compliance-checker`` and ``and ab= i-dumper`` > > > utilities which can be installed via a package manager. For example:= : > > > @@ -492,9 +492,9 @@ utilities which can be installed via a package ma= nager. For example:: > > > sudo yum install abi-compliance-checker > > > sudo yum install abi-dumper > > > > > > -The syntax of the ``validate-abi.sh`` utility is:: > > > +The syntax of the ``check-abi.sh`` utility is:: > > > > > > - ./devtools/validate-abi.sh > > > + ./devtools/check-abi.sh > > > > The new script is not a direct replacement. > > It won't take git revisions, but build directories where versions of > > dpdk have been compiled. > > > > devtools/test-build.sh and devtools/test-meson-builds.sh illustrate its= use. > > https://git.dpdk.org/dpdk/tree/devtools/test-meson-builds.sh#n127 > > Thanks. --=20 David Marchand