From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 579E342C02; Thu, 1 Jun 2023 12:04:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0EF8406B3; Thu, 1 Jun 2023 12:04:17 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 068DC406A2 for ; Thu, 1 Jun 2023 12:04:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685613855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gto7SSPiPhrD6hmmNWke/OqTbQ+2TVObQ1Q7rUIJGfs=; b=cmglrTeQ4F/7ZQ+FUMlcMZFY32wiM2EF7atOQDDVaHyt5fdHdReFCsXBOSz04HBKvvpV0b RNdT1QBwxtxdWBrgf1rD+WWsC3gtYHZguBsKv6Mp0GKgoxAe/rWr5Wq1MRAUNTzQs8PO2Z EWBOCaR6IgqeCj+7HPZUZ/WUL89179w= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-NKxLJvXAMG2Exz5LiUHRjA-1; Thu, 01 Jun 2023 06:04:12 -0400 X-MC-Unique: NKxLJvXAMG2Exz5LiUHRjA-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1b04bc1f3cbso1884095ad.2 for ; Thu, 01 Jun 2023 03:04:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685613851; x=1688205851; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gto7SSPiPhrD6hmmNWke/OqTbQ+2TVObQ1Q7rUIJGfs=; b=hJPmSiMI4qnjan9OSDZSv1Cw4Fp+30vfoFa1PdV/UA6i+hsfl1fuYrm0gTKiXd1Ehc YJlF9c5kTTBNnUQzNWSZFeaVzrqFqc6ucjFP4H23vDo/yCNMzJWLn+QhJMd/xgJMaYXx I65eIBTY+Iy5xE5FazcOvR4ftC8LraaXBs4S/Azq0tm226upZYSwENcGlFXek8hOJrWb bfZYkmvu/bFrtJBVIlQ6/d2kIRQtHVAru0hOAu1ImlsZAznFf/YALKBHxNn6v1ansFxQ wLbc8T5vg2qA56XOgO07X3TgxLk72H1i2qr1Ur8AKb3k8nnEBvIu80HEgntggphXYDbT 6mdA== X-Gm-Message-State: AC+VfDwD2G5XyC9bUP4wpDBZdf/Qdy+wrLaHtyyEjvccCSMfF248gGA6 0yq8AesiW3UD0IerkajKOwPTiv4KwvcaMwS0i+Bmaf18hdjpWnX7eTrI24S2W9b/7eSBfyghDS8 LbeXC54NudEYchtNhqcc= X-Received: by 2002:a05:6a20:a598:b0:10e:2fd5:510d with SMTP id bc24-20020a056a20a59800b0010e2fd5510dmr5169213pzb.11.1685613850164; Thu, 01 Jun 2023 03:04:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4AOE08qLmiQrWfgoTWEDw4l0AMQ7Hl44PYsbgL/t0lJxZHXxNPV/8YS/Sxqj0Lna3i9wrf+UP7TaSpIOO61fY= X-Received: by 2002:a05:6a20:a598:b0:10e:2fd5:510d with SMTP id bc24-20020a056a20a59800b0010e2fd5510dmr5169143pzb.11.1685613848409; Thu, 01 Jun 2023 03:04:08 -0700 (PDT) MIME-Version: 1.0 References: <20230505103102.2912297-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 1 Jun 2023 12:03:57 +0200 Message-ID: Subject: Re: [RFC PATCH] ethdev: advertise flow restore in mbuf To: Ori Kam Cc: "dev@dpdk.org" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "i.maximets@ovn.org" , Aman Singh , Yuying Zhang , Matan Azrad , Slava Ovsiienko , Andrew Rybchenko , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 1, 2023 at 12:02=E2=80=AFPM Ori Kam wrote: > > Hi David, > > > -----Original Message----- > > From: David Marchand > > Sent: Thursday, June 1, 2023 12:43 PM > > Subject: Re: [RFC PATCH] ethdev: advertise flow restore in mbuf > > > > On Thu, Jun 1, 2023 at 11:31=E2=80=AFAM Ori Kam wrot= e: > > > > > > > > > > > > > -----Original Message----- > > > > From: David Marchand > > > > Sent: Thursday, June 1, 2023 11:48 AM > > > > > > > > On Wed, May 24, 2023 at 8:44=E2=80=AFPM David Marchand > > > > wrote: > > > > > On Wed, May 24, 2023 at 6:00=E2=80=AFPM Ori Kam wrote: > > > > > > > As reported by Ilya [1], unconditionally calling > > > > > > > rte_flow_get_restore_info() impacts an application performanc= e for > > > > drivers > > > > > > > that do not provide this ops. > > > > > > > It could also impact processing of packets that require no ca= ll to > > > > > > > rte_flow_get_restore_info() at all. > > > > > > > > > > > > > > Advertise in mbuf (via a dynamic flag) whether the driver has= more > > > > > > > metadata to provide via rte_flow_get_restore_info(). > > > > > > > The application can then call it only when required. > > > > > > > > > > > > > > Link: http://inbox.dpdk.org/dev/5248c2ca-f2a6-3fb0-38b8- > > > > > > > 7f659bfa40de@ovn.org/ > > > > > > > Signed-off-by: David Marchand > > > > > > > --- > > > > > > > Note: I did not test this RFC patch yet but I hope we can res= ume > > and > > > > > > > maybe conclude on the discussion for the tunnel offloading AP= I. > > > > > > > > > > > > > > > > > > > I think your approach has a good base but what happens if > > > > > > it is not relevant for all flows? In this case your solution wi= ll not work. > > > > > > > > > > Sorry, I am not following. > > > > > Could you develop? > > > > > > > > I still don't get your comment, could you give an example/usecase > > > > where this approach can't work? > > > > Thanks. > > > > > > > I'm think of a use case that some flows have the restore info, while > > > other don't for example, we get arp packets or some packets that > > > are not tunneled, and we also get tunneled packets. > > > > > > Or for example PMD supports this flag but the application didn't offl= oad > > such a rule yet. > > > > Again, maybe I missed something, but my proposal is for a *per packet* > > report from the driver. > > I am not for a global driver capability, if this is what you have in mi= nd. > > > My bad, per packet solves the issue I was talking about, but it makes it = worse. > This means that PMD needs to add logic in it's datapath. This may affect = all > traffic. Well, look at the patch then, I already updated the driver. I don't expect much of an impact with the current code though. --=20 David Marchand