From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42FF0A04BC; Thu, 8 Oct 2020 09:51:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 210101B9F0; Thu, 8 Oct 2020 09:51:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 624331B9DC for ; Thu, 8 Oct 2020 09:51:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602143480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Csho0JFTpmlOFrtpcH2u9U+h8pVMvx8I2+MH2LdZrBs=; b=hy259CRA7h2v5JtVUQEEFxm/31c10Cs3Ig2B8Zke08LkA1v7+HoUMSj0tN7LEWoqH6zcHM BZwwHAx5ghoMcSX3180d9QhtNQAJLckFiIVbXoxheTHGD8WL9MGkU0qs5R3JtdotrBForh c7XeA/vtIyt5/t1ZU1lVqHMFUs7rQaY= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-LkJKU8JNMviESVdjzPThLw-1; Thu, 08 Oct 2020 03:51:19 -0400 X-MC-Unique: LkJKU8JNMviESVdjzPThLw-1 Received: by mail-vk1-f198.google.com with SMTP id g7so788690vkl.11 for ; Thu, 08 Oct 2020 00:51:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Csho0JFTpmlOFrtpcH2u9U+h8pVMvx8I2+MH2LdZrBs=; b=ZBMsBVfFHzT4Lt7ANZ/Qp38C+cEi1n1DymBpjWA54oSXr1t61cAwqY/Xxsz8w3mEgi 1k3FwUegAxVOmmsR7i2FiBhbblyrW+9QxsOnKqStN6o/fwpJCnDsiuqC9gEPolOoud7e iVo9QYZqaBILPsAuCpocv6l5t+tc50h4TzOKP4cE9X1+XvSqmUu9+bojwAmexb+x/VxU aEuPnT2YdDrKn+9tnN6DtYciTqxD4jhKRyMKCGeKW9Ri6rdsMiByScBf+ctCVlCr/qqE 1Uibw5EaWMSYiH1B+IO7KGO5YkaP+9YNmOYddjf5dUGtQyz3+pMhQczYcXowO2OlNQ6N rGAQ== X-Gm-Message-State: AOAM530bAOzaIa415Ml9erpzgqka5rdg2sUkWRHX18A8UOvDCRkdbUFI X2O8yGD/vCiFB2O1ZztmNNYeXUwnguowUjcg8RuEbjrFNc4wq9PfL1wrHGm0OKcwHLUMmTdvT4p 8RUaPCPYDfALZ0UJ749M= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr3997585vsh.10.1602143478740; Thu, 08 Oct 2020 00:51:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUMK/GiqasaG1CIGetVxOPTBnVRul1MZmttWapxQC8DAN/cJWaBz77SrLVPoeu1LXK95ihkXXSnjFVrtlO45s= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr3997576vsh.10.1602143478465; Thu, 08 Oct 2020 00:51:18 -0700 (PDT) MIME-Version: 1.0 References: <20200624093627.2603992-1-thomas@monjalon.net> <20200928000049.3245920-1-thomas@monjalon.net> In-Reply-To: <20200928000049.3245920-1-thomas@monjalon.net> From: David Marchand Date: Thu, 8 Oct 2020 09:51:07 +0200 Message-ID: To: Thomas Monjalon Cc: dev , techboard@dpdk.org, Bruce Richardson , Ray Kinsella , Neil Horman Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] eal: simplify exit functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 28, 2020 at 2:01 AM Thomas Monjalon wrote: > > The option RTE_EAL_ALWAYS_PANIC_ON_ERROR was off by default, > and not customizable with meson. It is completely removed. > > The function rte_dump_registers is a trace of the bare metal support > era, and was not supported in userland. It is completely removed. > > Signed-off-by: Thomas Monjalon > Acked-by: Ray Kinsella > --- > The deprecation notice for this removal has been missed. > I assume it would not hurt anybody to remove this useless function > from DPDK 20.11. Asking the Technical Board for confirmation. > --- > app/test/test_debug.c | 3 --- > doc/guides/howto/debug_troubleshoot.rst | 2 +- > doc/guides/rel_notes/release_20_11.rst | 2 ++ > lib/librte_eal/common/eal_common_debug.c | 17 +---------------- > lib/librte_eal/include/rte_debug.h | 7 ------- > lib/librte_eal/rte_eal_version.map | 1 - > 6 files changed, 4 insertions(+), 28 deletions(-) > > diff --git a/app/test/test_debug.c b/app/test/test_debug.c > index 25eab97e2a..834a7386f5 100644 > --- a/app/test/test_debug.c > +++ b/app/test/test_debug.c > @@ -66,13 +66,11 @@ test_exit_val(int exit_val) > } > wait(&status); > printf("Child process status: %d\n", status); > -#ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR > if(!WIFEXITED(status) || WEXITSTATUS(status) != (uint8_t)exit_val){ > printf("Child process terminated with incorrect status (expected = %d)!\n", > exit_val); > return -1; > } > -#endif > return 0; > } > > @@ -113,7 +111,6 @@ static int > test_debug(void) > { > rte_dump_stack(); > - rte_dump_registers(); > if (test_panic() < 0) > return -1; > if (test_exit() < 0) > diff --git a/doc/guides/howto/debug_troubleshoot.rst b/doc/guides/howto/debug_troubleshoot.rst > index 5a46f5fba3..50bd32a8ef 100644 > --- a/doc/guides/howto/debug_troubleshoot.rst > +++ b/doc/guides/howto/debug_troubleshoot.rst > @@ -314,7 +314,7 @@ Custom worker function :numref:`dtg_distributor_worker`. > * For high-performance execution logic ensure running it on correct NUMA > and non-master core. > > - * Analyze run logic with ``rte_dump_stack``, ``rte_dump_registers`` and > + * Analyze run logic with ``rte_dump_stack`` and > ``rte_memdump`` for more insights. > > * Make use of objdump to ensure opcode is matching to the desired state. > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst > index f377ab8e87..c0b83e9554 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -184,6 +184,8 @@ ABI Changes > Also, make sure to start the actual text at the margin. > ======================================================= > > +* eal: Removed the not implemented function ``rte_dump_registers()``. > + > * ``ethdev`` changes > > * Following device operation function pointers moved > diff --git a/lib/librte_eal/common/eal_common_debug.c b/lib/librte_eal/common/eal_common_debug.c > index 722468754d..15418e957f 100644 > --- a/lib/librte_eal/common/eal_common_debug.c > +++ b/lib/librte_eal/common/eal_common_debug.c > @@ -7,14 +7,6 @@ > #include > #include > > -/* not implemented */ > -void > -rte_dump_registers(void) > -{ > - return; > -} > - > -/* call abort(), it will generate a coredump if enabled */ > void > __rte_panic(const char *funcname, const char *format, ...) > { > @@ -25,8 +17,7 @@ __rte_panic(const char *funcname, const char *format, ...) > rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); > va_end(ap); > rte_dump_stack(); > - rte_dump_registers(); > - abort(); > + abort(); /* generate a coredump if enabled */ > } > > /* > @@ -46,14 +37,8 @@ rte_exit(int exit_code, const char *format, ...) > rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); > va_end(ap); > > -#ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR > if (rte_eal_cleanup() != 0) > RTE_LOG(CRIT, EAL, > "EAL could not release all resources\n"); > exit(exit_code); > -#else > - rte_dump_stack(); > - rte_dump_registers(); > - abort(); > -#endif > } > diff --git a/lib/librte_eal/include/rte_debug.h b/lib/librte_eal/include/rte_debug.h > index 50052c5a90..c4bc71ce28 100644 > --- a/lib/librte_eal/include/rte_debug.h > +++ b/lib/librte_eal/include/rte_debug.h > @@ -26,13 +26,6 @@ extern "C" { > */ > void rte_dump_stack(void); > > -/** > - * Dump the registers of the calling core to the console. > - * > - * Note: Not implemented in a userapp environment; use gdb instead. > - */ > -void rte_dump_registers(void); > - > /** > * Provide notification of a critical non-recoverable error and terminate > * execution abnormally. > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index c32461c663..cd1a90b95f 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -38,7 +38,6 @@ DPDK_21 { > rte_devargs_remove; > rte_devargs_type_count; > rte_dump_physmem_layout; > - rte_dump_registers; > rte_dump_stack; > rte_dump_tailq; > rte_eal_alarm_cancel; > -- > 2.28.0 > Acked-by: David Marchand -- David Marchand