From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09A6E4269E; Mon, 2 Oct 2023 10:26:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D241440284; Mon, 2 Oct 2023 10:26:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9E0A44003C for ; Mon, 2 Oct 2023 10:26:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696235167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9M7IS44gJqhpmyyspXI9UXL5CCaVbxv4CY7Q8NdLx1o=; b=WJtXvbRERnY7GxlP0fdWKuDV+SH4MbhlzOxJG/YdPpvLDSfWPK/e2fCrH/Dr0Ptq/rBFl7 NGjSS1BX3et4A9bkVwDfRJo5BnCPggyh6Nc0PRJuqI5iUUwTLGVoK9zMwYVsPNBmAimZHb aiwe93UzJv8xNIcurzxMz4wqDqWhtzk= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-jWoSJzkYOOCpztjkrL03Ng-1; Mon, 02 Oct 2023 04:26:05 -0400 X-MC-Unique: jWoSJzkYOOCpztjkrL03Ng-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c038a1e2f6so232916831fa.3 for ; Mon, 02 Oct 2023 01:26:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696235164; x=1696839964; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9M7IS44gJqhpmyyspXI9UXL5CCaVbxv4CY7Q8NdLx1o=; b=RMCwCcJ2aaF95wIjOyw5QDsP4OmnFZcNsioKhLTrGufwaSn9YnugHvXfu690Aa4i8a YgbRhwMzPFTFzYWZ3kGTwITXdn6JCPIlTfiYtZ+NhOOir5IM4vK2jeDSvfIRgoZiIJ0Y 1OlGRLeTGq41z1yFMffMECV/7S8lYyWWa4wfs5PH0sAOx1Txfnr1XG5MGyXiLegq8FDr c0sDzGIzUkY/2zHLqKX+ifHqBSej3NVlQv8TKjsC6+CP9aPosyjKwNjXnEnBR/6WUfRC erIjNnqFP4OJNpxhMz/3uR+tJMvjQtav1kLv7yZ1PPS/rMbi9EuFOXRDOhQxgZMoS3gr L7DQ== X-Gm-Message-State: AOJu0YwR/bdrtLOkR6uWPr9I+kPpQ/aMPsmBoC3rP/RXniVhl5iGfGfs +dWseRGo2d0dRNlT9wrPWEuZv0UojPXDkGA2H4UZ5fI/atLBFB+XSysMVpQcljYaPkKQ7GmdSuS 9q6pKMajIjQm+XH6kWF0= X-Received: by 2002:a2e:9b1a:0:b0:2bf:fa62:5ceb with SMTP id u26-20020a2e9b1a000000b002bffa625cebmr8645954lji.11.1696235164298; Mon, 02 Oct 2023 01:26:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmmRcYZbi4NvNWPQbqqoXguVLASxjzOFZmsw4BYUikDdtOyECkphTTgrRU7sbtDwwbJki1yQwxb5uMwrXl1iw= X-Received: by 2002:a2e:9b1a:0:b0:2bf:fa62:5ceb with SMTP id u26-20020a2e9b1a000000b002bffa625cebmr8645945lji.11.1696235164028; Mon, 02 Oct 2023 01:26:04 -0700 (PDT) MIME-Version: 1.0 References: <366f5750e01894c56d5d486c75d312e85c404277.1693224396.git.anatoly.burakov@intel.com> In-Reply-To: <366f5750e01894c56d5d486c75d312e85c404277.1693224396.git.anatoly.burakov@intel.com> From: David Marchand Date: Mon, 2 Oct 2023 10:25:52 +0200 Message-ID: Subject: Re: [PATCH v1 1/1] eal/random: fix random state initialization for non-eal threads To: Anatoly Burakov , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Stephen Hemminger Cc: dev@dpdk.org, Bruce Richardson , stable@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello guys, On Mon, Aug 28, 2023 at 2:07=E2=80=AFPM Anatoly Burakov wrote: > > Currently, the rte_rand() state is initialized with seed, and each > rand state is initialized up until RTE_MAX_LCORE'th rand state. However, > rand state also has one extra rand state reserved for non-EAL threads, > which is not initialized. Fix it by initializing this extra state. > > Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR= ") > Cc: mattias.ronnblom@ericsson.com > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov We have two series for fixing related issues. Stephen alternative patch 1 handles Anatoly fix here. https://patchwork.dpdk.org/project/dpdk/list/?series=3D29449&state=3D%2A&ar= chive=3Dboth I see Anatoly was acked by Mattias and Morten, though Stephen (RTE_DIM) fix is more elegant. How do you guys want me to proceed? Thanks. --=20 David Marchand