From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A48CA0487 for ; Wed, 3 Jul 2019 10:01:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C79E231E; Wed, 3 Jul 2019 10:01:56 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 839593DC for ; Wed, 3 Jul 2019 10:01:55 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id s7so2576386iob.11 for ; Wed, 03 Jul 2019 01:01:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0vUEju1IeKTQOSxJs4oyNqSP0oQ4lUAMToWlUQOVPEM=; b=kSmJVBB8KeIIa5eaCaYIzGBQ1D9c65DauX2qFq57tM6hXrHTjJLlydJ3+IL1sYLKnH NOAT6FOmpPs5YAaTJu7TYRM5hoo0oWHaP2sVdfHRYLTBvCgl9i2uHyo8eACSzech63pA dDldpObWbdfvzhMK2+YxLIrzDx4Od7nV74cJ7U52rh3Cdtc4gz7L6taZADRkGTVJODXO ygdOWVDhn7vOEWpK8EpyISfDt70GSioIaYrD2nC+AtlEAdtgMR7v0CU2tyNGIIwGFPXN q7RYkzERGdYuFE1rqBsVMUuflrdXxGje85EXEYjaIggj+Q8F3CS+e3hx7rza+zcisSls hWfg== X-Gm-Message-State: APjAAAXU9HHkve0KX92GyhwLUR650WYh3kEBj0ssiEmtsrNlexxyNKpG /YgRP/DfhEOwUHNbA29fbzH7vRK8HddfvdjAS4+RkA== X-Google-Smtp-Source: APXvYqwGHF8SOviDjmIlAm3sBx/UJICYFTN0JUbjjt+kVDdcU3qlevilN/YJMigJ9n1iWhRjHMWdYv6IAzfeUzWOrWg= X-Received: by 2002:a6b:e203:: with SMTP id z3mr5875109ioc.23.1562140914892; Wed, 03 Jul 2019 01:01:54 -0700 (PDT) MIME-Version: 1.0 References: <20190703054508.22824-1-tiwei.bie@intel.com> <20190703073314.GA18868@___> <20190703075657.GA20458@___> In-Reply-To: <20190703075657.GA20458@___> From: David Marchand Date: Wed, 3 Jul 2019 10:01:44 +0200 Message-ID: To: Tiwei Bie Cc: dev , "Burakov, Anatoly" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 3, 2019 at 9:58 AM Tiwei Bie wrote: > On Wed, Jul 03, 2019 at 09:36:26AM +0200, David Marchand wrote: > > On Wed, Jul 3, 2019 at 9:35 AM Tiwei Bie wrote: > > > > Hi David, > > > > On Wed, Jul 03, 2019 at 09:02:59AM +0200, David Marchand wrote: > > > Hello, > > > > > > On Wed, Jul 3, 2019 at 7:47 AM Tiwei Bie > wrote: > > > > > > The value 40 used in VFIO_GET_REGION_ADDR() is a private value > > > (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It > > > is not part of VFIO API, and we should not depend on it. > > > > > > [1] > https://github.com/torvalds/linux/blob/6fbc7275c7a9/drivers/vfio/ > > pci/ > > > vfio_pci_private.h#L19 > > > > > > > > > > > > I did not follow linux kernel changes, is there something that > would > > change > > > this offset? > > > It looks like a cleanup (did not look into the details yet), do we > need > > this > > > now? > > > > In VFIO/mdev [1], the offset can be something different. It depends > > on the parent device. It's not just a cleanup. It's a preparation > > for the mdev support in DPDK. > > > > [1] https://github.com/torvalds/linux/blob/master/Documentation/ > > vfio-mediated-device.txt > > > > > > > > Ok, thanks. > > So we can wait for mdev to be ready before working on this. > > What do you mean by "mdev to be ready"? RFC ready? I don't see > anything blocking the discussion on this now. > > PS. I already sent a RFC series of the mdev support in DPDK > to the mailing list 3 month ago. > If you need it and the mdev support has been posted already, why not send a n+1 patchset with this patch in it? This patch alone looked odd to me. I want to understand if this is a fix we need now or something that can wait. We have a really large backlog. -- David Marchand