From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DA5743382; Wed, 22 Nov 2023 17:37:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED234410EE; Wed, 22 Nov 2023 17:37:03 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0781C410F9 for ; Wed, 22 Nov 2023 17:37:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700671021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hVmZDM6IQrmuVFXtzMQbALGK3HH6FQBbpkbdrxjslEo=; b=MTtfMZq7rPJka3esGlIS9JyNw+5E9Kcaq2+qt+0DsB/p5oGyC9MRFT7BL22uh5PpLimqNQ WXc2u6FrgwboLLesonWlQ8nA0v92y2R/mKljOvriqhyaN0pSwaEtqQQLuvwuksJR97QetG PcKLiq/ltS0AlnnIIXkuFKkfK3/V3t0= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-133-Eq_-_dq1NfeZAdJkgkgh9w-1; Wed, 22 Nov 2023 11:36:58 -0500 X-MC-Unique: Eq_-_dq1NfeZAdJkgkgh9w-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c871ce22cbso45036361fa.1 for ; Wed, 22 Nov 2023 08:36:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700671016; x=1701275816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hVmZDM6IQrmuVFXtzMQbALGK3HH6FQBbpkbdrxjslEo=; b=N9zHZhXoxgxcNZ4I+t05o2L1dq8Gal0e9tgN3U0WlTIN6nhMTknU9vQs2A+iXu+diK wp+z2RPv8b8LS4wbFJUgcldNA6TApro882kO7jzh/TAD59fQSnCgIqowutKj1RlBjMsY 7HrzeN0Hy1+vhw0BqNh1CPTkczJCp1kQsQg0sFSMywXQLwk4XBvIdHsoMszpDFEFwSQi sjYnXza3nfHMbUQtnabRAPSyKyihtTRcoILIehWxxzJUvQjBcF3u56WtI6QwqiAP6pZn QmcN435n9i4MSMI2F4zIgTTUSYBYp3d/bjEZB7VBCzZOuVtGIZzVlx4LtuVTrhXZEUKu hZ+A== X-Gm-Message-State: AOJu0YxZEf8dLZ+bVjmxpR/aen12wk0L7a9cHmoWnh+L3JvdW0gTqVdw bC1OElDblXLdOL+zH5CtT3hS9vgt9vbnnKVyhbQ507EKXWxtkpD/B66ciTZupMyx07xidtSII+1 8FGWhbjzL5YAbjD8Nnbc= X-Received: by 2002:a2e:960e:0:b0:2c5:18ed:1802 with SMTP id v14-20020a2e960e000000b002c518ed1802mr1686568ljh.34.1700671016808; Wed, 22 Nov 2023 08:36:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTDoBYHQZLhzH6vIzG7G8tcCKdD4ANz6WEEB12NLuFZYAlKC10WTffLo2Hk11mkcBltk2239EbwYqP1vqoLc0= X-Received: by 2002:a2e:960e:0:b0:2c5:18ed:1802 with SMTP id v14-20020a2e960e000000b002c518ed1802mr1686555ljh.34.1700671016515; Wed, 22 Nov 2023 08:36:56 -0800 (PST) MIME-Version: 1.0 References: <20231122163228.986037-1-bruce.richardson@intel.com> In-Reply-To: <20231122163228.986037-1-bruce.richardson@intel.com> From: David Marchand Date: Wed, 22 Nov 2023 17:36:44 +0100 Message-ID: Subject: Re: [PATCH] eal/windows: fix mingw build To: Bruce Richardson Cc: dev@dpdk.org, Tyler Retzlaff , dmitry.kozliuk@gmail.com, stable@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 22, 2023 at 5:32=E2=80=AFPM Bruce Richardson wrote: > > When compiling with mingw on Ubuntu 23.10, I get the following compiler > error: > > ../../lib/eal/windows/eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" r= edefined [-Werror] > 77 | #define MEM_REPLACE_PLACEHOLDER 0x00004000 > | > In file included from /usr/share/mingw-w64/include/minwindef.h:163, > from /usr/share/mingw-w64/include/windef.h:9, > from /usr/share/mingw-w64/include/windows.h:69, > from ../../lib/eal/windows/include/rte_windows.h:32, > from ../../lib/eal/windows/include/rte_os_shim.h:9, > from ../../lib/eal/common/eal_internal_cfg.h:14, > from ../../lib/eal/windows/eal_memory.c:11: > /usr/share/mingw-w64/include/winnt.h:5710: note: this is the location of = the previous definition > 5710 | #define MEM_REPLACE_PLACEHOLDER 0x4000 > > and a similar error for MEM_RESERVE_PLACEHOLDER. These errors can be > fixed by wrapping the two defines in #ifndef .. #endif blocks. > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > Cc: dmitry.kozliuk@gmail.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson Probably a duplicate of https://patchwork.dpdk.org/project/dpdk/patch/20231114170529.176665-1-getel= son@nvidia.com/ --=20 David Marchand