From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9275BA0A02; Wed, 24 Mar 2021 21:31:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 171CF141026; Wed, 24 Mar 2021 21:31:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7683A141025 for ; Wed, 24 Mar 2021 21:31:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616617896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=88lgxYc4jQOctQOQclGorww/Ny8hKqch2Kc7xVzVAgA=; b=X5aGFcdRMFBmQS9kFHwzz+lGjjuQ9ol9dfyko+zbtS552cstZtyTQtdVNp9wgPvKrWU+xu 5+mP1pN1+3hYQRNZGUEXSQSR5qFeL1kU4/Q0vIJQa01R3KuvJOD4yFCMWi5ssNHo670Y/b rHSGU/kWXFBObjStk3Ukl/W8+RsVDQ4= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-kJat67IWNgyI17dMBMllng-1; Wed, 24 Mar 2021 16:31:34 -0400 X-MC-Unique: kJat67IWNgyI17dMBMllng-1 Received: by mail-lj1-f200.google.com with SMTP id h20so1765140lji.21 for ; Wed, 24 Mar 2021 13:31:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=88lgxYc4jQOctQOQclGorww/Ny8hKqch2Kc7xVzVAgA=; b=DRgFlmRpKTybngO9YcXjvzGx0nKsRY1M0vTtAXxfPWl7Cidw2qRXnlAnJXe28cWONA 3YLZWlq1XZFW/zQZsPGdnKyn+hcly2gayIEYzfWhUkiTDOaYvi55v+cKc8CO/LnaTmmG jQBNYH93SHoFcD5YxDMjNGe8iNpc97+V5UIsUze+fkDKFyVQmquSi/8AwWlx2j+g092C PiEfNpW16br8mQvyqc0tmB9f5/o49roK9KskxDRpdwfRQD9iz7kz9QoR8LHvBCJ0JmWt FxBqUhVCPe4lfCy5u1TwbBmUe/t/Ens2EhO2c700neN2kaQbm1cmTl9TGZTFMlcTmD8p ohHQ== X-Gm-Message-State: AOAM531lFduWrXmW+//sbd4mrZH+ZVVGTGM/EhmHrOil8V5YAFrsquD4 PtXtAHms9cD+fbiqh/H1pMF//J8DNdVSZjrO+/bpHaNu1IIpEENkh/zV70rzTuZTqslD2mTqy7Q xj57oJIqmFEmsUZSuA10= X-Received: by 2002:a05:6512:3390:: with SMTP id h16mr2965237lfg.479.1616617892667; Wed, 24 Mar 2021 13:31:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/OjUpAgK/R0/iN73dgM4XREEwMRP5odApTzt3Dgrr6lrGsZIIFN2x/UD5jx8V5lVnUFRjrZe6v31RDpXN5FU= X-Received: by 2002:a05:6512:3390:: with SMTP id h16mr2965229lfg.479.1616617892424; Wed, 24 Mar 2021 13:31:32 -0700 (PDT) MIME-Version: 1.0 References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210323110749.2306452-1-qi.z.zhang@intel.com> <20210323110749.2306452-9-qi.z.zhang@intel.com> <536d43c2-bb7b-7a0e-1ea7-a1fa4c4d7422@intel.com> In-Reply-To: <536d43c2-bb7b-7a0e-1ea7-a1fa4c4d7422@intel.com> From: David Marchand Date: Wed, 24 Mar 2021 21:31:21 +0100 Message-ID: To: Ferruh Yigit Cc: Qi Zhang , dev , Thomas Monjalon , Bruce Richardson , Xiao Wang , Jingjing Wu , Beilei Xing , Jeff Guo , Qiming Yang , "Wang, Haiyue" , "Chen, Zhaoyan" , Aaron Conole Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 8/8] net/igc: refine debug build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 24, 2021 at 8:27 PM Ferruh Yigit wrote: > > On 3/23/2021 11:07 AM, Qi Zhang wrote: > > 1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. > > 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. > > 3. merge RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX > > > > Signed-off-by: Qi Zhang > > CI is reporting a build error [1], I don't reproduce the error and I assume it > is false positive but can you please check it? > > Also cc'ed Zhaoyan & Aaron for the possible CI issue. > > [1] > http://mails.dpdk.org/archives/test-report/2021-March/184153.html > Not sure what gcc+debug target is, but I guess it passes the old config item. The compat stuff should be placed in rte_config.h (or something similar to config/rte_compatibility_defines.h) and not in lib/librte_ethdev/rte_ethdev.h. To reproduce: $ meson configure $HOME/builds/build-gcc-static/ -Dc_args="-DRTE_LIBRTE_ETHDEV_DEBUG=1" $ ./devtools/test-meson-builds.sh ... FAILED: drivers/librte_net_e1000.so.21.2 gcc -o drivers/librte_net_e1000.so.21.2 drivers/librte_net_e1000.so.21.2.p/meson-generated_.._rte_net_e1000.pmd.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_base.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_80003es2lan.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_82540.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_82541.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_82542.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_82543.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_82571.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_82575.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_api.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_i210.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_ich8lan.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_mac.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_manage.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_mbx.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_nvm.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_osdep.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_phy.c.o drivers/net/e1000/base/libe1000_base.a.p/e1000_vf.c.o drivers/libtmp_rte_net_e1000.a.p/net_e1000_e1000_logs.c.o drivers/libtmp_rte_net_e1000.a.p/net_e1000_em_ethdev.c.o drivers/libtmp_rte_net_e1000.a.p/net_e1000_em_rxtx.c.o drivers/libtmp_rte_net_e1000.a.p/net_e1000_igb_ethdev.c.o drivers/libtmp_rte_net_e1000.a.p/net_e1000_igb_flow.c.o drivers/libtmp_rte_net_e1000.a.p/net_e1000_igb_pf.c.o drivers/libtmp_rte_net_e1000.a.p/net_e1000_igb_rxtx.c.o -I/home/dmarchan/intel-ipsec-mb/install/include -L/home/dmarchan/intel-ipsec-mb/install/lib -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_e1000.so.21 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt lib/librte_ethdev.so.21.2 lib/librte_eal.so.21.2 lib/librte_kvargs.so.21.2 lib/librte_telemetry.so.21.2 lib/librte_net.so.21.2 lib/librte_mbuf.so.21.2 lib/librte_mempool.so.21.2 lib/librte_ring.so.21.2 lib/librte_meter.so.21.2 drivers/librte_bus_pci.so.21.2 lib/librte_pci.so.21.2 drivers/librte_bus_vdev.so.21.2 -Wl,--version-script=/home/dmarchan/dpdk/drivers/net/e1000/version.map /usr/lib64/libbsd.so -Wl,--end-group '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home/dmarchan/builds/build-gcc-static/lib -Wl,-rpath-link,/home/dmarchan/builds/build-gcc-static/drivers /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_em_rxtx.c.o: in function `eth_em_xmit_pkts': /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/em_rxtx.c:400: undefined reference to `e1000_logtype_tx' /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_em_rxtx.c.o: in function `rte_prefetch0': /home/dmarchan/builds/build-gcc-static/../../dpdk/lib/librte_eal/x86/include/rte_prefetch.h:17: undefined reference to `e1000_logtype_tx' /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_em_rxtx.c.o: in function `em_xmit_cleanup': /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/em_rxtx.c:314: undefined reference to `e1000_logtype_tx' /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_em_rxtx.c.o: in function `eth_em_recv_pkts': /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/em_rxtx.c:743: undefined reference to `e1000_logtype_rx' /usr/bin/ld: /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/em_rxtx.c:751: undefined reference to `e1000_logtype_rx' /usr/bin/ld: /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/em_rxtx.c:836: undefined reference to `e1000_logtype_rx' /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_em_rxtx.c.o: in function `eth_em_recv_scattered_pkts': /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/em_rxtx.c:923: undefined reference to `e1000_logtype_rx' /usr/bin/ld: /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/em_rxtx.c:931: undefined reference to `e1000_logtype_rx' /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_em_rxtx.c.o:/home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/em_rxtx.c:1081: more undefined references to `e1000_logtype_rx' follow /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_igb_rxtx.c.o: in function `eth_igb_xmit_pkts': /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/igb_rxtx.c:409: undefined reference to `e1000_logtype_tx' /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_igb_rxtx.c.o: in function `rte_prefetch0': /home/dmarchan/builds/build-gcc-static/../../dpdk/lib/librte_eal/x86/include/rte_prefetch.h:17: undefined reference to `e1000_logtype_tx' /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_igb_rxtx.c.o: in function `eth_igb_recv_pkts': /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/igb_rxtx.c:871: undefined reference to `e1000_logtype_rx' /usr/bin/ld: /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/igb_rxtx.c:879: undefined reference to `e1000_logtype_rx' /usr/bin/ld: /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/igb_rxtx.c:974: undefined reference to `e1000_logtype_rx' /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_igb_rxtx.c.o: in function `eth_igb_recv_scattered_pkts': /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/igb_rxtx.c:1062: undefined reference to `e1000_logtype_rx' /usr/bin/ld: /home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/igb_rxtx.c:1070: undefined reference to `e1000_logtype_rx' /usr/bin/ld: drivers/libtmp_rte_net_e1000.a.p/net_e1000_igb_rxtx.c.o:/home/dmarchan/builds/build-gcc-static/../../dpdk/drivers/net/e1000/igb_rxtx.c:1236: more undefined references to `e1000_logtype_rx' follow collect2: error: ld returned 1 exit status [1113/2466] Compiling C object lib/librte_pipeline.a.p/librte_pipeline_rte_table_action.c.o -- David Marchand