From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16670A04B7; Wed, 14 Oct 2020 09:14:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80A5D1DC2B; Wed, 14 Oct 2020 09:14:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 38B3C1DC16 for ; Wed, 14 Oct 2020 09:14:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602659670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JjrrJAF+saWMm+hO+GCLiuo1+tuaPBlGfl6BnmhG6Lo=; b=ZG4njCY4GUL8afHirypB27o/ddwX193yQnXpeHyCXI9lxqknkpZlo5KnnsOl1Ui3FJnK2T HFqC8pXLhALKW/IbRmllyaOJPQFhgyUYPm9GQtSZ+8IMo6lpX3yE0/+BiZuXTXi9BitODb pIn2vvvW/Oe3ENAcaJ8enpHlR23kz/w= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-ukS8_FlrPCeSTx9g3B4pqA-1; Wed, 14 Oct 2020 03:14:26 -0400 X-MC-Unique: ukS8_FlrPCeSTx9g3B4pqA-1 Received: by mail-ua1-f69.google.com with SMTP id 77so308338uac.0 for ; Wed, 14 Oct 2020 00:14:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JjrrJAF+saWMm+hO+GCLiuo1+tuaPBlGfl6BnmhG6Lo=; b=DqEOGGbKoaPO6ZK0dOy5eq66FlkMlxWfkWpkse6McsmfPCW0XJ8PRuKiXl34ihQOgd o7ecfX4TGQ929GLBt9Qm/3cfhxFEOxZ5bn1pSTKDI+rHHkaZDzx10KlHrvmfI5yA6spl HG2kHemKkdSC1AncDcvVGy6jDHRawu93hYVzt2RkzolWcAkmdKwLXqsVhNC/Vw/cNp2u AyBylHdF7YmAePH8mbYm6arO+iFXw3xcNkS6nZD19OaGdsIM3Y4r9YfVYbUOdgIh1kjE VNfqppgmP9Oh3j6WZHCu+Olj9cLOk+asFPIljg0ulbF9J1pp7SSoaTDmEkIQNV/9FxA0 iw0Q== X-Gm-Message-State: AOAM5324TDjnf5MVaF2UM3sHAOUHAOHjpI27N/2UTTxQekGdSU+VIfba TvbuVVJIcQupOltSc1F53vQo4teaXqVq89GYSIpfTzwRSihiZrW6JVHtsBfPvvOn9TYhDgvWcF3 xynuCinMK7JaLzsB0XGU= X-Received: by 2002:a67:e2d5:: with SMTP id i21mr2655329vsm.18.1602659666344; Wed, 14 Oct 2020 00:14:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNINO7DzWff8UnAWmkIDrEaN4/df84f9amkDQEIkVSWP8/6VXMKXh/L6hWaCaXums4qMbIH1mGNVP7hI1dRYg= X-Received: by 2002:a67:e2d5:: with SMTP id i21mr2655324vsm.18.1602659666078; Wed, 14 Oct 2020 00:14:26 -0700 (PDT) MIME-Version: 1.0 References: <1599700614-22809-1-git-send-email-omkar.maslekar@intel.com> <1602497980-20680-1-git-send-email-omkar.maslekar@intel.com> <1602497980-20680-2-git-send-email-omkar.maslekar@intel.com> <20201013162015.GF1496@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201013162015.GF1496@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Wed, 14 Oct 2020 09:14:14 +0200 Message-ID: To: Bruce Richardson , Ruifeng Wang Cc: Omkar Maslekar , "dev@dpdk.org" , "ciara.loftus@intel.com" , "drc@linux.vnet.ibm.com" , "jerinj@marvell.com" , Honnappa Nagarahalli , nd Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6] eal: add cache-line demote support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 13, 2020 at 6:21 PM Bruce Richardson wrote: > > 1. Experimental tag is only needed in this file. Tags at other places can be removed. > > I'm not sure that is the case. The generic file is used when preparing the > docs, so the experimental tag needs to go there for the docs, but when > actually using the function in compiled code the "generic" version is > unused. Therefore we need the experimental tag there to trigger a build > warning about using the function if the appropriate ALLOW_EXPERIMENTAL_APIS > flag is not set. It is enough to put an experimental tag when declaring a symbol. Here, the generic/ header only contains the doxygen part and there is no common declaration: the tag is needed in the arch specific header. -- David Marchand