From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id C56E21B217 for ; Wed, 2 Jan 2019 15:46:17 +0100 (CET) Received: by mail-vs1-f66.google.com with SMTP id n13so18998247vsk.4 for ; Wed, 02 Jan 2019 06:46:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sV7LkkYIBhJGR/6QBU92CFOt1CY7jsa+XctTDpGz6Bg=; b=jzJYCDmHjfZitkvz3N7ASo0/sU4VJQwpqHadOfkl3G9OHh1b1DV2pJwL2pZ5SMGcca C4eDeWwHtTdEY6zH/fbpo0/VCbc+qvbOvBcE6IVUoXzuaCBn0/fsmxfbhq6EWXWZVJvW yjeZcGylyAtFhidQXc8mo81bXaKkNkdr5bGQ5N8LkTpUUghthPUgR4kYfNUYY/wUOkMI CxDx5/6Ia79O7HGCYm16cbUWWGDSfZPpmlix3o0g0TDDQS7tggUyPd4u1ILCd5osrWFq 7+KtxS/BX3BJmfSzfpsdHBqhPY/HciEB0DGOR30B7QidQqbpzVQ9rsFKLl37vmPV5gbd DR5Q== X-Gm-Message-State: AJcUukd4hBzG7ZsrT02qg2X1HJIf2+mJdokDajwlla/YUflH80YXNhzo hPcYT7X36wLaGR4pGKTf5WY+qd+U5E3vZUql3FfogA== X-Google-Smtp-Source: AFSGD/VltIYfqvFdcVRYE5ZgA92PNCcrFt0dYNO15Dpu1BaEs/NhY2Wy7tuq5zT+tWV2saldoWlhvqmxGCXBa3Vd5JE= X-Received: by 2002:a67:c48a:: with SMTP id d10mr17854889vsk.105.1546440377179; Wed, 02 Jan 2019 06:46:17 -0800 (PST) MIME-Version: 1.0 References: <1544773540-89825-1-git-send-email-jia.guo@intel.com> <1544773540-89825-2-git-send-email-jia.guo@intel.com> <567955b0-b4c3-4926-bb8f-c99f6ff5c338@intel.com> In-Reply-To: <567955b0-b4c3-4926-bb8f-c99f6ff5c338@intel.com> From: David Marchand Date: Wed, 2 Jan 2019 15:46:06 +0100 Message-ID: To: Jeff Guo Cc: bernard.iremonger@intel.com, Wenzhuo Lu , shahafs@mellanox.com, Thomas Monjalon , matan@mellanox.com, "Yigit, Ferruh" , konstantin.ananyev@intel.com, dev@dpdk.org, stephen@networkplumber.org, Gaetan Rivet , qi.z.zhang@intel.com, arybchenko@solarflare.com, bruce.richardson@intel.com, shaopeng.he@intel.com, "Burakov, Anatoly" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 14:46:18 -0000 Hello Jeff, On Sat, Dec 29, 2018 at 5:06 AM Jeff Guo wrote: > On 12/17/2018 6:15 PM, David Marchand wrote: > > > On Fri, Dec 14, 2018 at 8:41 AM Jeff Guo wrote: > >> This command-line option will enable hotplug event detecting and enable >> hotplug handling for device hotplug. >> >> Signed-off-by: Jeff Guo >> > > Is there a reason why we would want this disabled by default and enabled > via option ? > > > Before i can give you an answer, let's see what will bring on if enable > it. > > When enable the hotplug will means that it will bring a new netlink socket > communication > > and a sigbus detecting and specific processing. So if user not want to add > this work load, just > > let it to be optional. Do you agree with that? If not please show what is > your concern. Thanks. > If the user does nothing about the sigbus signal handling but the eal signal handler was not registered, the dpdk app will end up being terminated by the kernel. If the user wants to do its own things and don't want the eal to mess with it... I am under the impression that he can disable the eal sigbus handler by calling rte_dev_hotplug_handle_disable(). The netlink stuff is handled in the interrupt thread, no impact on the processing threads and no additional thread afaics. -- David Marchand