From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBE3E45E2B; Wed, 4 Dec 2024 08:56:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92F2840648; Wed, 4 Dec 2024 08:56:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 86BD040261 for ; Wed, 4 Dec 2024 08:56:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733299010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wMeXB3YVTkTqW/26xVb/4d0yOXDZ6TSGrhGFgNr4HgI=; b=dvjFEx2pC1tF6eQkTJOvgIGhDY3CiIvnZQj+o7h0xHBYKn2HrO0ViRkhMx81KX+Vq/PTxf VDN0dW82+7eeu8S69G/k+gLMWr157h0UmvLebEx4c6IeKqA2sFSXFOX8lcB9PFQoisXxnE ZdNWznhecRWiSAHcXiLTLiXHutyd5dg= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-2hdPBTAmNF6kVjR0K40ang-1; Wed, 04 Dec 2024 02:56:49 -0500 X-MC-Unique: 2hdPBTAmNF6kVjR0K40ang-1 X-Mimecast-MFC-AGG-ID: 2hdPBTAmNF6kVjR0K40ang Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ffc1b7abf5so33537241fa.2 for ; Tue, 03 Dec 2024 23:56:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733299007; x=1733903807; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wMeXB3YVTkTqW/26xVb/4d0yOXDZ6TSGrhGFgNr4HgI=; b=geC5r4sbKwnOXjD5RjIR3GetIiloqF5bfORmSXsU1ASkyQ8NliTXUlz9z1qazgm/LJ zLaFxEFTMxc7N4M6xBHm5cwW0yPAPb+00wKKrdeDwbiq0oi3iHJA/oei7tKF2EbYY8mQ PmTq1+hgMwdCxMyuZ6o2z/NnpvUO43qyyxOHzov2mOG/zqMKpML8TAfNs4GJL1xxIDAn M8hpot6IiZ4EXJVmK61IuHFpkrTSSuB3NoizpCMZVrjF5wqCIwmVFRTHdVH1THO30nu/ Ggo0ASmsnnPWqZbfSUWdbYz5iZULR0OKtgMUPNgblq6uRFlk0tK7mK6yPT/0cdxQpLy+ TnfQ== X-Forwarded-Encrypted: i=1; AJvYcCVuwwOq7EDpatQg0sFMLgP/g1cyGWjUYE3P99T1/vcS71tmEjk/d91e0iyq9eANVV8oJqE=@dpdk.org X-Gm-Message-State: AOJu0YzeoSakMlymfpvxFhUUP75+MpyatnId11hCTARSSp0/muh3ubyx Td0lzNeV5Kd/bOKWSHNERMmjEccUPAVlh3Xq8V+ScNnjhtxiq+F30QkPC0wAPesqEvOwxvs7jJL 5CNxVEtylrFlYpXaIrcP1Vox07drfQ5L8Lih6KnUCXagwc2sh8etYG4ejvvls+u5mXgiso8zEwh 4TmCO9UqgR8jjieDI= X-Gm-Gg: ASbGncvzIZhpTNVqEThYTaE9GHCTwnuI+paETSVEOkBCc4raGsmVL7rkkluyT68xj21 uvLW6Muw9IsHDBb0qmXzMGad3EQnCwJAZMA== X-Received: by 2002:a05:651c:1510:b0:2ff:58e5:af0f with SMTP id 38308e7fff4ca-30014e241d0mr12323891fa.19.1733299007439; Tue, 03 Dec 2024 23:56:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHXZPxgseyIINOR3bKTsh+0UiYP6c0OCRMaWvNZUKEby6okYUPoWloLp1/iyhwFHgbYu96ESjIctnWCMZ51NOA= X-Received: by 2002:a05:651c:1510:b0:2ff:58e5:af0f with SMTP id 38308e7fff4ca-30014e241d0mr12323791fa.19.1733299007055; Tue, 03 Dec 2024 23:56:47 -0800 (PST) MIME-Version: 1.0 References: <1733278801-19296-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1733278801-19296-1-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Wed, 4 Dec 2024 08:56:35 +0100 Message-ID: Subject: Re: [PATCH] lib/lpm: use standard atomic_store_explicit To: Andre Muezerie Cc: Bruce Richardson , Vladimir Medvedkin , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Nan7uzg9-5aD8_Z245GXqW40KtClTE0tl5xAqqOSt74_1733299007 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Andre, On Wed, Dec 4, 2024 at 3:20=E2=80=AFAM Andre Muezerie wrote: > > MSVC issues the warning below: > > ../lib/lpm/rte_lpm.c(297): warning C4013 > '__atomic_store' undefined; assuming extern returning int > ../lib/lpm/rte_lpm.c(298): error C2065: > '__ATOMIC_RELAXED': undeclared identifier > > The fix is to use standard atomic_store_explicit() instead of > gcc specific __atomic_store(). > atomic_store_explicit() was already being used in other parts > of DPDK and is compatible > with many compilers, including MSVC. > > Signed-off-by: Andre Muezerie With this change, is there anything remaining that blocks this library compilation with MSVC? If not, please update meson.build so that CI can test lpm compilation with MSVC on this patch (and that will detect regressions once merged). --=20 David Marchand