From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com
 [209.85.222.47]) by dpdk.org (Postfix) with ESMTP id D2BB749E0
 for <dev@dpdk.org>; Mon, 11 Mar 2019 19:09:18 +0100 (CET)
Received: by mail-ua1-f47.google.com with SMTP id q17so1855851uam.0
 for <dev@dpdk.org>; Mon, 11 Mar 2019 11:09:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=lFVUtiEPJEeeY8Fg95MjKhgnu00TxixodL2EdxfMheY=;
 b=dvRVh6czm08TubW7AEOAZrPfNq+0Koy698fSqcOCFSVha53yjT09894rBe4mcFELTV
 EwUB1wMRYAyeWCf2b/BN8t7wdy2I+pYbejDDfVoXAX0zl3cbLUwRNfVTLO0LzPObKYXl
 6P28/PtPMrVHzzUewz0ThoH9d0g5UMOwNel/mt92wfg4JQkSRoE/rVMwwqfsR98L/yIi
 uvpQRbuj4rJrelCjaok2FRY5dZE2PrTDTrAh2DrKrJ7O+49ennApcGPi5NRwgfp5CmsB
 wbHjkkfHoNa6Ucqf6TbjT2JbXcb1LYIyw4UmLegg/acbf9wWsmE6LA7DxdipLMXytBOl
 yEnw==
X-Gm-Message-State: APjAAAVOJl4FNbs6qMvKfDaGyy9Fq12VykKKCI9GKZjuS6rzppks7hR1
 ldE0XtmovaJ+iEB1XJfwHvPC12mQmFsnmGRPjvgdEg==
X-Google-Smtp-Source: APXvYqwFRVuBXJ/N1qiMX3+WDetyiukMOQJX1FAgb8+JGkNhsizJXuEBL+OA8SFpRlF3zcwHgwXa7nDL+mQCo63VhXY=
X-Received: by 2002:ab0:13ed:: with SMTP id n42mr17459689uae.49.1552327758206; 
 Mon, 11 Mar 2019 11:09:18 -0700 (PDT)
MIME-Version: 1.0
References: <1551698315-2611-1-git-send-email-david.marchand@redhat.com>
 <bcc81491-55f2-f87e-50b1-f4320d4c5ed2@intel.com>
In-Reply-To: <bcc81491-55f2-f87e-50b1-f4320d4c5ed2@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 11 Mar 2019 19:09:07 +0100
Message-ID: <CAJFAV8yUF_cxD6Sg_FP+gg=zaPsQbG2M3rLNvGWfpLVgKkEA+w@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, 
 Andrew Rybchenko <arybchenko@solarflare.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Mar 2019 18:09:19 -0000

On Mon, Mar 11, 2019 at 6:22 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 3/4/2019 11:18 AM, David Marchand wrote:
> > According to the api, the q_errors[] per queue statistic is for reception
> > errors not transmit errors.
> > This is a first cleanup on statistics before looking at oerrors.
> >
>
> Yes, the patchset looks aligned with the API documentation [1].
>
> What can be the solution after cleanup? We can merge this cleanup and
> solution
> next to each-other to not leave a gap?
> 1- Different variables for Rx and Tx errors?
> 2- Combine Rx & Tx into this single variable?
>
> It can be good to find a solution because new PMDs doing same mistake
> because of
> copy/paste...
>

Might not be feasible but how about we could introduce an internal stats
structure containing the needed field for tx.
pmd would use it but ethdev would translate it to the current exposed api
rte_eth_dev_stats_get ?
The additional field would be formatted by ethdev to be provided through
the xstats api.


-- 
David Marchand