From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72A10A04AB; Thu, 7 Nov 2019 21:53:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 599DC1BFCB; Thu, 7 Nov 2019 21:53:03 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 047AB1BFC2 for ; Thu, 7 Nov 2019 21:53:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573159981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tRa7tmwSa0L0QpFbdmW08EYKuFziClM61CXUR1QDPPs=; b=Ic3ULoJYdogGMJBcYzgOCgR6Q4+WhfOoRhuTbQyaUI0gp91EEX4aRdD7A21w4MnWa9r7tO 1oVFYU7Fu5HLkcRzVqPgSHR0rZ3qG17iPujPPeZFSwapUbLLmhLqF18Bgib6+75r5lAxET 2ICe/pGZvUu6SG3d3/l+wT7nrtz18Vg= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-79-v32Q8qG1Nx68GpPnowYPHQ-1; Thu, 07 Nov 2019 15:53:00 -0500 Received: by mail-ua1-f72.google.com with SMTP id t2so1331607uap.6 for ; Thu, 07 Nov 2019 12:52:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aJYhpS826G8kCNpRvfFEPJu+L9KPG8LL2ZJFEPJLNws=; b=UvtnaF7iVbRTx+8b3O/O+P11jkVACUHQK+GFoAFalZu4ekFdRi52t/YKVrXGvAJ3Xj qFOrH8Pcd2Zv6T41h111QBs9qLXn8f5tqDZnIK7N9l5iGuPi6foJiO1Iu8VOzi81uZyC 6ClK8Zdmi5BQ6/Sw2CS/2QneuOBuL4eo+N47jhgrLtDGlbOXxGYr3rvH3J80aJSCO0qJ j5gTMwdcXTL+ERsYlUcVdxR9qXCI9I2XA9z2aH1CAuR7yium7MMqXLNoAJLmerU0imGK RlSaXc3Z1CgCVvCwkMqToE14or3dPmApdpznwCrlJeo7uoHwvgziYk+k+nlP6XUDw8fA x3Jg== X-Gm-Message-State: APjAAAWQYi8GGBufusunhKy6cE/buWw4dMyn5jKsS9KL2PlIW9kJNh6Y P152V2fi9Eyfw86I1U4hTsNqpHl3AIah1vGEp/L3WweMC+XzpLlxZ8fZes23Ijm7u9w8a7qRzAR achxMA8Y5BIujBhF7jo8= X-Received: by 2002:a67:fa99:: with SMTP id f25mr4650167vsq.141.1573159979346; Thu, 07 Nov 2019 12:52:59 -0800 (PST) X-Google-Smtp-Source: APXvYqxPLiTkfsz5rwcKX42NZvxRmui3lzhEXZs43cth6aeKrb5SNVq+lwc3jWxf8P23SRUY4ldeFkLUqQe/US0RN40= X-Received: by 2002:a67:fa99:: with SMTP id f25mr4650138vsq.141.1573159978914; Thu, 07 Nov 2019 12:52:58 -0800 (PST) MIME-Version: 1.0 References: <20191105160921.6951-1-stephen@networkplumber.org> In-Reply-To: From: David Marchand Date: Thu, 7 Nov 2019 21:52:47 +0100 Message-ID: To: Stephen Hemminger Cc: "dev@dpdk.org" , Hemant Agrawal , Ferruh Yigit , "stable@dpdk.org" X-MC-Unique: v32Q8qG1Nx68GpPnowYPHQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Stephen, Do we want to fix testpmd? $ git grep 192.*18 origin/master -- app/test-pmd/ origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr =3D (192U << 24) | (18 << 16) | (0 << 8) | 1; origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr =3D (192U << 24) | (18 << 16) | (0 << 8) | 2; Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP paramet= ers") I will take this patch on the example, for now. On Wed, Nov 6, 2019 at 6:36 AM Hemant Agrawal wrot= e: > > > -----Original Message----- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Tuesday, November 5, 2019 9:39 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Ferruh Yigit > > > > Subject: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved > > address range > > > > The original patch used incorrect subnet range for testing. > > > > Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses") > > [Hemant] better to also add Cc: stable@dpdk.org Yes. > Acked-by: Hemant Agrawal Applied, thanks. --=20 David Marchand