From: David Marchand <david.marchand@redhat.com>
To: luca.boccassi@gmail.com
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] net/zxdh: fix building check for arm64
Date: Thu, 4 Sep 2025 16:54:58 +0200 [thread overview]
Message-ID: <CAJFAV8yUUCXX0CmxPmTrUZdMqRb_Ebb0EjvGFxXQeM_QAeyBVQ@mail.gmail.com> (raw)
In-Reply-To: <20250904141854.55944-1-luca.boccassi@gmail.com>
On Thu, 4 Sept 2025 at 16:19, <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <luca.boccassi@gmail.com>
>
> The comment and docs say this should be built on x86_64 and aarch64,
> but RTE_ARCH_64 is not aarch64, that's RTE_ARCH_ARM64, so fix it.
>
> Also the check makes the build skip unless RTE_ARCH_X86_64 is true,
> so switch it to an 'and' instead of an 'or', to build on both arm64
> and x86_64, and skip elsewhere.
>
> Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <luca.boccassi@gmail.com>
Good catch.
It seems we have similar construct in other drivers (and some of them
look buggy, like net/hns3 X and Y or Z without parens).
Could we align all on a single way of checking this combination?
$ git grep -B4 'only supported on x86_64 and aarch64'
drivers/common/sfc_efx/meson.build-endif
drivers/common/sfc_efx/meson.build-
drivers/common/sfc_efx/meson.build-if (arch_subdir != 'x86' and
arch_subdir != 'arm') or (not dpdk_conf.get('RTE_ARCH_64'))
drivers/common/sfc_efx/meson.build- build = false
drivers/common/sfc_efx/meson.build: reason = 'only supported on
x86_64 and aarch64'
--
drivers/dma/hisilicon/meson.build-endif
drivers/dma/hisilicon/meson.build-
drivers/dma/hisilicon/meson.build-if (arch_subdir != 'x86' and
arch_subdir != 'arm') or (not dpdk_conf.get('RTE_ARCH_64'))
drivers/dma/hisilicon/meson.build- build = false
drivers/dma/hisilicon/meson.build: reason = 'only supported on
x86_64 and aarch64'
--
drivers/net/hns3/meson.build-endif
drivers/net/hns3/meson.build-
drivers/net/hns3/meson.build-if arch_subdir != 'x86' and arch_subdir
!= 'arm' or not dpdk_conf.get('RTE_ARCH_64')
drivers/net/hns3/meson.build- build = false
drivers/net/hns3/meson.build: reason = 'only supported on x86_64 and aarch64'
--
drivers/net/sfc/meson.build-endif
drivers/net/sfc/meson.build-
drivers/net/sfc/meson.build-if (arch_subdir != 'x86' and arch_subdir
!= 'arm') or (not dpdk_conf.get('RTE_ARCH_64'))
drivers/net/sfc/meson.build- build = false
drivers/net/sfc/meson.build: reason = 'only supported on x86_64 and aarch64'
--
drivers/net/zxdh/meson.build-endif
drivers/net/zxdh/meson.build-
drivers/net/zxdh/meson.build-if not dpdk_conf.has('RTE_ARCH_X86_64')
or not dpdk_conf.get('RTE_ARCH_64')
drivers/net/zxdh/meson.build- build = false
drivers/net/zxdh/meson.build: reason = 'only supported on x86_64 and aarch64'
--
drivers/vdpa/sfc/meson.build-if ((arch_subdir != 'x86' or not
dpdk_conf.get('RTE_ARCH_64')) and
drivers/vdpa/sfc/meson.build- (arch_subdir != 'arm' or not
drivers/vdpa/sfc/meson.build-
host_machine.cpu_family().startswith('aarch64')))
drivers/vdpa/sfc/meson.build- build = false
drivers/vdpa/sfc/meson.build: reason = 'only supported on x86_64 and aarch64'
--
David Marchand
prev parent reply other threads:[~2025-09-04 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 14:10 [PATCH] " luca.boccassi
2025-09-04 14:18 ` [PATCH v2] " luca.boccassi
2025-09-04 14:54 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yUUCXX0CmxPmTrUZdMqRb_Ebb0EjvGFxXQeM_QAeyBVQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=luca.boccassi@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).