From: David Marchand <david.marchand@redhat.com>
To: "Power, Ciara" <ciara.power@intel.com>
Cc: dev <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] raw/ioat: enable xstats reset for ioat device
Date: Tue, 29 Oct 2019 13:03:31 +0100 [thread overview]
Message-ID: <CAJFAV8yUXz6deGLC2m=60C54kB6vimKF+A6_6hSMAmWAO5PQxA@mail.gmail.com> (raw)
In-Reply-To: <BY5PR11MB43082BDB22A45255AA86521DE6610@BY5PR11MB4308.namprd11.prod.outlook.com>
On Tue, Oct 29, 2019 at 12:52 PM Power, Ciara <ciara.power@intel.com> wrote:
> > This patch conflicts with the other series on this driver.
> > Is it really necessary to reset those statistics once the device has been
> > stopped?
> >> It is a necessary change because stopping the device does not reset the stats, which will result in them accumulating if the test is run multiple times.
> Resetting the stats after stopping the device solves this problem.
Ok, if this is intended.
> I can rebase onto master to resolve the conflict, and send a new version for this patch if it helps.
Yes please.
--
David Marchand
next prev parent reply other threads:[~2019-10-29 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 13:16 Ciara Power
2019-10-16 13:36 ` Bruce Richardson
2019-10-27 13:26 ` David Marchand
2019-10-29 11:52 ` Power, Ciara
2019-10-29 12:03 ` David Marchand [this message]
2019-10-29 13:41 ` [dpdk-dev] [PATCH v2] " Ciara Power
2019-10-30 8:58 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yUXz6deGLC2m=60C54kB6vimKF+A6_6hSMAmWAO5PQxA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).