From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E1F8A00BE; Tue, 29 Oct 2019 13:03:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BFEE1BEC9; Tue, 29 Oct 2019 13:03:51 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id E12DB1BEC1 for ; Tue, 29 Oct 2019 13:03:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572350627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t58BSywyeyxHpPnm6o7QcKvtFz301hx/yYAGX6pIHc8=; b=UtWz32WuF6vlyVEWJg60EOtu/IFsQJhqp3ZcLBkv0oVx0IU6Q1ahhXzUEYNpaV60spBB2l SZMSOhL5vBPFSddjaU/T4TcBGkjuhm6pHRcwA4DIZUsDFb8EREw68spXJVg0k8FaJZJG41 +CLz4itXekHbXfnDViBkjwKZWtS0aPU= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-ZlmjtT2hMZ20mVaSI_rh_Q-1; Tue, 29 Oct 2019 08:03:46 -0400 Received: by mail-vk1-f200.google.com with SMTP id i207so4953135vke.21 for ; Tue, 29 Oct 2019 05:03:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ak4KGKOFG8eNf3Hjie8qJLBurYDpo0HZms/2H17uGXI=; b=NmsFbEruAVAv7t7hZgXByWIANMAPVx/xPIZ5JoPVrqHyRjgaUt2muq8UEyNO0foy3L iMI8ZKXwQ9bP1ZQALwp46wuhL91H/8cJuSyT4bWVjkf4mAtrbe1p9QaMhsANt2NPG/14 Ht2h7oKWZmGqCYA8Y3MHJJsxjUdmy6qYMVen7hV3aRsqxM8E2TVw99+MHuJIM0nt83p5 1zLCvCpKbMPYZZPENPKUC86g5+ueEiIia1eEZML/1gAC60j+EAXQXBshtmICZv6oWTvE nkVXe6DP2vJ5oQBCx1BhhtXsMfJCWiQC1wkFukaBE735LgJi9wjaPceo2y0x0WSdQvih 9Vhw== X-Gm-Message-State: APjAAAVv51MttK+3SbiOt+iTID7jf+uV0ZDmXaQYegMp2MxuyASE6XvG eYkO62QbwH7UOUfYxYzOv2LhUraOjuWO233ifgLysFVN0rD4AWxI7KZGOL8jmIk6gvNv0kLMauj l8x0fo2arz1wdjo/kb4E= X-Received: by 2002:a05:6102:531:: with SMTP id m17mr1444084vsa.105.1572350625479; Tue, 29 Oct 2019 05:03:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtNvsczMIw+FMve2/NOVM7C2kVHmMcZqXxTcGNn1+maelegM6wOQsXS9OmQdO5NaUawiYRAxyVEzpC0AnJQoA= X-Received: by 2002:a05:6102:531:: with SMTP id m17mr1444050vsa.105.1572350625111; Tue, 29 Oct 2019 05:03:45 -0700 (PDT) MIME-Version: 1.0 References: <20191016131626.63781-1-ciara.power@intel.com> <20191016133615.GD720@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: From: David Marchand Date: Tue, 29 Oct 2019 13:03:31 +0100 Message-ID: To: "Power, Ciara" Cc: dev , "Richardson, Bruce" X-MC-Unique: ZlmjtT2hMZ20mVaSI_rh_Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] raw/ioat: enable xstats reset for ioat device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 29, 2019 at 12:52 PM Power, Ciara wrote= : > > This patch conflicts with the other series on this driver. > > Is it really necessary to reset those statistics once the device has be= en > > stopped? > >> It is a necessary change because stopping the device does not reset th= e stats, which will result in them accumulating if the test is run multiple= times. > Resetting the stats after stopping the device solves this problem. Ok, if this is intended. > I can rebase onto master to resolve the conflict, and send a new version = for this patch if it helps. Yes please. --=20 David Marchand