From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA40642D8D; Thu, 29 Jun 2023 17:40:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6794540EDB; Thu, 29 Jun 2023 17:40:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E2519406B7 for ; Thu, 29 Jun 2023 17:40:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688053224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gl99DweYC7HtVSpWSAGPgiF/TLVmhYYQcwyGRsO1m+I=; b=Pci1XodxY9G38v+p2uPTDi5J4HbtyKAGG2CTEzPpksBYlKmfwvZSLxOGmg6tUxndcMQKXe 9prm15Dn+F3xvAVsON3iGxKF5MVLujROIh/eT3BkQe4tVBYrAqndNtXzSUf0F7m1o4KkcR WuS5qn6k+SsG7bO9zY7Tq2IoAdvNh3E= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-kkyOpouHMFi_nBEGBjnO1g-1; Thu, 29 Jun 2023 11:40:19 -0400 X-MC-Unique: kkyOpouHMFi_nBEGBjnO1g-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-26337f5d2daso645889a91.0 for ; Thu, 29 Jun 2023 08:40:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688053218; x=1690645218; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gl99DweYC7HtVSpWSAGPgiF/TLVmhYYQcwyGRsO1m+I=; b=XnuW6Nv6oQlo2y+y7wgm96FlMOnAmIhEUtzbAZdnp3wJEVBNhF92qBjx5OlcqYHM+L 47wFexq1CqbllGFlXHeRp/9ZcGDGQYpx1HGOPgRvo0vm7sN3XgEdsvsJ+6ylMT4bgK90 IBRnV4oyx8q4/rubdNnhNGE8eNENpc12xgKujlyn6USm2y/4OulwLFWR0+Iv23atdomw yb8IfUSEV/OCmifXIt+qr9O8fiyZxUXnDRKfM1neJ5GLMnXQcT9oULTW6O8XC8k3FQYt lT3OfW+ShuJmOXVRObaHnAVtE6LAHsosLR6FDkaGtAaOWsP6nQ0QY1OV7oKdgbdesZ9d om5Q== X-Gm-Message-State: AC+VfDzGxdW0wz7Fwc4eZ7JATgxRKnm1r7YXBi78JPLJJ/+Dfz1YCU+0 bpCXjsj4XtA2lie6VIfO35PsboZx2EmctM7YkjnEbkAlRTwj7xhG4tY0FzPLwd0Qip6BjM+VST1 CK/GrXGbJ4ltRXpDmW4Q= X-Received: by 2002:a17:90a:550:b0:258:b651:4f80 with SMTP id h16-20020a17090a055000b00258b6514f80mr36075820pjf.36.1688053218692; Thu, 29 Jun 2023 08:40:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6AJj0goGojMv9rgHYHD4NKAd9PPSZap/sC2VRclAshF8ViEPq2kJ6dHDvR1ldjK14iKm944ODTZiGDdwqyOfY= X-Received: by 2002:a17:90a:550:b0:258:b651:4f80 with SMTP id h16-20020a17090a055000b00258b6514f80mr36075808pjf.36.1688053218425; Thu, 29 Jun 2023 08:40:18 -0700 (PDT) MIME-Version: 1.0 References: <20230629135839.974700-1-david.marchand@redhat.com> <4981207.a9HWlOh95j@thomas> In-Reply-To: <4981207.a9HWlOh95j@thomas> From: David Marchand Date: Thu, 29 Jun 2023 17:40:07 +0200 Message-ID: Subject: Re: [PATCH] ethdev: fix Tx queue mask endianness To: Thomas Monjalon Cc: Ferruh Yigit , Kiran Kumar K , dev@dpdk.org, Ori Kam , Andrew Rybchenko X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 29, 2023 at 5:31=E2=80=AFPM Thomas Monjalon wrote: > > 29/06/2023 15:58, David Marchand: > > Even if harmless, this endianness tag is incorrect as the tx_queue fiel= d > > is declared as a host integer. > > Additionally, this breaks OVS compilation with sparse. > > > > Fixes: 41f6bdc7615a ("ethdev: add Tx queue flow matching item") > > > > Signed-off-by: David Marchand > > --- > > lib/ethdev/rte_flow.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > > index 3fe57140f9..86ed98c562 100644 > > --- a/lib/ethdev/rte_flow.h > > +++ b/lib/ethdev/rte_flow.h > > @@ -2307,7 +2307,7 @@ struct rte_flow_item_tx_queue { > > /** Default mask for RTE_FLOW_ITEM_TX_QUEUE. */ > > #ifndef __cplusplus > > static const struct rte_flow_item_tx_queue rte_flow_item_tx_queue_mask= =3D { > > - .tx_queue =3D RTE_BE16(0xffff), > > + .tx_queue =3D 0xffff, > > As I said in an earlier comment about the same issue, > UINT16_MAX would be better. I don't mind updating (or maybe Ferruh can squash this directly ?) but there are lots of uint16_t fields initialised with 0xffff in this same file. --=20 David Marchand