From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 892CCA0C49; Thu, 8 Jul 2021 09:53:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5263A4069C; Thu, 8 Jul 2021 09:53:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CF3FC40687 for ; Thu, 8 Jul 2021 09:53:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625730786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eRgZ72HVgtgoA/ihTMhl4gHnXSEGO/APjv/BmrMoQxU=; b=gfPW1vnehcVBKvplufyndAzNTnnJ6tnK8a2BxKfflwruTwKVR4n8eu/uy5euNYmDoWwaUw eaGW2wVZh+v0pHZ3TDkmjXxKwhIOIuTl7ZxKu5daMRZwOzAPGzfOWjVr0iZUJqccRg3AVJ ecd22WAyttCAa1/3XcEojIWSwvivGrQ= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-AN2rgKuBO0eAD9uK37Pydg-1; Thu, 08 Jul 2021 03:53:05 -0400 X-MC-Unique: AN2rgKuBO0eAD9uK37Pydg-1 Received: by mail-oo1-f70.google.com with SMTP id d12-20020a4aeb8c0000b029023bbaaddcbbso3051840ooj.13 for ; Thu, 08 Jul 2021 00:53:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=eRgZ72HVgtgoA/ihTMhl4gHnXSEGO/APjv/BmrMoQxU=; b=JPFz8GZtQrXCAeEDLYzahBQeJHmazJ3bfpg0X2ZHlFPTCQfAINK15KbkiSTCoI0DDE aArNApPyl69sxxVXZ3PErESYX5rDUr0I00pm1Doa5ZN7VZZ1k+YLcx5IBIAVEY31yA8X ML6JoeU/vVAZ/93w4XNeAhYP3kr6bHPb6l7pPwJN6R/mxrl3dcyAmVJbi97/10Nf+OEx hxyon1RTwlVFjpkkbnBa8D1sA4AJFCytqMaA0byZdS4bdMnuF512VjEGgUvq8VWKrcjp rrnwKoXhbEOrguQ8EBSs3BzDf34ws52OU1QleQ7toLhyxBZsvfUpbDY9dwWE1VakiGp5 CSpQ== X-Gm-Message-State: AOAM532aS05+ZKN8GZS3PDEpSOd36a+6TT1jSFTI3eCAGamXRPvi74n0 CdDZW5NmFagBFxWBlzIMtXt+UFkMYpBHOuEBMciE3EV3aFcXhWQDwwtSrSKzuCK7c7vb6il7kcw Bfz14dhn0pB9+QZHnNGk= X-Received: by 2002:ab0:211a:: with SMTP id d26mr28082257ual.41.1625730442597; Thu, 08 Jul 2021 00:47:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykfxW4xqFWpIuDbXMvap391CexhWzeqpongiPbjNtHal0jPhZWizisihcFbuCwV3s2U23LNAwM7CzL/u2588Y= X-Received: by 2002:ab0:211a:: with SMTP id d26mr28082242ual.41.1625730442443; Thu, 08 Jul 2021 00:47:22 -0700 (PDT) MIME-Version: 1.0 References: <20210707193058.1035564-1-gakhil@marvell.com> <2086219.nnIR5hDg31@thomas> <2510837.XPcs1ukvDD@thomas> In-Reply-To: <2510837.XPcs1ukvDD@thomas> From: David Marchand Date: Thu, 8 Jul 2021 09:47:10 +0200 Message-ID: To: Thomas Monjalon Cc: Akhil Goyal , Shijith Thotton , dev , Jerin Jacob Kollanukkaran , Andrew Rybchenko , "Yigit, Ferruh" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [pull-request] next-crypto 21.08 rc1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 8, 2021 at 9:41 AM Thomas Monjalon wrote: > > 07/07/2021 23:57, Thomas Monjalon: > > 07/07/2021 21:30, Akhil Goyal: > > > Shijith Thotton (2): > > > drivers: add octeontx crypto adapter framework > > > drivers: add octeontx crypto adapter data path > > > > It seems there is an ABI breakage: > > > > devtools/check-abi.sh: line 38: 958581 Segmentation fault > > (core dumped) abidiff $ABIDIFF_OPTIONS $dump $dump2 > > Error: ABI issue reported for 'abidiff --suppr devtools/libabigail.abig= nore --no-added-syms --headers-dir1 v21.05/build-gcc-shared/usr/local/inclu= de --headers-dir2 build-gcc-shared/install/usr/local/include v21.05/build-g= cc-shared/dump/librte_crypto_octeontx.dump build-gcc-shared/install/dump/li= brte_crypto_octeontx.dump' > > > > Without this series, the ABI check is passing. > > After updating libabigail, it passes OK. And for the record... - libabigail-1.8.1-1.fc32.x86_64 is fine, - libabigail freshly compiled from current master is fine too > > Note there was another bug, in PPC toolchain this time. > After upgrading to recent PPC toolchain it is OK. - bootlin toolchain powerpc64le-power8--glibc--stable-2018.11-1 stalls when compiling drivers/crypto/cnxk/cn9k_cryptodev_ops.c - bootlin toolchain powerpc64le-power8--glibc--stable-2020.08-1 is fine Plus, if someone wants to upgrade their ppc toolchain, don't forget to regenerate your ABI reference with this toolchain. --=20 David Marchand