From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C9B3A0C4E; Sat, 23 Oct 2021 12:18:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B4EC4069D; Sat, 23 Oct 2021 12:18:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 363B140041 for ; Sat, 23 Oct 2021 12:18:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634984296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=es5NABIBwYkYCyZQVhSgcFN5HREa0UzIz+8yr9/TspM=; b=GN66peYTX69as4ocKQiM7xrSCzbVkOsUTO2/LWDSPtJOijuFoQDBJS6vymhb03wb+WyLV/ yqF0ssXzHIGIAXxTlNX/n8DHhipBiOdNH9mTYGzfom/ihbL5XyFYToYd1oDDepCDGf03bj +NW4OlC3Vir4z9HPVxebyp57DgO++f0= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-CgcYPC-EPT6aCxm2Onls2Q-1; Sat, 23 Oct 2021 06:18:14 -0400 X-MC-Unique: CgcYPC-EPT6aCxm2Onls2Q-1 Received: by mail-lf1-f71.google.com with SMTP id h8-20020a056512220800b003fdf2283e82so3070349lfu.10 for ; Sat, 23 Oct 2021 03:18:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=es5NABIBwYkYCyZQVhSgcFN5HREa0UzIz+8yr9/TspM=; b=XfWNz9ccEvV5ZX7c+P/pLR86eI53pEEOWsZ2toW/lzKEA31+NMtRj8HcjHYABXodgV NCs9Sk9nYtGXoXl7cBXKXUAwJq3VE1+0yl2FeepTvE/COHKe73LF+JGcr2a6BKPBUjFP LUcxoRU2abaV+SgcZj9wVQWqHMWbiZ28LS/q7NeC3Cpb2urZyMLUSBO50Qqi9dseVWQw t+y1TNVwEZ1fmzYeKbLVeMhxpvsd3gJZFeg0znZbT2Z0Fqnof+8OSlF3hNzISXN6sbNc g/JN+2AFoU0+zAFEYc9fOSvaZQcBtZZaTer4EhghcLEqV7fpK2b7LWjPDX0UPev6IqMs xP9g== X-Gm-Message-State: AOAM531Kvgl6heb7ThCwJIWX7JUNnisdlhniLtEGVfTpb7Ag4j1VzUtt AYvoXD4/yPSe/16p8cvenS3ZwuYQj5R8a5z9RRVhV61aK6vFnFKTt53bSP5s70UFIDjBVEXy6Ze wAtz0bcYmrhbCYaMcRFs= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr4922355lfq.553.1634984293444; Sat, 23 Oct 2021 03:18:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrllxlB7afSNimk9bS1ex9a7h9XD/hC0FSsAHvxkEL5IVBKVns5yvB7lMYSTNX1gj5iBG64sr+5QrpjyG6TyI= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr4922342lfq.553.1634984293233; Sat, 23 Oct 2021 03:18:13 -0700 (PDT) MIME-Version: 1.0 References: <20211023065558.818-1-david.marchand@redhat.com> In-Reply-To: <20211023065558.818-1-david.marchand@redhat.com> From: David Marchand Date: Sat, 23 Oct 2021 12:18:02 +0200 Message-ID: To: dev Cc: Thomas Monjalon , Bruce Richardson , Kevin Laatz , Chengwen Feng , Conor Walsh Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] dma/idxd: fix build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 23, 2021 at 8:56 AM David Marchand wrote: > > Windows compilation gives us a splat: > In file included from ../drivers/dma/idxd/idxd_pci.c:10: > In file included from ..\drivers\dma\idxd/idxd_internal.h:11: > ..\drivers\dma\idxd/idxd_hw_defs.h:46:21: error: expected member name or > ';' after declaration specifiers > uint16_t __reserved[13]; > ~~~~~~~~ ^ > 1 error generated. > > Ironically, __reserved is probably a reserved token. > Some drivers that build fine on Windows have structs with a "reserved" > field, let's go with this. > > Fixes: 82147042d062 ("dma/idxd: add datapath structures") > > Signed-off-by: David Marchand Tested via CI@UNH. Applied. -- David Marchand