From: David Marchand <david.marchand@redhat.com>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: "Ferruh Yigit" <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
"Michał Krawczyk" <mk@semihalf.com>,
"Marcin Wojtas" <mw@semihalf.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Evgeny Schemeilin" <evgenys@amazon.com>,
"Igor Chauskin" <igorch@amazon.com>,
"Andrew Rybchenko" <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal: fix rte_memcpy build on ppc with gcc 9.3
Date: Tue, 5 May 2020 18:41:13 +0200 [thread overview]
Message-ID: <CAJFAV8yVo0_KL6W0=Xhjp8f+thg0WLpooM4uHbFRJq1nt5a0yQ@mail.gmail.com> (raw)
In-Reply-To: <8f6efd02-741d-b606-3749-cae90da3be44@linux.vnet.ibm.com>
On Tue, May 5, 2020 at 6:32 PM David Christensen <drc@linux.vnet.ibm.com> wrote:
> >> diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h b/lib/librte_eal/ppc/include/rte_memcpy.h
> >> index 25311ba1d..de47a5d2e 100644
> >> --- a/lib/librte_eal/ppc/include/rte_memcpy.h
> >> +++ b/lib/librte_eal/ppc/include/rte_memcpy.h
> >> @@ -8,8 +8,8 @@
> >>
> >> #include <stdint.h>
> >> #include <string.h>
> >> -/*To include altivec.h, GCC version must >= 4.8 */
> >> -#include <altivec.h>
> >> +#include "rte_altivec.h"
> >> +#include "rte_common.h"
> >
> > I can't find "rte_altivec.h", am I missing something.
> >
> > With just ignoring "-Warray-bounds" changes, I confirm ena build issue is fixed
> > with gcc 9.1
>
> The rte_altivec.h is related to another open patch required to build on
> POWER systems (http://patches.dpdk.org/patch/69605/) that's waiting to
> be accepted. You may not have encountered it if you're not building the
> MLX5 PMD which has additional library requirements.
Is there a point in having two patches?
--
David Marchand
next prev parent reply other threads:[~2020-05-05 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 17:45 [dpdk-dev] [PATCH] " David Christensen
2020-05-04 21:03 ` [dpdk-dev] [PATCH v2] " David Christensen
2020-05-05 10:33 ` Ferruh Yigit
2020-05-05 16:32 ` David Christensen
2020-05-05 16:41 ` David Marchand [this message]
2020-05-05 20:28 ` David Christensen
2020-05-06 9:35 ` David Marchand
2020-05-06 15:59 ` David Christensen
2020-05-05 18:42 ` Ferruh Yigit
2020-05-05 20:37 ` David Christensen
2020-05-06 9:23 ` Ferruh Yigit
2020-05-06 16:13 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yVo0_KL6W0=Xhjp8f+thg0WLpooM4uHbFRJq1nt5a0yQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@intel.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).