From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F34243A35; Thu, 1 Feb 2024 10:36:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D3DB42DE5; Thu, 1 Feb 2024 10:36:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D3F5842DE4 for ; Thu, 1 Feb 2024 10:35:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706780158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A2Phg2skUEk9xapQ/vrLONGvKuTVAeULviXA8vJM8k8=; b=JqfKP62KDBNOqhmyrmq0YlhNNcVo0xPi/b2NZ0WOCgkg+DImLbTN1jGsvovMu5a6kWy20S RmK4lm4Jd0WnjCiB5sfRC4Ozik8sG7lFuAo1ucULS3qMpj9kPPJlNABHT0mb6dtuTtEVpQ QTa5yRZo63YHrLdfiPs4dLNBDKxDIxM= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-M2PSe1AwMJyrMlV9-QzOmw-1; Thu, 01 Feb 2024 04:35:55 -0500 X-MC-Unique: M2PSe1AwMJyrMlV9-QzOmw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2cf4fa65467so8817281fa.1 for ; Thu, 01 Feb 2024 01:35:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706780154; x=1707384954; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A2Phg2skUEk9xapQ/vrLONGvKuTVAeULviXA8vJM8k8=; b=ggFgNnVIVW3sr1BNfuS42qPJaOesO9vQ5PA94t4as5OmSriRzSH4AexiMqYlSy3YHz O54QX5pZcieoghA5SfXQLyIlG/yO/bxkwDDKLwIzW/N4D8T6J7JQAkMWD6OxwOMi47AL eTXwxam/PJVLdxHC5GYaBx0eR6aUaZn9qkr/OHioJiEOtPC5wCyfw/Qb2CeGNe0pFNpZ q3lP07VjHifTzrEAMHXIx/R3TzF3FchDxDFp+fdeU6boi2tloM1e6xi+BVSy+lcttUAQ E1Jd2fAujME8ror8dRK3bC79VwBzbGHB8TkjeiUviPGLAsBl3ztifQtyt9ecrwJnX4kw qJxg== X-Gm-Message-State: AOJu0YwfpBGCODDOt1h5JaW1aM0VoyJkLH5P4QDFpc7VV9Xii4rxwxxb w7TCalDOH+QJxziZcd2LEebhpi21bBvVHwoOuCfR7KUVtAMVlUSe5Ne+1SjTg1mfz5j4NL449tD ybkJhB/ueXgKb7psrH1D5rUw4HSlpuqNWR047L767/rmNtJU/lIPWy/HR+QEAInySAOT+VcuHk9 1rpfu25mlzGavE5jg= X-Received: by 2002:a2e:bc29:0:b0:2d0:4c36:8cba with SMTP id b41-20020a2ebc29000000b002d04c368cbamr3833667ljf.0.1706780153874; Thu, 01 Feb 2024 01:35:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfezLU9uM3QJi2m27tqgSBLrOIfzDp7J2ryAdFz6wxnlJcTXvwry6Rm04hqeij9j52Nwe7QpsOoynLQ44/zRk= X-Received: by 2002:a2e:bc29:0:b0:2d0:4c36:8cba with SMTP id b41-20020a2ebc29000000b002d04c368cbamr3833622ljf.0.1706780153528; Thu, 01 Feb 2024 01:35:53 -0800 (PST) MIME-Version: 1.0 References: <20231218135932.1497163-1-david.marchand@redhat.com> In-Reply-To: <20231218135932.1497163-1-david.marchand@redhat.com> From: David Marchand Date: Thu, 1 Feb 2024 10:35:42 +0100 Message-ID: Subject: Re: [PATCH] drivers: use dedicated logtypes To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, stephen@networkplumber.org, Gagandeep Singh , Hemant Agrawal , Nipun Gupta , Nikhil Agarwal , Sachin Saxena , Anoob Joseph , Jingjing Wu , Beilei Xing , Abdullah Sevincer , Igor Russkikh , Steven Webster , Matt Peters , Ajit Khaparde , Somnath Kotur , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , Apeksha Gupta , Junfeng Guo , Simei Su , Long Li , Vamsi Attunuru , Harman Kalra , Devendra Singh Rawat , Alok Prasad , Maxime Coquelin , Chenbo Xia , Jochen Behrens , Rosen Xu , Tianfei Zhang , Xiao Wang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 18, 2023 at 2:59=E2=80=AFPM David Marchand wrote: > > When a driver dedicated logtype exists, use it instead of the generic > PMD logtype. > > This has been done partially automatically with: > > $ for file in $(git grep -l RTE_LOG.*PMD.*fmt drivers/'**.h' \ > :^drivers/common/cnxk/roc_platform.h) > do > tail=3D${file#drivers/*/*/} > dir=3D${file%%$tail} > ! git grep -q RTE_LOGTYPE_ $dir || \ > { echo $dir already done; continue; } > git grep -hE '^extern int .*log.*;$' $file | \ > sed -ne 's/^extern int \([^ ;]*\);$/\1/p' | \ > while read logtype > do > git grep -q 'RTE_LOG_REGISTER\(_DEFAULT\|\)('$logtype',' || \ > [ "$logtype" !=3D "${logtype%%driver}" ] || \ > { echo Skipped $logtype; continue; } > abbrev=3D$(echo $logtype | sed -e 's/_logtype//' | tr '[a-z]' '[A-Z]'= ) > sed -i -e 's/^\(extern int '$logtype'.*\)$/\1\n#define RTE_LOGTYPE_' = \ > $abbrev' '$logtype'/' $file > sed -i -e 's/\(RTE_LOG.*, \)PMD,/\1'$abbrev',/' $file > break > done > done > > Then a manual update for: > - common/cpt, > - common/dpaax, > - common/idpf, > - mempool/dpaa, > - net/bnxt, > - net/octeon_ep, > - raw/ifpga, > - vdpa/ifc, > > Signed-off-by: David Marchand Rebased and applied, thanks. --=20 David Marchand