From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56FFDA00BE; Thu, 28 May 2020 15:16:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56AE31DBB8; Thu, 28 May 2020 15:16:50 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id DA2241DBB4 for ; Thu, 28 May 2020 15:16:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590671808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=933791R1TfDVc6oe/XZ51T9UBxOjsRrt+MmpkyG6yQY=; b=cMQAVmIy4HrLhQsmceudtDDdV9Az7jq81OAGpa1l9Yiy5iE9Mm9Rr3rNuY+U51SMlmymqf 9cvODheYgXN9wcGjj5AnZRhGEkS8LTMCA3oso9s0/FtE9dbQitQGT3GgEKA7jOhPEZ+Y7S JvI9NhNfyltJjKCLRj8pY4SoS3LTIXM= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-3PZ2WJJPNTqp1bz3zCkRWg-1; Thu, 28 May 2020 09:16:46 -0400 X-MC-Unique: 3PZ2WJJPNTqp1bz3zCkRWg-1 Received: by mail-vk1-f199.google.com with SMTP id t5so10322998vkk.11 for ; Thu, 28 May 2020 06:16:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=933791R1TfDVc6oe/XZ51T9UBxOjsRrt+MmpkyG6yQY=; b=EpnwhpmjFPAiZ0j5i0TXDL2FQ5gIvw3FBbzREjGrCYJ4PQM43kQgQjPsJjMP1+Ya0o tSQMuElw8NmgNt9v9wD+zDqmY7bBsqZNuNyawRbkUTmLvNUR5fONnTrh8KJkFRzYP8wY K7w/cv2SArd79wumpBYvQaj7FkTM7p2YSAUAck0kaNpT7ekdSvFzyiWZ8fS6dxWP3lmv yVq3bwwVhTXV4OF45/ID1zfACyrlxLOJWQ9DyEB9KUI0KXoE3uiH7nuhvkGIKGwy/Dtw BBjVzMx9F3WsUuXuwRWKPBXTHi4lAxAFW1gC9yQd42bLX7yhWKEQnm3Krnov46KBoed4 U3Nw== X-Gm-Message-State: AOAM531j4ziA9IXyRV19uVl9J4qO/UodDH9xw0j35YXK46zvvw67YXRl 8NLhmjfMt45DALafZ0EgrvwaIG1ajCjNXrRqb+czbnatATwAlwBFqHlXCmRbPkUNPVLodkj+AY9 Lgk008kZeBoUIdq+9AYs= X-Received: by 2002:ab0:5bcc:: with SMTP id z12mr1999236uae.41.1590671805698; Thu, 28 May 2020 06:16:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0g6cYJP9YVPqVNG+2c41B6pfoAypc82Szcip0D00efGQiSel8OfwAs/n0BfmnpFHFIUp4YPJ7OMmECDljIYI= X-Received: by 2002:ab0:5bcc:: with SMTP id z12mr1999201uae.41.1590671805221; Thu, 28 May 2020 06:16:45 -0700 (PDT) MIME-Version: 1.0 References: <20200421020455.505176-1-thomas@monjalon.net> <20200524174341.1777973-1-thomas@monjalon.net> In-Reply-To: <20200524174341.1777973-1-thomas@monjalon.net> From: David Marchand Date: Thu, 28 May 2020 15:16:34 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] devtools: remove useless files from ABI reference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, May 24, 2020 at 7:43 PM Thomas Monjalon wrote: > > When building an ABI reference with meson, some static libraries > are built and linked in apps. They are useless and take a lot of space. > Those binaries, and other useless files (examples and doc files) > in the share/ directory, are removed after being installed. > > In order to save time when building the ABI reference, > the examples (which are not installed anyway) are not compiled. > > Signed-off-by: Thomas Monjalon > --- > v2: find static libraries anywhere it tries hiding from being swept > --- > devtools/test-meson-builds.sh | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 18b874fac5..de569a486f 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -140,10 +140,15 @@ build () # > fi > > rm -rf $abirefdir/build > - config $abirefdir/src $abirefdir/build $* > + config $abirefdir/src $abirefdir/build -Dexamples= $* > compile $abirefdir/build > install_target $abirefdir/build $abirefdir/$targetdir > $srcdir/devtools/gen-abi.sh $abirefdir/$targetdir > + > + # save disk space by removing static libs and apps > + find $abirefdir/$targetdir/usr/local -name '*.a' -delete I would prefer -exec rm -f {} as Bruce proposed, because -delete is not posix. But otherwise, it works and looks good to me. > + rm -rf $abirefdir/$targetdir/usr/local/bin > + rm -rf $abirefdir/$targetdir/usr/local/share > fi > > install_target $builds_dir/$targetdir \ > -- > 2.26.2 > With either -delete or -exec rm: Acked-by: David Marchand -- David Marchand