From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E678145AAD; Fri, 4 Oct 2024 13:58:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E83640E5E; Fri, 4 Oct 2024 13:58:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 361E640E5E for ; Fri, 4 Oct 2024 13:58:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728043096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Eb4y1+iAngTyuYJ6OHE34yG6AF43b+Bk7H1fAneT/o=; b=hmVORypVRSJLVtDyZj6O8eHAmU9g2aDyQWTSMcSEJM297RccNlcSBtPX1B9b/1g0KRdYFe pmV1GzK83MsLG8CiMeBMDhkoEHiDWDHWOdJfsHS3x8Mk9JiWXpSymYE3EDESnU0E9gfyEj isXmz+4IjVbeeAvSNy/Ua2YSEqxy9ag= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-284-WA4E-lJpMQqixsImNZCulQ-1; Fri, 04 Oct 2024 07:58:15 -0400 X-MC-Unique: WA4E-lJpMQqixsImNZCulQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-539948bd825so1720209e87.2 for ; Fri, 04 Oct 2024 04:58:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728043094; x=1728647894; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Eb4y1+iAngTyuYJ6OHE34yG6AF43b+Bk7H1fAneT/o=; b=lzmQrJo8/kvNtK8GBW6r78CsswHDySpYSaseR9qQo/bJNoG2mSu6hZEm+3PfCrUXVP wH6MGLPWKSgqfzgTDPnE0OIdANhc7EsMuPvB4uM+DweEnhcZ0KC5wmlp9JeY2Acw79hl HGSw2s45vcMFRke7aJU+zEofosYflHJu5kFgqw9HRYy9W9XOukgErxmwJSS/JXhPe5Gr 0Hgbcuc8Y1BHcxstSImkPehupfjalX+OfKldnepnduhXhvxpaCRIj4wfP0qDdI+vtBvw SPypRfrMcAzjYMSpP2iQqWfilp1s6btUFFRPw1H+k/5JLmj2D5iqrMjw+X3D0ExBToWd D+tA== X-Gm-Message-State: AOJu0Ywm04I8eCuqw9/Lscjy3XaaCnNDxC0girCJ9WvDdgF5I5uyNTWR YG7TeN3NCbdPaOO07IQnqvYTtqZJ1kxytXZwlJPPKS6S2RNagU3Rl6QSpOPc+Nl5q3BX5VUlufm MT9sPMT5uV5xfUXRBxnVHsiIn17jNW1eYym+rrY4PtsYQFmMCUJ9+5UMK2+mkz0FDQxJgOmHm0c tPTfDJjSl7f59UTao= X-Received: by 2002:a05:6512:398d:b0:539:8d9b:b61e with SMTP id 2adb3069b0e04-539ab9de2f1mr1656288e87.44.1728043093717; Fri, 04 Oct 2024 04:58:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHjqq2sM1a0f2WPmIS1tJ0/6Nm47Qw9GbVYnboHL06XJtCFtqik3uOZbomFrfQlGC8JHwzlzbHXhA1BtngXNFY= X-Received: by 2002:a05:6512:398d:b0:539:8d9b:b61e with SMTP id 2adb3069b0e04-539ab9de2f1mr1656269e87.44.1728043093253; Fri, 04 Oct 2024 04:58:13 -0700 (PDT) MIME-Version: 1.0 References: <20240808194756.167664-1-stephen@networkplumber.org> <20240809152540.9568-1-stephen@networkplumber.org> In-Reply-To: <20240809152540.9568-1-stephen@networkplumber.org> From: David Marchand Date: Fri, 4 Oct 2024 13:58:02 +0200 Message-ID: Subject: Re: [PATCH v2 0/3] alarm test fixes To: Stephen Hemminger Cc: dev@dpdk.org, Chengwen Feng X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 9, 2024 at 5:26=E2=80=AFPM Stephen Hemminger wrote: > > This is the set of things which stood out as needing fixing when > looking at the rte_eal_alarm tests. > > v2 - drop cleanup of eal alarm code for later > - add RTE_ATOMIC() to fix clang build > > Stephen Hemminger (3): > eal: add missing parameter check to rte_eal_alarm_set on Windows > test: support alarm test on FreeBSD > test/alarm: rewrite the alarm test > > app/test/test_alarm.c | 85 ++++++++++++++++++++++--------------- > lib/eal/windows/eal_alarm.c | 7 +++ > 2 files changed, 57 insertions(+), 35 deletions(-) Thanks for the cleanup, and reviews. Series applied. --=20 David Marchand