From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0288AA0A0C; Thu, 15 Apr 2021 09:26:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A680E162087; Thu, 15 Apr 2021 09:26:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 6741A162084 for ; Thu, 15 Apr 2021 09:26:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618471614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sLRRhJYF4us+qmebKmTVo0810MJahmv5gByiyYfd0Vw=; b=cMwhyv8liu10uFOTBIeSzjmZPxBkiHtRy2zhEEkCiRC65Ke5u48dwOlkzUb6MPiONEZuAB lzBYwK5QCIX38Nceu3lG/mqj0Z38IcBmJkAv4m5/+B/d7TDsROq0dobx27n/kEJWW/AdPH swfWJ1PIMSBsmPvBOb7YLSGKkkCyPaw= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-VxRhUKqbO-aUaKEQgc84mw-1; Thu, 15 Apr 2021 03:26:51 -0400 X-MC-Unique: VxRhUKqbO-aUaKEQgc84mw-1 Received: by mail-vs1-f72.google.com with SMTP id z7-20020a67ca070000b0290220c083d3acso353821vsk.21 for ; Thu, 15 Apr 2021 00:26:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sLRRhJYF4us+qmebKmTVo0810MJahmv5gByiyYfd0Vw=; b=M/G59Jma4esH7bgImPBs0Lzt96CmEqQG3aB7gLr3g/cYSkpWcodJ2rExmZFLPUuIV9 HHxciMU9RbhBhj2+K8V17R1eCd3XWolWu9oTtGX+M/NnOtoziL1xqqCckP8rP9LSN9r2 uwqST4KiIYtflqlLriyyLNFWa3uLQoIXkMFeOLGP7Uhj7zCHXbXN5ZMHyoGZYmuavvJr HikHsgZp7/gGxQs4SLqCpyWkawaJYIulsDppRrUQxUQ8y3K6UraEiKKN/aXLh3lj98Gx OSV23zPQg+m+rP5bSx8CZG1m42cBJuiltnev0KqlGNMTa+IGHi4jTPB8WVfcZ0+T8ib8 ivHw== X-Gm-Message-State: AOAM530Kahtv22heYLPBaDe4BPw8uo4/K+rzqsxcT0714Lbo11z+3gZh /E8FAIRjRnxtKEgGjH1/1bbZCCHumDrHQwk5dImdKDNT510nI/KZKOOP3c5nd3cpr7bQMbgpyDD m/9I4x+FAXh+V6DL7TLY= X-Received: by 2002:ab0:60d5:: with SMTP id g21mr766195uam.53.1618471610004; Thu, 15 Apr 2021 00:26:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxw7gVx745OvTYuo3T93N87f4uxtIYQga6EJqQF9tSFbJONeszlQtblqiZM+tJUk5vh2N57y7z4KsH6ow9ZeSk= X-Received: by 2002:ab0:60d5:: with SMTP id g21mr766183uam.53.1618471609690; Thu, 15 Apr 2021 00:26:49 -0700 (PDT) MIME-Version: 1.0 References: <20210414122036.1262579-2-gakhil@marvell.com> <20210414180417.1263585-1-gakhil@marvell.com> <20210414180417.1263585-2-gakhil@marvell.com> In-Reply-To: From: David Marchand Date: Thu, 15 Apr 2021 09:26:38 +0200 Message-ID: To: Akhil Goyal Cc: Jerin Jacob Kollanukkaran , Thomas Monjalon , dev , Ray Kinsella , Abhinandan Gujjar , Hemant Agrawal , Nipun Gupta , Sachin Saxena , Anoob Joseph , Matan Azrad , Fan Zhang , Gagandeep Singh , Erik Gabriel Carrillo , "Jayatheerthan, Jay" , Pavan Nikhilesh Bhagavatula , Van Haaren Harry , Shijith Thotton , Dodji Seketeli Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v10 1/4] devtools: add exception for reserved fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 15, 2021 at 7:33 AM Akhil Goyal wrote: > > Hi David, > > > Certain structures are added with reserved fields > > > to address any future enhancements to retain ABI > > > compatibility. > > > However, ABI script will still report error as it > > > is not aware of reserved fields. Hence, adding a > > > generic exception for reserved fields. > > > > > > Signed-off-by: Akhil Goyal > > > --- > > > devtools/libabigail.abignore | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > > > index 6c0b38984..654755314 100644 > > > --- a/devtools/libabigail.abignore > > > +++ b/devtools/libabigail.abignore > > > @@ -19,4 +19,8 @@ > > > ; Ignore fields inserted in cacheline boundary of rte_cryptodev > > > [suppress_type] > > > name = rte_cryptodev > > > - has_data_member_inserted_between = {offset_after(attached), end} > > > \ No newline at end of file > > > + has_data_member_inserted_between = {offset_after(attached), end} > > > + > > > +; Ignore changes in reserved fields > > > +[suppress_variable] > > > + name_regexp = reserved > > Mm, this rule is a bit scary, as it matches anything with "reserved" in it. > > Why do you feel it is scary? Reserved is something which may change at any time > Just like experimental. Hence creating a generic exception rule for it make sense > And it is done intentionally in this patch. The reserved regexp on the name of a variable / struct field is too lax. Anything could be named with reserved in it. If we have clear patterns, they must be preferred, like (untested) name_regexp = ^reserved_(64|ptr)s$ Experimental is different. This is a symbol version tag, which has a clear meaning and can't be used for anything else. > > > > > You need an exception anyway to insert the new fields (like in patch 2). > > Can you test your series dropping this patch 1 ? > It will not work, as there are 2 changes, > 1. addition of ca_enqueue after attached. This is taken care by the exception set in patch 2 > 2. change in the reserved_ptr[4] -> reserved_ptr[3]. For this change we need exception for reserved. In the eventdev struct, reserved fields are all in the range between the attached field and the end of the struct. I pushed your series without patch 1 to a branch of mine, and it passes the check fine: https://github.com/david-marchand/dpdk/commits/crypto_fwd_mode_v10 https://github.com/david-marchand/dpdk/runs/2350324578?check_suite_focus=true#step:15:8549 -- David Marchand