From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86D56A0471 for ; Thu, 15 Aug 2019 08:53:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 979231BEA3; Thu, 15 Aug 2019 08:53:13 +0200 (CEST) Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com [209.85.221.195]) by dpdk.org (Postfix) with ESMTP id 18E791BE8E for ; Thu, 15 Aug 2019 08:53:12 +0200 (CEST) Received: by mail-vk1-f195.google.com with SMTP id b204so227214vka.7 for ; Wed, 14 Aug 2019 23:53:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2QSf1O9EXAEwgGCLDLosYlm89sD5I3EeP9+bil1/iqs=; b=EhxhjOl55MhuW/KfWqArQrVhp9mrzme/jDdeE0tuO6CR58jusqvtvIX568vWGTCKyP KdYEjGCzv0vmolrJmvpXjFYZx3vE+MMZpY/SVrax5RcS9oaXDgFFzSr7uvehH2Pu13Xb 1lxT7acX6DDDXGVTAQvL3XSAcf+rFCuZkFJgFsqiPeSqhVgNXoeMfHptvg6dZp5PRQWM 3qh0ZKImxbuJ2tgaZHppP9wFBd7WPn6GvQsmwA8Wo9olees9cjtBY3/P5oOxqYG9aUOm qA8ZX8rKnFBXTMldOXG0iEwOaOxasT0lOdtmb/JZZ8q46TJgTftWO4UTjciXqkMuN72F jlbQ== X-Gm-Message-State: APjAAAXZ/3LMxvvtFlJ7spAZjobRIhO3/d1Vp3yEhraRlkODVEFz0W1U LHsI1foK7/r3n+KBFY1GNIbrYJPM+PHglOND7ILVRQ== X-Google-Smtp-Source: APXvYqxP/RZhGENkZxRR5YX36XUau/Fa2BJmBMSNVzKnMFadmSvdQ1u0PsO3ePBl6PnyWhcSGEx+zvUJF3pflL6ppKI= X-Received: by 2002:a1f:50c1:: with SMTP id e184mr1480345vkb.86.1565851991450; Wed, 14 Aug 2019 23:53:11 -0700 (PDT) MIME-Version: 1.0 References: <1565807801-72546-1-git-send-email-drc@linux.vnet.ibm.com> <1565807801-72546-3-git-send-email-drc@linux.vnet.ibm.com> In-Reply-To: <1565807801-72546-3-git-send-email-drc@linux.vnet.ibm.com> From: David Marchand Date: Thu, 15 Aug 2019 08:53:00 +0200 Message-ID: To: David Christensen Cc: Maxime Coquelin , Tiwei Bie , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 14, 2019 at 8:37 PM David Christensen wrote: > > Use of %llx print formatting causes meson build error on Power systems with > RHEL 7.6 and gcc 4.8.5. Replace with PRIx64 macro. > > Fixes: 9b62e2da1844 (vhost: register new regions with userfaultfd) > Cc: maxime.coquelin@redhat.com > > Signed-off-by: David Christensen > --- > lib/librte_vhost/vhost_user.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index 0b72648..6a6d694 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -1086,10 +1086,11 @@ > goto err_mmap; > } > RTE_LOG(INFO, VHOST_CONFIG, > - "\t userfaultfd registered for range : %llx - %llx\n", > - reg_struct.range.start, > - reg_struct.range.start + > - reg_struct.range.len - 1); > + "\t userfaultfd registered for range : " > + "%" PRIx64 " - %" PRIx64 "\n", > + (uint64_t)reg_struct.range.start, > + (uint64_t)reg_struct.range.start + > + (uint64_t)reg_struct.range.len - 1); struct uffdio_register { struct uffdio_range range; ... struct uffdio_range { __u64 start; __u64 len; }; You can drop those casts. -- David Marchand