From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D105745E8E; Fri, 13 Dec 2024 15:36:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EF1740B8F; Fri, 13 Dec 2024 15:36:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 17230409FA for ; Fri, 13 Dec 2024 15:36:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734100585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xwMUB/0m6aq1Eo0b+rrp0TiJN2TMgWyMgd3JhUG1cQ8=; b=QrMCTtLSoF5pJ2D2h816S4jATOQmZALheGMrKU8qhMFDqYpFr1iA5BadJ2X/5loNQ2ZJtI sx5ctG45nxyWwp0oQ3KA08llQLKsc71Vlg/ssh/gLg4jtKvHGTj7Dw8EIYEbQ/5m33PFGb jx+G51sSPSDRMlBfsW/p7fiGsT5z3SI= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-39-0t9s2TGyPTiIk-7XNvrPjQ-1; Fri, 13 Dec 2024 09:36:24 -0500 X-MC-Unique: 0t9s2TGyPTiIk-7XNvrPjQ-1 X-Mimecast-MFC-AGG-ID: 0t9s2TGyPTiIk-7XNvrPjQ Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-53f167e95e6so957042e87.1 for ; Fri, 13 Dec 2024 06:36:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734100582; x=1734705382; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xwMUB/0m6aq1Eo0b+rrp0TiJN2TMgWyMgd3JhUG1cQ8=; b=IYZdLvSx4oI+s4/RFyl+6nPAeJh5NtXkkoiVQs9MZ17PWlDJ/mB4ok2mNNxybfHKnZ nO3B6IMxIL2lcqMFyHCSwPrMZzwMw5nXlRo/zQ7ikXW4uogxPtoO9ElqrZUE5HDrp5gL lv+ziZ0lhMinrCVaaNXGMZM30MbseiGRaeCs5Azu+oxLV1A6+qaTcrbvdjT2YVE0RnxW s9kh73feNBaFo0EABJEaoXczvmuNziHZmQiGL0OE11+WjJ7Qc4NsAYX5uzlP5j9w4Rzj fOCmN2AIPQ7RJjtp5jIttWawE7Yfqf8eoJzJCBK2hyQcLbmQFc1Oqtkh9Uh+L6tESuMK cgYw== X-Forwarded-Encrypted: i=1; AJvYcCX8q4dARNkHDoE6fkqIHFK/ymlmxuqpC1o+LW5JqqIynUYJnC/GDe/bDQs8yWpjsk8cSXs=@dpdk.org X-Gm-Message-State: AOJu0YychfjeWEod67G/HyFLqawYsJi28/hj7AD/TbYvInZbQPk6r6FC J1hrMRnQGZM64pQftoGhjujchZ1VQn3h/GD/5+l8e3azEeqyulLKDf8/1dhTnyvMJPcEVMgwdNR rh+tzx4fdnR/f17Y/scN/rgXPkVsBPHmIzvBvNS41pnI6FIFxeoLmlVHsD6RAyJzzEZX2j0AjkS qaYlM67QTooVg1WV0= X-Gm-Gg: ASbGnctbUPwiaVtEv4Rrw6BsJ1beZkk2OwM5IWCYasxPyBWG8hCeo+UjGrDQOyAJUW2 poSisaKdEEu08QrxN5m8qBJc0sw2k7OhsGn/qWnqM X-Received: by 2002:a05:6512:68f:b0:540:2ae6:fc36 with SMTP id 2adb3069b0e04-540342592camr1512318e87.8.1734100582427; Fri, 13 Dec 2024 06:36:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEEX8V0Wg1hWqS1v4EVVad2IKtykZ30fdEBQq0x4IubjckF0NpuuvY0mu76LFCkNyF9fCiJTe3wz8O2KkJ/NXQ= X-Received: by 2002:a05:6512:68f:b0:540:2ae6:fc36 with SMTP id 2adb3069b0e04-540342592camr1512307e87.8.1734100582037; Fri, 13 Dec 2024 06:36:22 -0800 (PST) MIME-Version: 1.0 References: <20241114084519.5128-1-chcchc88@163.com> <20241213022158.2644-1-chcchc88@163.com> In-Reply-To: <20241213022158.2644-1-chcchc88@163.com> From: David Marchand Date: Fri, 13 Dec 2024 15:36:11 +0100 Message-ID: Subject: Re: [PATCH v5] graph: mcore: optimize graph search To: Huichao Cai Cc: jerinj@marvell.com, kirankumark@marvell.com, ndabilpuram@marvell.com, yanzhirun_163@163.com, dev@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bzKaC80ms8ZfWbOygG6nwyVCcb_US0-5jm7Xxc2ICYs_1734100582 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Dec 13, 2024 at 3:22=E2=80=AFAM Huichao Cai wrot= e: > diff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_wo= rker_common.h > index d3ec88519d..aef0f65673 100644 > --- a/lib/graph/rte_graph_worker_common.h > +++ b/lib/graph/rte_graph_worker_common.h > @@ -110,6 +110,7 @@ struct __rte_cache_aligned rte_node { > unsigned int lcore_id; /**< Node running lcore. = */ > uint64_t total_sched_objs; /**< Number of objects= scheduled. */ > uint64_t total_sched_fail; /**< Number of schedul= ed failure. */ > + struct rte_graph *graph; /**< Graph correspondin= g to lcore_id. */ > } dispatch; > }; The rte_node struct size is not changed with this patch. In v24.11, rte_node objects are populated/allocated in graph_nodes_populate which zero's the whole rte_node. So this change looks safe from an ABI compat with v24.11 pov. However, we need to waive the warning from libabigail: http://mails.dpdk.org/archives/test-report/2024-December/834167.html Please add a temporary exception in devtools/libabigail.abignore. It should be something like: [suppress_type] name =3D rte_node has_size_change =3D no has_data_member_inserted_between =3D {offset_of(total_sched_fail), offset_of(xstat_off)} --=20 David Marchand