From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Aaron Conole <aconole@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul
Date: Fri, 12 Mar 2021 09:07:22 +0100 [thread overview]
Message-ID: <CAJFAV8yXgr5s-fkXFYNNT5PH8afO8W6FG39OP3MVo5-ykxmcMg@mail.gmail.com> (raw)
In-Reply-To: <1615496911-7050-1-git-send-email-roretzla@linux.microsoft.com>
On Thu, Mar 11, 2021 at 10:08 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> Avoid expanding v and mul parameters multiple times in the macro. based
> on usage of the macro it seems like side effects were not intended.
>
> For example:
> ``return RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ);''
That's the beauty of macros.
How about updating the unit tests so that this kind of issue is not
reintroduced?
Are other RTE_ALIGN_* macro affected with similar issues?
Like mul expression passed to RTE_ALIGN_MUL_FLOOR and RTE_ALIGN_MUL_CEIL.
--
David Marchand
next prev parent reply other threads:[~2021-03-12 8:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 21:08 Tyler Retzlaff
2021-03-12 0:40 ` Ranjit Menon
2021-03-12 1:34 ` Tyler Retzlaff
2021-03-12 4:41 ` Ranjit Menon
2021-03-12 6:28 ` Tyler Retzlaff
2021-03-12 8:07 ` David Marchand [this message]
2021-03-12 18:49 ` Tyler Retzlaff
2021-05-05 16:30 ` Tyler Retzlaff
2021-05-05 20:28 ` David Marchand
2021-05-06 12:24 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yXgr5s-fkXFYNNT5PH8afO8W6FG39OP3MVo5-ykxmcMg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).