From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2A00A0577; Tue, 7 Apr 2020 09:36:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0745CFFA; Tue, 7 Apr 2020 09:36:38 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 2AC26FFA for <dev@dpdk.org>; Tue, 7 Apr 2020 09:36:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586244995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CR9KlgOwhAeAGbQbKK9L/4qTvypx6YcDiaG4WSE0s3Q=; b=IHg7llk3ZFj2RO/iXjhpLZBzDD5qM8Rv6zUVb3AotIkedD5YYp9+Tw6oflwBxWhsDor2tk Jaqh9vRs9JHmSrz6Zp9nLtSXDHomLAdmjhinL1bH6kwhe5x9HQ+rqJttK7KEIP0Pg6xFWu 17VizHRYxyfYAS84PCG3M4wIfBqlMrU= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-cYf1GTaDMHO-vgfgvydB_w-1; Tue, 07 Apr 2020 03:36:32 -0400 X-MC-Unique: cYf1GTaDMHO-vgfgvydB_w-1 Received: by mail-ua1-f70.google.com with SMTP id o32so910928uae.0 for <dev@dpdk.org>; Tue, 07 Apr 2020 00:36:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JPvBJlcKyQyDJ7QQ/EI7WElazr0hIWoh4S9gyiKGO+4=; b=cR89btzzIF+pFK7c3ZgMbjR5x1cZiOBmd2i1B+yAvBWjW2HafhyrioR6MSlcsnMKiN xbLPaqrL9WT+/dIVIOYZjlZ+SOVTuRB9ChLkFcBEzK8athErS2X6/cqykvuL09tDhLGP qsfLTLDp1IhRMnGDJp+krUSPrFlRtCpiA5ywjOnmuCqq3V6qkCYHfBXhgun2fQiWkUZX oGwMHftfyGeSH3sPcYjk0jq5qlW5pO3RVq1WRz56nuIxDjRcSDcl0WADpAl2z5YvRjyA XS9ZkpUZoBGibO1CZKqC4A4FRU0gDPCH/jzVv0zvsdQBoQl/hQQyCTcejaDtiLHeVqMN tucA== X-Gm-Message-State: AGi0PubbMTVA0QOJrZEbSDwhfamAyLTNokgigquqN6SFIPS8E+zlINog iILxSFA6AYMkBvC9mQHWUieiXeRjCjrT+dByO63DECeQid4RetsFHGkbYfHYbLxmI+T9YLnipCh ZFVOuNfY80Xgm7P7PA94= X-Received: by 2002:a67:e995:: with SMTP id b21mr812335vso.105.1586244991568; Tue, 07 Apr 2020 00:36:31 -0700 (PDT) X-Google-Smtp-Source: APiQypKecJS6ZhlACrBGbaJpCL1NS9kAxTR6r7+x1nRVyLUoSnyguOF4XGZq8SwOXn2+48UYpTLbIyPsrW5iEJLweVg= X-Received: by 2002:a67:e995:: with SMTP id b21mr812219vso.105.1586244988603; Tue, 07 Apr 2020 00:36:28 -0700 (PDT) MIME-Version: 1.0 References: <20200406193430.81268-1-nhorman@tuxdriver.com> In-Reply-To: <20200406193430.81268-1-nhorman@tuxdriver.com> From: David Marchand <david.marchand@redhat.com> Date: Tue, 7 Apr 2020 09:36:17 +0200 Message-ID: <CAJFAV8yXuFggWmDCibi4uQGaRDXo+MaDM2HGW5ZQ-B22OftzzA@mail.gmail.com> To: Neil Horman <nhorman@tuxdriver.com> Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Kevin Laatz <kevin.laatz@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, Apr 6, 2020 at 9:34 PM Neil Horman <nhorman@tuxdriver.com> wrote: > > Since we've moved away from our initial abi_versioning.sh script, in abi_versioning.sh does not exist (idem with the patch title). I suppose you meant validate-abi.sh. > favor of check_abi.sh, which uses libabigail, remove the old script from check-abi.sh > the tree, and update the docs accordingly > [snip] > diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/cont= ributing/abi_versioning.rst > index a21f4e7a4..1c4a3f927 100644 > --- a/doc/guides/contributing/abi_versioning.rst > +++ b/doc/guides/contributing/abi_versioning.rst > @@ -482,9 +482,9 @@ Running the ABI Validator > ------------------------- > > The ``devtools`` directory in the DPDK source tree contains a utility pr= ogram, > -``validate-abi.sh``, for validating the DPDK ABI based on the Linux `ABI > -Compliance Checker > -<http://ispras.linuxbase.org/index.php/ABI_compliance_checker>`_. > +``check-abi.sh``, for validating the DPDK ABI based on the libabigail ab= idiff > +utility: > +https://sourceware.org/libabigail/manual/abidiff.html > > This has a dependency on the ``abi-compliance-checker`` and ``and abi-du= mper`` > utilities which can be installed via a package manager. For example:: > @@ -492,9 +492,9 @@ utilities which can be installed via a package manage= r. For example:: > sudo yum install abi-compliance-checker > sudo yum install abi-dumper > > -The syntax of the ``validate-abi.sh`` utility is:: > +The syntax of the ``check-abi.sh`` utility is:: > > - ./devtools/validate-abi.sh <REV1> <REV2> > + ./devtools/check-abi.sh <REV1> <REV2> The new script is not a direct replacement. It won't take git revisions, but build directories where versions of dpdk have been compiled. devtools/test-build.sh and devtools/test-meson-builds.sh illustrate its use= . https://git.dpdk.org/dpdk/tree/devtools/test-meson-builds.sh#n127 --=20 David Marchand